* [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
@ 2021-01-21 18:37 Andy Shevchenko
2021-12-13 20:36 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-01-21 18:37 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, Vikas Gupta, Jens Wiklander,
tee-dev
Cc: Andy Shevchenko
There is export_uuid() function which exports uuid_t to the u8 array.
Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..4cf0c2576037 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
return -ENODEV;
/* Open session with Bnxt load Trusted App */
- memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+ export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
sess_arg.num_params = 0;
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2021-01-21 18:37 [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID Andy Shevchenko
@ 2021-12-13 20:36 ` Andy Shevchenko
2021-12-13 20:37 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-12-13 20:36 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, Vikas Gupta, Jens Wiklander,
tee-dev
On Thu, Jan 21, 2021 at 08:37:41PM +0200, Andy Shevchenko wrote:
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
Folks, is this orphaned driver? Should we update MAINTAINERS accordingly?
If not, why review is not done yes for more than half a year?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2021-12-13 20:36 ` Andy Shevchenko
@ 2021-12-13 20:37 ` Andy Shevchenko
2022-01-04 9:24 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-12-13 20:37 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, Vikas Gupta, Jens Wiklander,
tee-dev
Cc: Christoph Hellwig
+ Cc: Christoph. Maybe you can apply this one, please?
On Mon, Dec 13, 2021 at 10:36:55PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 21, 2021 at 08:37:41PM +0200, Andy Shevchenko wrote:
> > There is export_uuid() function which exports uuid_t to the u8 array.
> > Use it instead of open coding variant.
>
> Folks, is this orphaned driver? Should we update MAINTAINERS accordingly?
> If not, why review is not done yes for more than half a year?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2021-12-13 20:37 ` Andy Shevchenko
@ 2022-01-04 9:24 ` Christoph Hellwig
2022-01-04 13:41 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2022-01-04 9:24 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafał Miłecki, linux-mips, Vikas Gupta, Jens Wiklander,
tee-dev, Christoph Hellwig
On Mon, Dec 13, 2021 at 10:37:55PM +0200, Andy Shevchenko wrote:
> + Cc: Christoph. Maybe you can apply this one, please?
I've not even seen the original patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-01-04 9:24 ` Christoph Hellwig
@ 2022-01-04 13:41 ` Andy Shevchenko
2022-01-27 16:02 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2022-01-04 13:41 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Rafał Miłecki, linux-mips, Vikas Gupta, Jens Wiklander,
tee-dev
On Tue, Jan 04, 2022 at 10:24:06AM +0100, Christoph Hellwig wrote:
> On Mon, Dec 13, 2021 at 10:37:55PM +0200, Andy Shevchenko wrote:
> > + Cc: Christoph. Maybe you can apply this one, please?
>
> I've not even seen the original patch.
It's easy to retrieve with b4 tool:
`b4 am -s 20210121183741.45333-1-andriy.shevchenko@linux.intel.com`
But for your convenience I may resend once more with you being Cc'ed.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-01-04 13:41 ` Andy Shevchenko
@ 2022-01-27 16:02 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2022-01-27 16:02 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Rafał Miłecki, linux-mips, Vikas Gupta, Jens Wiklander,
tee-dev
On Tue, Jan 04, 2022 at 03:41:51PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 04, 2022 at 10:24:06AM +0100, Christoph Hellwig wrote:
> > On Mon, Dec 13, 2021 at 10:37:55PM +0200, Andy Shevchenko wrote:
> > > + Cc: Christoph. Maybe you can apply this one, please?
> >
> > I've not even seen the original patch.
>
> It's easy to retrieve with b4 tool:
> `b4 am -s 20210121183741.45333-1-andriy.shevchenko@linux.intel.com`
>
> But for your convenience I may resend once more with you being Cc'ed.
Just sent a v2 which is basically the same :-)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-27 16:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 18:37 [RESEND PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID Andy Shevchenko
2021-12-13 20:36 ` Andy Shevchenko
2021-12-13 20:37 ` Andy Shevchenko
2022-01-04 9:24 ` Christoph Hellwig
2022-01-04 13:41 ` Andy Shevchenko
2022-01-27 16:02 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.