From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Luca Boccassi <bluca@debian.org>,
dwarves@vger.kernel.org
Subject: Re: [PATCH dwarves] libbpf: allow to use packaged version
Date: Thu, 21 Jan 2021 17:34:46 -0300 [thread overview]
Message-ID: <20210121203446.GF356537@kernel.org> (raw)
In-Reply-To: <CAEf4BzZn_dkeWxfAB_ysWgLnAvUUcPoNi0yHbLPkiBWW9Lh5BA@mail.gmail.com>
Em Thu, Jan 21, 2021 at 12:02:53PM -0800, Andrii Nakryiko escreveu:
> On Thu, Jan 21, 2021 at 5:29 AM Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote:
> > Em Mon, Jan 04, 2021 at 10:17:36PM +0000, Luca Boccassi escreveu:
> > > On Mon, 2021-01-04 at 12:23 -0800, Andrii Nakryiko wrote:
> > > > One quick and easy hack would be to put a symlink lib/include/bpf ->
> > > > lib/bpf/src into pahole repo. And add -Ilib/include to let compiler
> > > > handle <bpf/*.h> properly.
> >
> > > Sure, that works for me if it's acceptable as a solution. Sent v3 that
> > > implements it. Thanks for the suggestion.
> >
> > Andrii, can I have your Reviewed-by or Acked-by for v3?
>
> Well, I still think it's not good and not necessary for pahole. pahole
> doesn't run under root. It's not a networking application open to the
> world either. So I don't buy security arguments in this case at all.
> So no, feel free to push this, but without my ack.
Ok, fair enough, I applied the patch, the default behaviour is the one
we like, so should be no problem for us :-)
- Arnaldo
next prev parent reply other threads:[~2021-01-21 20:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 18:22 [PATCH dwarves] libbpf: allow to use packaged version Luca Boccassi
2021-01-03 19:10 ` Andrii Nakryiko
2021-01-03 21:30 ` Luca Boccassi
2021-01-04 20:23 ` Andrii Nakryiko
2021-01-04 22:17 ` Luca Boccassi
2021-01-21 13:29 ` Arnaldo Carvalho de Melo
2021-01-21 20:02 ` Andrii Nakryiko
2021-01-21 20:33 ` Arnaldo Carvalho de Melo
2021-01-21 20:34 ` Arnaldo Carvalho de Melo [this message]
2021-01-21 21:19 ` Luca Boccassi
2021-01-15 15:29 ` Arnaldo Carvalho de Melo
2021-01-15 15:40 ` Luca Boccassi
2021-06-09 16:07 ` Arnaldo Carvalho de Melo
2021-06-09 16:11 ` Luca Boccassi
2021-01-03 21:32 ` [PATCH dwarves v2] " Luca Boccassi
2021-01-04 22:16 ` [PATCH dwarves v3] " Luca Boccassi
2021-01-13 11:18 ` Arnaldo Carvalho de Melo
2021-03-30 4:47 ` Dominique Martinet
2021-03-30 10:50 ` Luca Boccassi
2021-03-30 11:06 ` Luca Boccassi
2021-03-30 11:45 ` Dominique Martinet
2021-03-30 15:12 ` Arnaldo Carvalho de Melo
2021-03-31 1:05 ` Dominique Martinet
2021-04-13 13:42 ` Luca Boccassi
2021-05-18 14:07 ` Luca Boccassi
2021-06-09 4:10 ` Dominique Martinet
2021-06-09 16:25 ` Arnaldo Carvalho de Melo
2021-06-09 16:38 ` Arnaldo Carvalho de Melo
2021-06-09 16:43 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121203446.GF356537@kernel.org \
--to=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bluca@debian.org \
--cc=dwarves@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.