From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 21 Jan 2021 13:57:10 -0700 Subject: [PATCH 05/11] dm: core: Don't inline dev_read...() calls with of-platdata In-Reply-To: <20210121205716.964652-1-sjg@chromium.org> References: <20210121205716.964652-1-sjg@chromium.org> Message-ID: <20210121205716.964652-6-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de At present if these calls are used with of-platdata, a confusing error is produced, referring to a function not actually called by the code causing the problem. Fix this by not inlining, so that the error mentions the dev_read_...() function and it is more obvious what is going on. Signed-off-by: Simon Glass --- include/dm/read.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/dm/read.h b/include/dm/read.h index c875e11a132..f6f8b875d1c 100644 --- a/include/dm/read.h +++ b/include/dm/read.h @@ -30,8 +30,7 @@ static inline const struct device_node *dev_np(const struct udevice *dev) } #endif -#ifndef CONFIG_DM_DEV_READ_INLINE - +#if !defined(CONFIG_DM_DEV_READ_INLINE) || CONFIG_IS_ENABLED(OF_PLATDATA) /** * dev_read_u32() - read a 32-bit integer from a device's DT property * -- 2.30.0.280.ga3ce27912f-goog