All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/qt5webengine: add optional host-freetype/host-libjpeg dependency
Date: Thu, 21 Jan 2021 22:03:00 +0100	[thread overview]
Message-ID: <20210121220300.6858c020@gmx.net> (raw)
In-Reply-To: <20210119222234.29ac8a2a@windsurf.home>

Hello Thomas,

On Tue, 19 Jan 2021 22:22:34 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Peter,
>
> On Wed, 30 Dec 2020 11:18:23 +0100
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
> > > +ifeq ($(BR2_PACKAGE_QT5BASE_FONTCONFIG),y)
> > > +QT5WEBENGINE_DEPENDENCIES += host-freetype
> > > +endif
> > > +
> > > +ifeq ($(BR2_PACKAGE_QT5BASE_JPEG),y)
> > > +QT5WEBENGINE_DEPENDENCIES += host-libjpeg
> > > +endif
> >
> > This looks really odd. Why would these target-related features require
> > host-freetype and host-libjpeg ? Aren't we instead seeing some
> > pkg-config issue where it's trying to find freetype/libjpeg for the
> > target, but it for some reason doesn't work, and tries to find them for
> > the host ?
>
> Do you have some further feedback on this issue ?

Did try to find out where the mismatch comes from...., but without success...

The best solution/hack so far is:

--- a/package/qt5/qt5webengine/host-pkg-config.in
+++ b/package/qt5/qt5webengine/host-pkg-config.in
@@ -2,5 +2,5 @@
 PKG_CONFIG_SYSROOT_DIR="/" \
 PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
-PKG_CONFIG_LIBDIR="@HOST_DIR@/lib/pkgconfig:@HOST_DIR@/share/pkgconfig" \
+PKG_CONFIG_LIBDIR="@HOST_DIR@/lib/pkgconfig:@HOST_DIR@/share/pkgconfig:@SYSROOT@/usr/lib/pkgconfig" \
 exec @HOST_DIR@/bin/pkgconf "$@"


--- a/package/qt5/qt5webengine/qt5webengine.mk
+++ b/package/qt5/qt5webengine/qt5webengine.mk
@@ -54,7 +54,7 @@ QT5WEBENGINE_PRE_CONFIGURE_HOOKS += QT5WEBENGINE_PYTHON2_SYMLINK
 QT5WEBENGINE_ENV += NINJAFLAGS="-j$(PARALLEL_JOBS)"

 define QT5WEBENGINE_CREATE_HOST_PKG_CONFIG
-	sed s%@HOST_DIR@%$(HOST_DIR)%g $(QT5WEBENGINE_PKGDIR)/host-pkg-config.in > $(@D)/host-bin/host-pkg-config
+	sed s%@HOST_DIR@%$(HOST_DIR)%g $(QT5WEBENGINE_PKGDIR)/host-pkg-config.in | sed s%@SYSROOT@%$(STAGING_DIR)%g > $(@D)/host-bin/host-pkg-config
 	chmod +x $(@D)/host-bin/host-pkg-config
 endef
 QT5WEBENGINE_PRE_CONFIGURE_HOOKS += QT5WEBENGINE_CREATE_HOST_PKG_CONFIG

Regards,
Peter

>
> Thanks!
>
> Thomas

  reply	other threads:[~2021-01-21 21:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 20:39 [Buildroot] [PATCH v1 0/2] Raspberry Pi - bump kernel version to 967d45b (5.10.1) Peter Seiderer
2020-12-21 20:39 ` [Buildroot] [PATCH v1 1/2] configs/raspberrypi*: " Peter Seiderer
2020-12-22 18:51   ` Marcin Niestrój
2020-12-23  9:12   ` Peter Korsgaard
2020-12-21 20:39 ` [Buildroot] [PATCH v1] package/qt5webengine: add optional host-freetype/host-libjpeg dependency Peter Seiderer
2020-12-30 10:18   ` Thomas Petazzoni
2021-01-19 21:22     ` Thomas Petazzoni
2021-01-21 21:03       ` Peter Seiderer [this message]
2021-01-21 21:09         ` Thomas Petazzoni
2022-01-09 13:27   ` Thomas Petazzoni
2022-01-09 13:44     ` Thomas Petazzoni
2022-01-15 23:04       ` Peter Seiderer
2022-01-15 23:03     ` Peter Seiderer
2022-01-16 10:38   ` James Hilliard
2020-12-21 20:39 ` [Buildroot] [PATCH v1 2/2] package/rpi-firmware: bump version to d016a6e Peter Seiderer
2020-12-22 18:52   ` Marcin Niestrój
2020-12-23  9:12   ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2020-12-20 14:57 [Buildroot] [PATCH v1] package/qt5webengine: add optional host-freetype/host-libjpeg dependency Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121220300.6858c020@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.