From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <prvs=649de9d05=shinichiro.kawasaki@wdc.com>
From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH v3 01/38] zbd: return ENOMEM if zone buffer allocation
 fails
Date: Fri, 22 Jan 2021 02:07:29 +0000
Message-ID: <20210122020728.pdxzuomnbgdadzr7@shindev.dhcp.fujisawa.hgst.com>
References: <20210106215739.264524-1-dmitry.fomichev@wdc.com>
 <20210106215739.264524-2-dmitry.fomichev@wdc.com>
In-Reply-To: <20210106215739.264524-2-dmitry.fomichev@wdc.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AE14DBBFB3D1C34C80A0057F3B03F94A@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, "fio@vger.kernel.org" <fio@vger.kernel.org>, Aravind Ramesh <Aravind.Ramesh@wdc.com>, Bart Van Assche <bvanassche@acm.org>, Naohiro Aota <Naohiro.Aota@wdc.com>, Niklas Cassel <Niklas.Cassel@wdc.com>, Damien Le Moal <Damien.LeMoal@wdc.com>
List-ID: <fio@vger.kernel.org>

On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote:
> parse_zone_info() function tries to allocate a buffer of
> ZBD_REPORT_MAX_ZONES zone descriptors and exits if this allocation
> fails. The problem is that it returns 0 error code in this case and
> the caller may interpret this as the success.
>=20
> Just return ENOMEM if we can't allocate that buffer.
>=20
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

--=20
Best Regards,
Shin'ichiro Kawasaki=