From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <prvs=649de9d05=shinichiro.kawasaki@wdc.com>
From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH v3 02/38] zbd: use zbd_zone_nr() more actively in the code
Date: Fri, 22 Jan 2021 02:14:25 +0000
Message-ID: <20210122021424.mn6zyzse6zwpzbhx@shindev.dhcp.fujisawa.hgst.com>
References: <20210106215739.264524-1-dmitry.fomichev@wdc.com>
 <20210106215739.264524-3-dmitry.fomichev@wdc.com>
In-Reply-To: <20210106215739.264524-3-dmitry.fomichev@wdc.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BE7FE497F6896E459D49E894DFC9FA02@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, "fio@vger.kernel.org" <fio@vger.kernel.org>, Aravind Ramesh <Aravind.Ramesh@wdc.com>, Bart Van Assche <bvanassche@acm.org>, Naohiro Aota <Naohiro.Aota@wdc.com>, Niklas Cassel <Niklas.Cassel@wdc.com>, Damien Le Moal <Damien.LeMoal@wdc.com>
List-ID: <fio@vger.kernel.org>

On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote:
> The function zbd_zone_nr() is always called with the first argument
> being f->zbd_info. If "f" is made the first argument instead, calls
> of this function become more compact end easier to read.
>=20
> Besides this change, convert several places in the code where the same
> zone number calculation is open coded to zbd_zone_nr() calls.
> This is a refactoring patch, no change in functionality.
>=20
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

--=20
Best Regards,
Shin'ichiro Kawasaki=