From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Shinichiro Kawasaki Subject: Re: [PATCH v3 08/38] zbd: avoid zone buffer overrun Date: Fri, 22 Jan 2021 04:02:11 +0000 Message-ID: <20210122040208.xsvxwr5mcq37nz4u@shindev.dhcp.fujisawa.hgst.com> References: <20210106215739.264524-1-dmitry.fomichev@wdc.com> <20210106215739.264524-9-dmitry.fomichev@wdc.com> In-Reply-To: <20210106215739.264524-9-dmitry.fomichev@wdc.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <662CB4A5599ABD4396DF95E1A4ACC617@namprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 To: Dmitry Fomichev Cc: Jens Axboe , "fio@vger.kernel.org" , Aravind Ramesh , Bart Van Assche , Naohiro Aota , Niklas Cassel , Damien Le Moal List-ID: On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote: > If the total number of zones on a drive is calculated to a value that > is less than the number of zones it can actually report, zone info > buffer can be overrun. This may happen not only due to drive firmware > problems, but also because of underlying software incorrectly > reporting zoned device capacity. >=20 > Fix this by more carefully setting zone report size. >=20 > Signed-off-by: Dmitry Fomichev Looks good to me. Reviewed-by: Shin'ichiro Kawasaki --=20 Best Regards, Shin'ichiro Kawasaki=