From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Shinichiro Kawasaki Subject: Re: [PATCH v3 14/38] zbd: initialize sectors with data at start time Date: Fri, 22 Jan 2021 04:19:55 +0000 Message-ID: <20210122041953.st67la6kse74s2zw@shindev.dhcp.fujisawa.hgst.com> References: <20210106215739.264524-1-dmitry.fomichev@wdc.com> <20210106215739.264524-15-dmitry.fomichev@wdc.com> In-Reply-To: <20210106215739.264524-15-dmitry.fomichev@wdc.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <13E1C88F190E354895D7982F04E6DF6F@namprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 To: Dmitry Fomichev Cc: Jens Axboe , "fio@vger.kernel.org" , Aravind Ramesh , Bart Van Assche , Naohiro Aota , Niklas Cassel , Damien Le Moal List-ID: On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote: > From: Aravind Ramesh >=20 > Based on the flag enable_check_swd, which is false by default, fio > does not initialize the swd value at startup, initializing the swd > value to be zero, even if some zones have sectors with data. This can > result in fio reflecting less than actual swd after a few writes are > completed. In workloads where verify is enabled, fio resets all the > zones and while resetting, it decrements the swd counter with the > actual number of swds in that zone(swd-count - swd-in-zone), > since swd-count is initialized to 0, it results in overflow of the > variable causing unpredictable issues. >=20 > So, initialize the swd to the correct value. >=20 > Fixes: 409a4f291e7f ("zbd: avoid initializing swd when unnecessary") > Signed-off-by: Aravind Ramesh > Signed-off-by: Dmitry Fomichev Looks good to me. Reviewed-by: Shin'ichiro Kawasaki --=20 Best Regards, Shin'ichiro Kawasaki=