All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bill Mills <bill.mills@linaro.org>,
	anmar.oueja@linaro.org
Subject: Re: [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay
Date: Fri, 22 Jan 2021 15:27:04 +1100	[thread overview]
Message-ID: <20210122042704.GC4400@yekko.fritz.box> (raw)
In-Reply-To: <20210122031049.u3nmxxzzhue5rniu@vireshk-i7>

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

On Fri, Jan 22, 2021 at 08:40:49AM +0530, Viresh Kumar wrote:
> On 22-01-21, 10:39, David Gibson wrote:
> > No, it definitely will not work in general.  It might kinda work in a
> > few trivial cases, but it absolutely will not do the neccessary
> > handling in some cases.
> > 
> > > I
> > > did inspect the output dtb (made by merging two overlays) using
> > > fdtdump and it looked okay.
> > 
> > Ok.. but if you're using these bizarre messed up "dtbs" that this test
> > code seems to be, I don't really trust that tells you much.
> 
> I only looked if the changes from the second overlay were present in
> the merge and they were. And so I assumed that it must have worked.
> 
> What about checking the base dtb for /plugin/; in fdtoverlay and fail
> the whole thing in case it is present ? I think it is possible for
> people to get confused otherwise, like I did.

/plugin/ doesn't exist in the dtb, only in the dts.  From the dtb
encoding point of view, there's no difference between a dtb and a
dtbo, a dtbo is just a dtb that follows some conventions for its
content.

If we were doing this from scratch, it would be better for dtbos to
have a different magic number from regular dtbs.  I think I actually
suggested that sometime in the past, but by the time that came up,
dtbos were already in pretty widespread use with the existing format.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-01-22  5:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  7:06 [PATCH V5 0/5] dt: build overlays Viresh Kumar
2021-01-20  7:06 ` [PATCH V5 1/5] scripts: dtc: Fetch fdtoverlay.c from external DTC project Viresh Kumar
2021-01-20  7:06 ` [PATCH V5 2/5] scripts: dtc: Build fdtoverlay tool Viresh Kumar
2021-01-20  7:06 ` [PATCH V5 3/5] scripts: dtc: Remove the unused fdtdump.c file Viresh Kumar
2021-01-21  0:44   ` David Gibson
2021-01-21  4:17     ` Viresh Kumar
2021-01-21  6:26       ` David Gibson
2021-01-21 14:18         ` Rob Herring
2021-01-20  7:06 ` [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo) Viresh Kumar
2021-01-20  8:58   ` Masahiro Yamada
2021-01-20  9:55     ` Viresh Kumar
2021-01-20 11:04       ` Masahiro Yamada
2021-01-20 11:27         ` Viresh Kumar
2021-01-21  0:49   ` David Gibson
2021-01-21  4:13     ` Viresh Kumar
2021-01-21  5:40       ` Frank Rowand
2021-01-21  6:25       ` David Gibson
2021-01-20  7:06 ` [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-01-21  0:51   ` David Gibson
2021-01-21  5:14     ` Frank Rowand
2021-01-21  5:34       ` Viresh Kumar
2021-01-21  5:45         ` Frank Rowand
2021-01-21  5:50           ` Viresh Kumar
2021-01-21  6:36             ` David Gibson
2021-01-21  6:34         ` David Gibson
2021-01-21  6:57           ` Viresh Kumar
2021-01-21 23:39             ` David Gibson
2021-01-22  3:10               ` Viresh Kumar
2021-01-22  4:27                 ` David Gibson [this message]
2021-01-21  5:34       ` Frank Rowand
2021-01-21  5:43         ` Viresh Kumar
2021-01-21  5:55           ` Frank Rowand
2021-01-21  5:58             ` Viresh Kumar
2021-01-21  7:04               ` Frank Rowand
2021-01-21 23:41                 ` David Gibson
2021-01-21  6:37             ` David Gibson
2021-01-20 15:43 ` [PATCH V5 0/5] dt: build overlays Rob Herring
2021-01-21  4:14   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122042704.GC4400@yekko.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=anmar.oueja@linaro.org \
    --cc=bill.mills@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robh+dt@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.