From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99E6C433E0 for ; Fri, 22 Jan 2021 04:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96931230FC for ; Fri, 22 Jan 2021 04:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbhAVEfv (ORCPT ); Thu, 21 Jan 2021 23:35:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbhAVEft (ORCPT ); Thu, 21 Jan 2021 23:35:49 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9218C061756 for ; Thu, 21 Jan 2021 20:35:09 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id e6so3055511pjj.1 for ; Thu, 21 Jan 2021 20:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yetUGqIq6nwDP/Z5XoMcv9Fbw9FD3H4M8DzhhGq80G4=; b=bcp+GOMzL9ijzDOWNP7XZsMTtd3/kiRN5ST2t1isOPSlwMc4uIda0EOzl9jSq2xcFT YExngj2Yc4a8PWDpqao1t61oNjSIhvSBEEBTXptB+Jdr6am3AOVnop1dLRf1oyw3w2Nq NIZpM2O/bW3PGC3rBHUfsrtjcXsaki+ah5uAgXdM2Y3E8XdtBkUxL4gT3pp85jVKoTgC FcAZedd0fshyrcDxcFMrSIaFdb0Ur4PfM0o7//yARqA1hoTS/8y6Vxwx5PF4TrUx5vhH UoX0EJTK3g13TUfaf4cbK6GCRPXpJcDpZWjaKfS2PRULah/HANv8IPloOf0SvXxtAsOT ir9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yetUGqIq6nwDP/Z5XoMcv9Fbw9FD3H4M8DzhhGq80G4=; b=DPKq4UIG4TvjoZpvMTZzcsYZJAuKp1gvRWSNg6P7/IJX22Nwao+nFUXlYc+UTxCx04 HlfBAstffJfg+0F9oPoaqbB713RW9xb+LL6eVfU/kryJSOpDQvvj7JyTcF7LFUkBIiEu TnE4lcKlOmuWuZdDG0YyfBP/qJhvh1jnTm0os0YpkHpKe0JdkxI/zzFrx/C/ipM/a4nK NzxQH/XuUyv3hPBQKYaLvdxoqUhMsZdQm6w5pDp6objfRixeomXfKZjRCI03OGEKX+4D mJx5b7EmrrCCvXre0jwbUZEadwE8RhigqNq+BEWWhPxGadV51AfsuABIr5lr0TODvs8Y DiXw== X-Gm-Message-State: AOAM532OEJQjbDzgzjbHzB2x/zuq3CbVfgJ6JOP8F6ejgkrC/j3Xbeoh TZ9LnjFViqaX9NghLOi/hGX4vw== X-Google-Smtp-Source: ABdhPJx1VRpZysMio5HKg8II4nInDm6FtWRYuxHyTtXWeliAjY/fbVa0zm+yb9pGb1PBCIDixdfUIA== X-Received: by 2002:a17:90a:9918:: with SMTP id b24mr3155479pjp.108.1611290109187; Thu, 21 Jan 2021 20:35:09 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id o10sm7187231pfp.87.2021.01.21.20.35.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 20:35:08 -0800 (PST) Date: Fri, 22 Jan 2021 10:05:06 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices Message-ID: <20210122043506.lm6yiefzlyubq5my@vireshk-i7> References: <1585f6c21ea8aee64fe4da0bf72b36ea4d74a779.1611227342.git.viresh.kumar@linaro.org> <9b2638e6-b842-8737-e5a0-aeeb84927fce@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9b2638e6-b842-8737-e5a0-aeeb84927fce@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 21-01-21, 23:26, Dmitry Osipenko wrote: > 21.01.2021 14:17, Viresh Kumar пишет: > > In order to avoid conditional statements at the caller site, this patch > > updates _generic_set_opp_clk_only() to work for devices that don't > > change frequency (like power domains, etc.). Return 0 if the clk pointer > > passed to this routine is not valid. > > > > Signed-off-by: Viresh Kumar > > --- > ... > > Hello Viresh, > > Thank you very much for yours effort! I gave a quick test to this series > and instantly found one small issue in this patch. > > > + /* We may reach here for devices which don't change frequency */ > > + if (unlikely(!clk)) > > I replaced dev_pm_opp_set_voltage() with dev_pm_opp_set_opp() in the > Tegra PD driver and got a crash, which happens because the above line > should be: > > if (IS_ERR(clk)) Fixed, thanks. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E53C433DB for ; Fri, 22 Jan 2021 04:37:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96C9523884 for ; Fri, 22 Jan 2021 04:37:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96C9523884 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1q5uV2usnBRlvkrdTuZhoIGjxrotilLNo1bg37/FMJs=; b=y547geS87v4BSlvyGN/hgz6tE KIHENBcVyQE+bi55bt0HXkYbuZyhghPpUBWcS6y3n9nPEK2pDiNsB6qYQYpYgFnbpot66e3YLw+sM 8fNzepJrQDERSSQ9q6xpLr2jnIS5tRBV2ML42nSW0REqDA5v5gKexmVtrvU8e7DjaVTauz28sefxS OcQnaYBth/y00046V4ojBL4IqZ0Xy5lbW8nDfwxKaV0o8pbzCiXTkrzNITBfqZ/grZfE7+LPWAPcc Qtlzasu50oj7V9+4etsBGK1QQXj0vk63mWXGj2GShWuEBOksJGamI7jl3TiTm1SiBWuclR6wJ7TgY nsNnZfGPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2oAF-0007lb-E5; Fri, 22 Jan 2021 04:35:15 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2oAC-0007lD-E1 for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 04:35:13 +0000 Received: by mail-pj1-x1031.google.com with SMTP id m5so3035158pjv.5 for ; Thu, 21 Jan 2021 20:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yetUGqIq6nwDP/Z5XoMcv9Fbw9FD3H4M8DzhhGq80G4=; b=bcp+GOMzL9ijzDOWNP7XZsMTtd3/kiRN5ST2t1isOPSlwMc4uIda0EOzl9jSq2xcFT YExngj2Yc4a8PWDpqao1t61oNjSIhvSBEEBTXptB+Jdr6am3AOVnop1dLRf1oyw3w2Nq NIZpM2O/bW3PGC3rBHUfsrtjcXsaki+ah5uAgXdM2Y3E8XdtBkUxL4gT3pp85jVKoTgC FcAZedd0fshyrcDxcFMrSIaFdb0Ur4PfM0o7//yARqA1hoTS/8y6Vxwx5PF4TrUx5vhH UoX0EJTK3g13TUfaf4cbK6GCRPXpJcDpZWjaKfS2PRULah/HANv8IPloOf0SvXxtAsOT ir9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yetUGqIq6nwDP/Z5XoMcv9Fbw9FD3H4M8DzhhGq80G4=; b=rO5OFwUgtFkFhIZ/xAR7HMHDUZLORF78y9drTUlNUIKMmP+YrpUW+B5KIuhthefIGE yLrpYR6+J/nICh2mCkh4nP5f90OG3KcM1BXN+7Um7Tnr626TSYCDFqjL32mvG36Wl8gS 4qnZ5FfNE4ONn4LMkQUIBKFE945xumM/K7oDQXG+JXoJAyUhO+2LABH3HHu9oNZcl6Ts 8GlRzu1V3wSL577VpWL+cQuZMDR5teZLioZDzJ/Aue+fO3ql5vm7HC6mKiMbk69lnd7i 80r4TBEwqtjk9kgBFhaMDc4SMvA0KJWS/gZtXwLEY7XgBPEcheEe1j0WNOK/FdVf/Pce ZWJA== X-Gm-Message-State: AOAM531RYWaVBgfNE02ESF0h5M0IX//K2yXiB5i0Yp3oTcQIJ9MP6ROf zMMPGP6zd7Tqv+vXcvcWO//6SQ== X-Google-Smtp-Source: ABdhPJx1VRpZysMio5HKg8II4nInDm6FtWRYuxHyTtXWeliAjY/fbVa0zm+yb9pGb1PBCIDixdfUIA== X-Received: by 2002:a17:90a:9918:: with SMTP id b24mr3155479pjp.108.1611290109187; Thu, 21 Jan 2021 20:35:09 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id o10sm7187231pfp.87.2021.01.21.20.35.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 20:35:08 -0800 (PST) Date: Fri, 22 Jan 2021 10:05:06 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices Message-ID: <20210122043506.lm6yiefzlyubq5my@vireshk-i7> References: <1585f6c21ea8aee64fe4da0bf72b36ea4d74a779.1611227342.git.viresh.kumar@linaro.org> <9b2638e6-b842-8737-e5a0-aeeb84927fce@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9b2638e6-b842-8737-e5a0-aeeb84927fce@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_233512_765969_F1DC5BB2 X-CRM114-Status: GOOD ( 18.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , Rafael Wysocki , linux-kernel@vger.kernel.org, Sibi Sankar , "linux-tegra@vger.kernel.org" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjEtMDEtMjEsIDIzOjI2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjEuMDEuMjAyMSAx NDoxNywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBJbiBvcmRlciB0byBhdm9pZCBjb25k aXRpb25hbCBzdGF0ZW1lbnRzIGF0IHRoZSBjYWxsZXIgc2l0ZSwgdGhpcyBwYXRjaAo+ID4gdXBk YXRlcyBfZ2VuZXJpY19zZXRfb3BwX2Nsa19vbmx5KCkgdG8gd29yayBmb3IgZGV2aWNlcyB0aGF0 IGRvbid0Cj4gPiBjaGFuZ2UgZnJlcXVlbmN5IChsaWtlIHBvd2VyIGRvbWFpbnMsIGV0Yy4pLiBS ZXR1cm4gMCBpZiB0aGUgY2xrIHBvaW50ZXIKPiA+IHBhc3NlZCB0byB0aGlzIHJvdXRpbmUgaXMg bm90IHZhbGlkLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBWaXJlc2ggS3VtYXIgPHZpcmVzaC5r dW1hckBsaW5hcm8ub3JnPgo+ID4gLS0tCj4gLi4uCj4gCj4gSGVsbG8gVmlyZXNoLAo+IAo+IFRo YW5rIHlvdSB2ZXJ5IG11Y2ggZm9yIHlvdXJzIGVmZm9ydCEgSSBnYXZlIGEgcXVpY2sgdGVzdCB0 byB0aGlzIHNlcmllcwo+IGFuZCBpbnN0YW50bHkgZm91bmQgb25lIHNtYWxsIGlzc3VlIGluIHRo aXMgcGF0Y2guCj4gCj4gPiArCS8qIFdlIG1heSByZWFjaCBoZXJlIGZvciBkZXZpY2VzIHdoaWNo IGRvbid0IGNoYW5nZSBmcmVxdWVuY3kgKi8KPiA+ICsJaWYgKHVubGlrZWx5KCFjbGspKQo+IAo+ IEkgcmVwbGFjZWQgZGV2X3BtX29wcF9zZXRfdm9sdGFnZSgpIHdpdGggZGV2X3BtX29wcF9zZXRf b3BwKCkgaW4gdGhlCj4gVGVncmEgUEQgZHJpdmVyIGFuZCBnb3QgYSBjcmFzaCwgd2hpY2ggaGFw cGVucyBiZWNhdXNlIHRoZSBhYm92ZSBsaW5lCj4gc2hvdWxkIGJlOgo+IAo+IAlpZiAoSVNfRVJS KGNsaykpCgpGaXhlZCwgdGhhbmtzLgoKLS0gCnZpcmVzaAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=