From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DEE1C433E0 for ; Fri, 22 Jan 2021 04:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E553E238EE for ; Fri, 22 Jan 2021 04:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726625AbhAVEqT (ORCPT ); Thu, 21 Jan 2021 23:46:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbhAVEqQ (ORCPT ); Thu, 21 Jan 2021 23:46:16 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5815EC06174A for ; Thu, 21 Jan 2021 20:45:36 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id s15so2522946plr.9 for ; Thu, 21 Jan 2021 20:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bbM2dKaYpv41IbTKFCnMXIDb9vPr8F5wpZdCakgIuw0=; b=uHQ/LNKv9Ii50fZb5s/RYG98hKXnhSwPVs+L5cPkfIj6K5CZebreMfP5nc4Gb/6QJ5 en/0A+D/wVkrU/v1I1mZ4ey4n9lTklU45zI9HBM+ZIxlO0gsG7kePmQj5M4dQt2+8mcS tdi5E804YOrjQzv9HV5b1auk/Vnnp4oxbpk5DFl1MEHdy0OGHxTArUDvzPPcMDID5Wql JDs6C5dsNRPyxQobVu8AspBDMQYCFaaMEIug/AVM2NjHzwlhxuX2RThA5DN5fB7Z56Hy hqdulwE2KMuLCX8fb9+42VUWneZI4v8PzuMnwbIsOjA5OMtxuZL29KrqU5stPKnzJNvq ustA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bbM2dKaYpv41IbTKFCnMXIDb9vPr8F5wpZdCakgIuw0=; b=kqf1btm7lNtC4qsm1fe9l/lfJ8EAK2SUrFhewJh6+2Y0HT7J6nHEnwZvTuUvtKqDlI 2uXWIIHJE0GGhq8nxrQzEYrwGxZQrpm044tRulwcvTGOdXWsZrugr4lkwxJnlaID2aup TR78+JPeke3fm/DlsIkIbTeQktWmNKPLds/IL3fyW/neSg6UsozZ9X8HHiSNJjpJw2rs VzHBMzIlIvlZDOv6cmjAuE8FT2u7cuBkaIrIOSD4a5dZ8XkxvO4bUUq85RX1H04u9sTI 2YNJa0xV+By4fR7h8Gp8n/l6XR8W7z5xk2L3/96klKUL/lhUN7uPkAAvWVTaUhcIP4ds aLFQ== X-Gm-Message-State: AOAM530aVdcuuR5ZZUnaFF/lR56DO0auxF2Ml7pO/MubtDSc7rn8shWw GiIza46A9i3AmSNAg5+BEvH86g== X-Google-Smtp-Source: ABdhPJykjY//oEpUUCa97mb5wm8LARwb1qXlD4yQTn+cDtixVvBIM0+Lr3O+f+FTqokTzkG4IHsSZg== X-Received: by 2002:a17:90a:4598:: with SMTP id v24mr3128802pjg.135.1611290735797; Thu, 21 Jan 2021 20:45:35 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id n128sm7428126pga.55.2021.01.21.20.45.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 20:45:34 -0800 (PST) Date: Fri, 22 Jan 2021 10:15:32 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 03/13] opp: Keep track of currently programmed OPP Message-ID: <20210122044532.pc7cpcgy3kjbqmls@vireshk-i7> References: <96b57316a2a307a5cc5ff7302b3cd0084123a2ed.1611227342.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-01-21, 00:41, Dmitry Osipenko wrote: > 21.01.2021 14:17, Viresh Kumar пишет: > > @@ -1074,15 +1091,18 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) > > > > if (!ret) { > > ret = _set_opp_bw(opp_table, opp, dev, false); > > - if (!ret) > > + if (!ret) { > > opp_table->enabled = true; > > + dev_pm_opp_put(old_opp); > > + > > + /* Make sure current_opp doesn't get freed */ > > + dev_pm_opp_get(opp); > > + opp_table->current_opp = opp; > > + } > > } > > I'm a bit surprised that _set_opp_bw() isn't used similarly to > _set_opp_voltage() in _generic_set_opp_regulator(). > > I'd expect the BW requirement to be raised before the clock rate goes UP. I remember discussing that earlier when this stuff came in, and this I believe is the reason for that. We need to scale regulators before/after frequency because when we increase the frequency a regulator may _not_ be providing enough power to sustain that (even for a short while) and this may have undesired effects on the hardware and so it is important to prevent that malfunction. In case of bandwidth such issues will not happen (AFAIK) and doing it just once is normally enough. It is just about allowing more data to be transmitted, and won't make the hardware behave badly. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC915C433E0 for ; Fri, 22 Jan 2021 04:47:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 616AA22211 for ; Fri, 22 Jan 2021 04:47:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 616AA22211 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iXpDejafYsaHChYpqqCZGbVIh3NkQVU2LrdQ9wmqxiI=; b=AEjDcIEDkQ00SEok/tXch7CbA c0GtWNZzWNGmIIZPsGdhIZgU3vrcmFlsPavp4f2UdTv4zeUiz07FNaoPkoha6fWd7A7KZ8jWkjQ9W N547nkAvavTHQRnnKkfTEDqlwozMeccVm8j0+pzcPdNV/TIlzo5BvG7bVqG63EzDcUyfxhO3fBrhb VuIn86hpXYIDeCxQz5E5/rIgnkUMl3LyKpK7zFuikhC7N32bagolRY76IPFN9oga1mZb1M5MP/url A3cLpHjD6ZFdG7jDKR/IYzlJmkHNunoAQbzqoYIabbjvrgAbOj7sLKxSm7O1LdjAfbZQ9mDJzGts5 Lo7B+xptg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2oKL-00009C-Jv; Fri, 22 Jan 2021 04:45:41 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2oKI-00008f-78 for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 04:45:39 +0000 Received: by mail-pl1-x629.google.com with SMTP id x18so2539154pln.6 for ; Thu, 21 Jan 2021 20:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bbM2dKaYpv41IbTKFCnMXIDb9vPr8F5wpZdCakgIuw0=; b=uHQ/LNKv9Ii50fZb5s/RYG98hKXnhSwPVs+L5cPkfIj6K5CZebreMfP5nc4Gb/6QJ5 en/0A+D/wVkrU/v1I1mZ4ey4n9lTklU45zI9HBM+ZIxlO0gsG7kePmQj5M4dQt2+8mcS tdi5E804YOrjQzv9HV5b1auk/Vnnp4oxbpk5DFl1MEHdy0OGHxTArUDvzPPcMDID5Wql JDs6C5dsNRPyxQobVu8AspBDMQYCFaaMEIug/AVM2NjHzwlhxuX2RThA5DN5fB7Z56Hy hqdulwE2KMuLCX8fb9+42VUWneZI4v8PzuMnwbIsOjA5OMtxuZL29KrqU5stPKnzJNvq ustA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bbM2dKaYpv41IbTKFCnMXIDb9vPr8F5wpZdCakgIuw0=; b=EqOcTcM9Djx6RDA+McSCIjewhRUUe2rAbxab+0w7YCGWuMPN2HUfXOmWbLjOxbypVz q+oMoe4BJMsK6cqAgI5wLDqU9hozrwmt8a08G4niKhj4wqgzbavp++n6iFt+86r6jUyY BPDLz3HSzMRBDw0yoLr75rMgZ0BvV+p6GZ1Pw/8LTo6dtgDVjEiwweDXKB6G9jgwYjA9 mZcxY9H6d9jHLBglAdHhKCIUtxey3fGZl/ttdgorqF6mKgKX6mIQqW2w/F8iQ/isjWq3 2tCZIqInFh+8X2p/67xmjUgwoeuBQ39eAerxwpA9hoL3E3QNPwosZPt3cpe3SR4FX0S9 f+IQ== X-Gm-Message-State: AOAM532AoJftePLFZRSU+l1LMDBhUpGqY2yTA0nlcqgQJbUh/m/r/koW 7aQvp/3dXwbhyrB2Lq4XiTOHAg== X-Google-Smtp-Source: ABdhPJykjY//oEpUUCa97mb5wm8LARwb1qXlD4yQTn+cDtixVvBIM0+Lr3O+f+FTqokTzkG4IHsSZg== X-Received: by 2002:a17:90a:4598:: with SMTP id v24mr3128802pjg.135.1611290735797; Thu, 21 Jan 2021 20:45:35 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id n128sm7428126pga.55.2021.01.21.20.45.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 20:45:34 -0800 (PST) Date: Fri, 22 Jan 2021 10:15:32 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH 03/13] opp: Keep track of currently programmed OPP Message-ID: <20210122044532.pc7cpcgy3kjbqmls@vireshk-i7> References: <96b57316a2a307a5cc5ff7302b3cd0084123a2ed.1611227342.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_234538_752933_F50B1F88 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , Rafael Wysocki , linux-kernel@vger.kernel.org, Sibi Sankar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjItMDEtMjEsIDAwOjQxLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjEuMDEuMjAyMSAx NDoxNywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBAQCAtMTA3NCwxNSArMTA5MSwxOCBA QCBpbnQgZGV2X3BtX29wcF9zZXRfcmF0ZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGxv bmcgdGFyZ2V0X2ZyZXEpCj4gPiAgCj4gPiAgCWlmICghcmV0KSB7Cj4gPiAgCQlyZXQgPSBfc2V0 X29wcF9idyhvcHBfdGFibGUsIG9wcCwgZGV2LCBmYWxzZSk7Cj4gPiAtCQlpZiAoIXJldCkKPiA+ ICsJCWlmICghcmV0KSB7Cj4gPiAgCQkJb3BwX3RhYmxlLT5lbmFibGVkID0gdHJ1ZTsKPiA+ICsJ CQlkZXZfcG1fb3BwX3B1dChvbGRfb3BwKTsKPiA+ICsKPiA+ICsJCQkvKiBNYWtlIHN1cmUgY3Vy cmVudF9vcHAgZG9lc24ndCBnZXQgZnJlZWQgKi8KPiA+ICsJCQlkZXZfcG1fb3BwX2dldChvcHAp Owo+ID4gKwkJCW9wcF90YWJsZS0+Y3VycmVudF9vcHAgPSBvcHA7Cj4gPiArCQl9Cj4gPiAgCX0K PiAKPiBJJ20gYSBiaXQgc3VycHJpc2VkIHRoYXQgX3NldF9vcHBfYncoKSBpc24ndCB1c2VkIHNp bWlsYXJseSB0bwo+IF9zZXRfb3BwX3ZvbHRhZ2UoKSBpbiBfZ2VuZXJpY19zZXRfb3BwX3JlZ3Vs YXRvcigpLgo+IAo+IEknZCBleHBlY3QgdGhlIEJXIHJlcXVpcmVtZW50IHRvIGJlIHJhaXNlZCBi ZWZvcmUgdGhlIGNsb2NrIHJhdGUgZ29lcyBVUC4KCkkgcmVtZW1iZXIgZGlzY3Vzc2luZyB0aGF0 IGVhcmxpZXIgd2hlbiB0aGlzIHN0dWZmIGNhbWUgaW4sIGFuZCB0aGlzIEkKYmVsaWV2ZSBpcyB0 aGUgcmVhc29uIGZvciB0aGF0LgoKV2UgbmVlZCB0byBzY2FsZSByZWd1bGF0b3JzIGJlZm9yZS9h ZnRlciBmcmVxdWVuY3kgYmVjYXVzZSB3aGVuIHdlCmluY3JlYXNlIHRoZSBmcmVxdWVuY3kgYSBy ZWd1bGF0b3IgbWF5IF9ub3RfIGJlIHByb3ZpZGluZyBlbm91Z2ggcG93ZXIKdG8gc3VzdGFpbiB0 aGF0IChldmVuIGZvciBhIHNob3J0IHdoaWxlKSBhbmQgdGhpcyBtYXkgaGF2ZSB1bmRlc2lyZWQK ZWZmZWN0cyBvbiB0aGUgaGFyZHdhcmUgYW5kIHNvIGl0IGlzIGltcG9ydGFudCB0byBwcmV2ZW50 IHRoYXQKbWFsZnVuY3Rpb24uCgpJbiBjYXNlIG9mIGJhbmR3aWR0aCBzdWNoIGlzc3VlcyB3aWxs IG5vdCBoYXBwZW4gKEFGQUlLKSBhbmQgZG9pbmcgaXQKanVzdCBvbmNlIGlzIG5vcm1hbGx5IGVu b3VnaC4gSXQgaXMganVzdCBhYm91dCBhbGxvd2luZyBtb3JlIGRhdGEgdG8KYmUgdHJhbnNtaXR0 ZWQsIGFuZCB3b24ndCBtYWtlIHRoZSBoYXJkd2FyZSBiZWhhdmUgYmFkbHkuCgotLSAKdmlyZXNo CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==