From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55493C433DB for ; Fri, 22 Jan 2021 06:29:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07BCA235FF for ; Fri, 22 Jan 2021 06:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbhAVG26 (ORCPT ); Fri, 22 Jan 2021 01:28:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbhAVG1n (ORCPT ); Fri, 22 Jan 2021 01:27:43 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CCAEC061756 for ; Thu, 21 Jan 2021 22:27:03 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id n10so3037357pgl.10 for ; Thu, 21 Jan 2021 22:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=svgrB85wDJvp1wFsJQnCVp+ank0Arsi8GO3FERYAPGc=; b=ux0UjAuQYmGVBrb8Ye8qm1tpjApuGIEbLNzDKfWG+sREKtOBhs9wc69kCk2XcGEVUh u4H3V16lDaQ13d/AsqE4nHLxmPe4u06EH1Ukvg1m+2aWKGTgxgUMmm0h9Dyvq3nJb8ZP wCFeHZ709a0RsxBpawIx7FvwlQZ8KLhnixCtMwH2xgNME8aSrvH+oC4TzP1Dr5/Q2t3Y N7tUbU7RSFbJcNRFLbM6VehvtjO8Sb5j3WRpjKSVSc63nhcKQUoNQNIRXe6oINWi8Mz6 tP5tfq11q/Tl8+KmTKFLM8pkvPvi50GMr6qKyC077jMTvm/URFFLSlHH/sqZHxmEpnqa qNmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=svgrB85wDJvp1wFsJQnCVp+ank0Arsi8GO3FERYAPGc=; b=g4Ayc11qK5zTWc9Q0epgWIuDlZ59Mjzz+pu6aauyzAXU7n6v9xBeYcgqL+y6+OSVIE WAbVO7onA2UCpDL2JY/eu2UOoj9D5r1y6DFT8c7L0QtpnhdgwO5biwKxdfv71fuVDzEq ty2R08HONCBTB/0dLE+lXaft+Epwc7Bm6/CcL2iTF7nXh1x1sRNwhFCQtmOg8yq7+h+y svgLZlq+FNKAVldH6qgZoKf/bxTIiFf1MFanh4L8pwCEb13ULGREr8Kx5s4wPVJ333Ew BP4LONWpdRt6z4PNjTKBSKLgBe/pZg98U0Uuox/Rsc1X+zJoupO6nZyeQVyCB2dJARam 1F6A== X-Gm-Message-State: AOAM5326Z9VDHxeiSdK70nV7/5rgVkjN2I3jIH/yXauLWzNVXn8k5/su SPEfbQw3Oj+D8/un9lsju4bxWA== X-Google-Smtp-Source: ABdhPJyYey8B/wZZECCKK/6z6M0ZdDm5dsyDljIPXQKsuXilPAqgZAz+8Uqbev9+vKmCz1YIcKVNQg== X-Received: by 2002:a17:90a:f2d2:: with SMTP id gt18mr3578692pjb.102.1611296822502; Thu, 21 Jan 2021 22:27:02 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id q2sm6678851pfj.32.2021.01.21.22.27.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 22:27:01 -0800 (PST) Date: Fri, 22 Jan 2021 11:56:59 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() Message-ID: <20210122062659.qss3hef4kltfgciu@vireshk-i7> References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 22-01-21, 00:36, Dmitry Osipenko wrote: > 21.01.2021 14:17, Viresh Kumar пишет: > > dev_pm_opp_set_bw() is getting removed and dev_pm_opp_set_opp() should > > be used instead. Migrate to the new API. > > > > Signed-off-by: Viresh Kumar > > --- > > drivers/devfreq/tegra30-devfreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > > index 117cad7968ab..d2477d7d1f66 100644 > > --- a/drivers/devfreq/tegra30-devfreq.c > > +++ b/drivers/devfreq/tegra30-devfreq.c > > @@ -647,7 +647,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, > > return PTR_ERR(opp); > > } > > > > - ret = dev_pm_opp_set_bw(dev, opp); > > + ret = dev_pm_opp_set_opp(dev, opp); > > dev_pm_opp_put(opp); > > > > return ret; > > > > This patch introduces a very serious change that needs to be fixed. > > Now dev_pm_opp_set_opp() changes both clock rate and bandwidth, this is > unacceptable for this driver because it shall not touch the clock rate. > > I think dev_pm_opp_set_bw() can't be removed. I am wondering here on what would be a better solution, do what you said or introduce another helper like dev_pm_opp_clear_clk(), which will make sure the OPP core doesn't play with device's clk. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD95EC433E0 for ; Fri, 22 Jan 2021 06:28:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 665DE208C7 for ; Fri, 22 Jan 2021 06:28:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 665DE208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zeyHLzRbm4WQEMLu+7w2FEk0qGgghiXgc3AN4LC1D5g=; b=U7BCjzaliGuvmCtqbzyITUVOh ChXzUrF3Wwfl5caT59KXbScIXX2DbeMPYnOJANsoorKZhPgUizBb0bqmrycKIkRINJzZRSK8e7yXx uBje3VW2tkeLGrHa2r8O/zZEf8rz5Nf5UAHAh6GFStXnk4hIEWtFnzfpICdrEAksGfOgM2ZxnoNPR SVAMxMZN7twRrnJb7KzjVCKP1wO5Z4j3U3CBbuClF/k6Fl5N/RPRFPcqAR4n81/eqhXF6G5IYXKPd f4lnnT4gu7R3MfTd2LvXDns18WO+Na+NBuVy8m01YxtkvOp5+GaSJ4+wDJetXuu8CdJX9LoOYDB86 ja4m76wYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2puV-0006Jm-L9; Fri, 22 Jan 2021 06:27:07 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2puT-0006J1-1Q for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 06:27:06 +0000 Received: by mail-pf1-x435.google.com with SMTP id o20so3087939pfu.0 for ; Thu, 21 Jan 2021 22:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=svgrB85wDJvp1wFsJQnCVp+ank0Arsi8GO3FERYAPGc=; b=ux0UjAuQYmGVBrb8Ye8qm1tpjApuGIEbLNzDKfWG+sREKtOBhs9wc69kCk2XcGEVUh u4H3V16lDaQ13d/AsqE4nHLxmPe4u06EH1Ukvg1m+2aWKGTgxgUMmm0h9Dyvq3nJb8ZP wCFeHZ709a0RsxBpawIx7FvwlQZ8KLhnixCtMwH2xgNME8aSrvH+oC4TzP1Dr5/Q2t3Y N7tUbU7RSFbJcNRFLbM6VehvtjO8Sb5j3WRpjKSVSc63nhcKQUoNQNIRXe6oINWi8Mz6 tP5tfq11q/Tl8+KmTKFLM8pkvPvi50GMr6qKyC077jMTvm/URFFLSlHH/sqZHxmEpnqa qNmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=svgrB85wDJvp1wFsJQnCVp+ank0Arsi8GO3FERYAPGc=; b=KXuSZ7UrvMyrww6jF0rBjbXeQD3YLFyyJzSmn08XkybiBNzM68qOz3GjTqdTZMP4bQ UFJoyYJo+aoRnWEaqlsPKZgbRigQikzFmlfIKcnCm8OO3AcEFz/5LK0wKoxDIVPUwn4g GTxN+UXwtXEm0ybsNGMZPQSUPCtxac3549F3B0syaACRFUdlL5ONJw0DgOvIiGXeNcbO 2azBv4sZZz7PzkIePoLVrPRqHSGmK9EQ0wgnmDlFcWOprEwaLH5Si0Uwg99a8pgeCirb BCFMEhIrkU2GTpYjLC7XTrZd+u5HtJjX9J3RgcSfGKNCDIol20Sj9YOeWkU+9Y0BlMNe wqzQ== X-Gm-Message-State: AOAM532WUNzeSg3iJy3JFx1ETYc323OHLChWr1GTo3pLYXaSe+EaQmF0 mJvyVBkZ1ct195BiKHJvh2ICrw== X-Google-Smtp-Source: ABdhPJyYey8B/wZZECCKK/6z6M0ZdDm5dsyDljIPXQKsuXilPAqgZAz+8Uqbev9+vKmCz1YIcKVNQg== X-Received: by 2002:a17:90a:f2d2:: with SMTP id gt18mr3578692pjb.102.1611296822502; Thu, 21 Jan 2021 22:27:02 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id q2sm6678851pfj.32.2021.01.21.22.27.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 22:27:01 -0800 (PST) Date: Fri, 22 Jan 2021 11:56:59 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() Message-ID: <20210122062659.qss3hef4kltfgciu@vireshk-i7> References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_012705_380385_409F500B X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Rafael Wysocki , linux-kernel@vger.kernel.org, Jonathan Hunter , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Thierry Reding , Sibi Sankar , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjItMDEtMjEsIDAwOjM2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMjEuMDEuMjAyMSAx NDoxNywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gPiBkZXZfcG1fb3BwX3NldF9idygpIGlz IGdldHRpbmcgcmVtb3ZlZCBhbmQgZGV2X3BtX29wcF9zZXRfb3BwKCkgc2hvdWxkCj4gPiBiZSB1 c2VkIGluc3RlYWQuIE1pZ3JhdGUgdG8gdGhlIG5ldyBBUEkuCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IFZpcmVzaCBLdW1hciA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMgfCAyICstCj4gPiAgMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMgYi9kcml2ZXJzL2RldmZyZXEvdGVncmEz MC1kZXZmcmVxLmMKPiA+IGluZGV4IDExN2NhZDc5NjhhYi4uZDI0NzdkN2QxZjY2IDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9kZXZmcmVxL3RlZ3JhMzAtZGV2ZnJlcS5jCj4gPiArKysgYi9kcml2 ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMKPiA+IEBAIC02NDcsNyArNjQ3LDcgQEAgc3Rh dGljIGludCB0ZWdyYV9kZXZmcmVxX3RhcmdldChzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVk IGxvbmcgKmZyZXEsCj4gPiAgCQlyZXR1cm4gUFRSX0VSUihvcHApOwo+ID4gIAl9Cj4gPiAgCj4g PiAtCXJldCA9IGRldl9wbV9vcHBfc2V0X2J3KGRldiwgb3BwKTsKPiA+ICsJcmV0ID0gZGV2X3Bt X29wcF9zZXRfb3BwKGRldiwgb3BwKTsKPiA+ICAJZGV2X3BtX29wcF9wdXQob3BwKTsKPiA+ICAK PiA+ICAJcmV0dXJuIHJldDsKPiA+IAo+IAo+IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBhIHZlcnkg c2VyaW91cyBjaGFuZ2UgdGhhdCBuZWVkcyB0byBiZSBmaXhlZC4KPiAKPiBOb3cgZGV2X3BtX29w cF9zZXRfb3BwKCkgY2hhbmdlcyBib3RoIGNsb2NrIHJhdGUgYW5kIGJhbmR3aWR0aCwgdGhpcyBp cwo+IHVuYWNjZXB0YWJsZSBmb3IgdGhpcyBkcml2ZXIgYmVjYXVzZSBpdCBzaGFsbCBub3QgdG91 Y2ggdGhlIGNsb2NrIHJhdGUuCj4gCj4gSSB0aGluayBkZXZfcG1fb3BwX3NldF9idygpIGNhbid0 IGJlIHJlbW92ZWQuCgpJIGFtIHdvbmRlcmluZyBoZXJlIG9uIHdoYXQgd291bGQgYmUgYSBiZXR0 ZXIgc29sdXRpb24sIGRvIHdoYXQgeW91CnNhaWQgb3IgaW50cm9kdWNlIGFub3RoZXIgaGVscGVy IGxpa2UgZGV2X3BtX29wcF9jbGVhcl9jbGsoKSwgd2hpY2gKd2lsbCBtYWtlIHN1cmUgdGhlIE9Q UCBjb3JlIGRvZXNuJ3QgcGxheSB3aXRoIGRldmljZSdzIGNsay4KCi0tIAp2aXJlc2gKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK