From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Su Yanjun <suyanjun218@gmail.com>
Cc: manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com,
wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap
Date: Fri, 22 Jan 2021 09:31:09 +0100 [thread overview]
Message-ID: <20210122083109.7gyxdwi2dlo3ptjj@hardanger.blackshift.org> (raw)
In-Reply-To: <20210122081334.213957-1-suyanjun218@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Fri, Jan 22, 2021 at 04:13:34PM +0800, Su Yanjun wrote:
> The sizeof(u32) is hardcoded. It's better to use the config value in
> regmap.
>
> It increases the size of target object, but it's flexible when new mcp chip
> need other val_bytes.
>
> Signed-off-by: Su Yanjun <suyanjun218@gmail.com>
Applied to linux-can-next/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-01-22 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:13 [PATCH v4] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap Su Yanjun
2021-01-22 8:31 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122083109.7gyxdwi2dlo3ptjj@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=suyanjun218@gmail.com \
--cc=thomas.kopp@microchip.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.