From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 678DEC433E0 for ; Fri, 22 Jan 2021 13:23:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3892E239D1 for ; Fri, 22 Jan 2021 13:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727882AbhAVNWk (ORCPT ); Fri, 22 Jan 2021 08:22:40 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:53341 "EHLO mail-wm1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727820AbhAVNW0 (ORCPT ); Fri, 22 Jan 2021 08:22:26 -0500 Received: by mail-wm1-f51.google.com with SMTP id j18so4296964wmi.3 for ; Fri, 22 Jan 2021 05:22:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e94xpvHI68qewB3epNIKMs2mX0bh71LFJru0+VzFv6E=; b=uJ/g5867KzO09Obpprkl1SNTrzbLsROhtwXCtYRE4nNcoxcbttlhtWKrN71RHV+qy9 Emdu4scmYQYXUAzxVFRxV+p1l7UZ5mcWs5kKKAxc+lDIgr8OOPCxuAKhNo9DGLlDfYXa HlGNEKlsKRcnkgF29vrH8VlyWU3bpzSkajAYWOpHtRupKWS12AOHR6lAUuXUWSBWdd8N Ppbo4jlfVvGjW2tqLaDxsoX2/nhP19p3iuJIie5gdEqCaXlI7xhY07Oodzqkqb/UY093 d5c28iPAg71CAOzzjLCVDTOT3ep6nQItpnvIyDGFVUjxgC1XZQq0zecLjHXikH6Uj8Z1 qdQw== X-Gm-Message-State: AOAM533vFZ3uMBWnzJ6VYteha6XkdTXHd45Vj0gwL/Fu9fyprFGjcghk jqn47S+qKfK9oLHUzpG3ds/QRbQ3xtY= X-Google-Smtp-Source: ABdhPJz3G+usrphZflUrpzU6OpgfYcInlZR8VWtTfm5wlnDAslStKxKPVKblJ437icGx1f5iTgLXLQ== X-Received: by 2002:a05:600c:214d:: with SMTP id v13mr4021568wml.186.1611321702432; Fri, 22 Jan 2021 05:21:42 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id l1sm4981111wrp.40.2021.01.22.05.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:21:41 -0800 (PST) Date: Fri, 22 Jan 2021 14:21:39 +0100 From: Krzysztof Kozlowski To: Linus Walleij Cc: Chanho Park , Tomasz Figa , Sylwester Nawrocki , Linux ARM , linux-samsung-soc Subject: Re: [PATCH] pinctrl: samsung: use raw_spinlock for locking Message-ID: <20210122132139.cowdrtjhdoicdsvv@kozik-lap> References: <20210121030009.25673-1-chanho61.park@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, Jan 22, 2021 at 02:15:18PM +0100, Linus Walleij wrote: > On Thu, Jan 21, 2021 at 4:00 AM Chanho Park wrote: > > > This patch converts spin_[lock|unlock] functions of pin bank to > > raw_spinlock to support preempt-rt. This can avoid BUG() assertion when > > irqchip callbacks are triggerred. Spinlocks can be converted rt_mutex > > which is preemptible when we apply preempt-rt patches. > > > > According to "Documentation/driver-api/gpio/driver.rst", > > > > "Realtime considerations: a realtime compliant GPIO driver should not > > use spinlock_t or any sleepable APIs (like PM runtime) as part of its > > irqchip implementation. > > > > - spinlock_t should be replaced with raw_spinlock_t.[1] > > " > > > > Cc: Tomasz Figa > > Cc: Krzysztof Kozlowski > > Cc: Sylwester Nawrocki > > Cc: Linus Walleij > > Signed-off-by: Chanho Park > > Looks correct to me. > Reviewed-by: Linus Walleij > > Krzysztof, will you collect Samsung patches for this merge window or > shall I apply it directly? I don't have anything in the queue so far and I don't see any patches incomming, so maybe take it directly? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF23C433DB for ; Fri, 22 Jan 2021 13:23:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33239235F7 for ; Fri, 22 Jan 2021 13:23:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33239235F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5B+IC7QWTiBfAxlVHZjlsFKgesjlHSzYckTpf+RB4Y4=; b=pRE2IL690j+Yoqn1SPoDsHSt8 dj1eAzk5OowbzJnG8jpCry1czGW2Ao66LA02MxZtEwYVDvyJKypVV6tVClNoYt3BUt2qDHzcssL7q jj40dSP/BqWIYuMm7l+IPt0otuQeVHPOD+e3cRQuyBdgBoLhn/P7miXB16g+CV+sycrlmavlkO2mY z8b3CGVemOSIFHNcFWDTEG4oi3s5s2UBXCCYdkVYt82ny+jV2/ONu+YHZ3ZvNuVzl5TaZfS/Edy84 WfPRXRAbvhNp5fUsnI0TvjQS5ZVAtqpmg7V5OKjoAoWu6k+vInlFgwoyECW9XSyESfpKv2cNdxK0R DbWOCbOAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2wNo-000438-RH; Fri, 22 Jan 2021 13:21:48 +0000 Received: from mail-wm1-f42.google.com ([209.85.128.42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2wNm-00041S-0T for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 13:21:47 +0000 Received: by mail-wm1-f42.google.com with SMTP id c124so4289933wma.5 for ; Fri, 22 Jan 2021 05:21:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e94xpvHI68qewB3epNIKMs2mX0bh71LFJru0+VzFv6E=; b=bjfwrW5DRhaqdMh+C5RRijW0VBuO9CIr87/CL40ExPxl5ZiJiP1V2Kn6HbBNA6+j8d 2BapwrOaaGKwtd+2tYjeBJvo7+gbPy96V21br7jMpDzYwnePGG5yKwte5pv+k34ubqi/ bWz7xBQVMqkiY+gXFvv/hZkRZaoF0SbySZ2/XY1+pj23r2FU0YMvRRanb82u+YEt1z48 7J+prRXD7KulBmBO/6aZy6av1ZJKVaQYc7jGKuClCgcJ/S6iT/BNg1UhzQwb1NJoOiXC zmTc4Lu6mdshdLCiTaRxPmP7kQ2DKYJq+AktHa9T77pcSzfcc/a6ppfz9v5vEPIb4cGQ +i+A== X-Gm-Message-State: AOAM533bNp9jCHoy5/l3Px8OWe7OP1pb6PClCq6ZWMNyneSIZK0kuup4 z1tyDnd3QoFS9CHx+4SBD6Q= X-Google-Smtp-Source: ABdhPJz3G+usrphZflUrpzU6OpgfYcInlZR8VWtTfm5wlnDAslStKxKPVKblJ437icGx1f5iTgLXLQ== X-Received: by 2002:a05:600c:214d:: with SMTP id v13mr4021568wml.186.1611321702432; Fri, 22 Jan 2021 05:21:42 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id l1sm4981111wrp.40.2021.01.22.05.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:21:41 -0800 (PST) Date: Fri, 22 Jan 2021 14:21:39 +0100 From: Krzysztof Kozlowski To: Linus Walleij Subject: Re: [PATCH] pinctrl: samsung: use raw_spinlock for locking Message-ID: <20210122132139.cowdrtjhdoicdsvv@kozik-lap> References: <20210121030009.25673-1-chanho61.park@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_082146_135621_47BFDC30 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Chanho Park , linux-samsung-soc , Tomasz Figa , Sylwester Nawrocki Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 22, 2021 at 02:15:18PM +0100, Linus Walleij wrote: > On Thu, Jan 21, 2021 at 4:00 AM Chanho Park wrote: > > > This patch converts spin_[lock|unlock] functions of pin bank to > > raw_spinlock to support preempt-rt. This can avoid BUG() assertion when > > irqchip callbacks are triggerred. Spinlocks can be converted rt_mutex > > which is preemptible when we apply preempt-rt patches. > > > > According to "Documentation/driver-api/gpio/driver.rst", > > > > "Realtime considerations: a realtime compliant GPIO driver should not > > use spinlock_t or any sleepable APIs (like PM runtime) as part of its > > irqchip implementation. > > > > - spinlock_t should be replaced with raw_spinlock_t.[1] > > " > > > > Cc: Tomasz Figa > > Cc: Krzysztof Kozlowski > > Cc: Sylwester Nawrocki > > Cc: Linus Walleij > > Signed-off-by: Chanho Park > > Looks correct to me. > Reviewed-by: Linus Walleij > > Krzysztof, will you collect Samsung patches for this merge window or > shall I apply it directly? I don't have anything in the queue so far and I don't see any patches incomming, so maybe take it directly? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel