From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DB2C433DB for ; Fri, 22 Jan 2021 14:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7664E239EF for ; Fri, 22 Jan 2021 14:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728713AbhAVOvz (ORCPT ); Fri, 22 Jan 2021 09:51:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:50892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728933AbhAVOun (ORCPT ); Fri, 22 Jan 2021 09:50:43 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 05765239EE; Fri, 22 Jan 2021 14:50:00 +0000 (UTC) Date: Fri, 22 Jan 2021 14:49:58 +0000 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Leon Romanovsky , Andrey Konovalov , Will Deacon , Mark Rutland , "Paul E . McKenney" , Naresh Kamboju Subject: Re: [PATCH v3 1/2] arm64: Improve kernel address detection of __is_lm_address() Message-ID: <20210122144958.GF8567@gaia> References: <20210122143748.50089-1-vincenzo.frascino@arm.com> <20210122143748.50089-2-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122143748.50089-2-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 02:37:47PM +0000, Vincenzo Frascino wrote: > Currently, the __is_lm_address() check just masks out the top 12 bits > of the address, but if they are 0, it still yields a true result. > This has as a side effect that virt_addr_valid() returns true even for > invalid virtual addresses (e.g. 0x0). > > Improve the detection checking that it's actually a kernel address > starting at PAGE_OFFSET. > > Cc: Catalin Marinas > Cc: Will Deacon > Suggested-by: Catalin Marinas > Signed-off-by: Vincenzo Frascino Reviewed-by: Catalin Marinas The question is whether we leave this for 5.12 or we merge it earlier. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2898BC433DB for ; Fri, 22 Jan 2021 14:51:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D235C239EE for ; Fri, 22 Jan 2021 14:51:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D235C239EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hKJ5Atc7gduY+RaXIjVfFCbxvJsh6Tcm31bn+cv90QA=; b=HZv1YF6plWf9A5hfMCXkWf1kX 5mzOfbb/8LiHE2FEm+8p9SAoZaxhcUN2AzDpzuxXXsmb7WI4bN1R8nMfO6SmXlR2zmHBKkQHmsZaS vz73ZMDIPPuNlsPFXuhLCLu+oqt8MJ6Wnwjdsmw/cjQ2ttMs9ZjiHZmCPIXvObCgqYN1VF9OVz/Pl GE5pWzSgfNzaXF2lreg1Vs8SbiDLv6rpAPV8eXLAzBGFKb3LfwLsFVnY8Ybwd8QCjc9QIf9n7mdFw h9P5ZvrDP48Ht8jUanF03NJIkD0U6261yneREmPXKmsLb1XhEKkNs4LA2kD6E6cN3X/QsALx5kke+ VtZNT5DrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2xlH-0002XW-82; Fri, 22 Jan 2021 14:50:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2xlE-0002X5-4m for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 14:50:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 05765239EE; Fri, 22 Jan 2021 14:50:00 +0000 (UTC) Date: Fri, 22 Jan 2021 14:49:58 +0000 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v3 1/2] arm64: Improve kernel address detection of __is_lm_address() Message-ID: <20210122144958.GF8567@gaia> References: <20210122143748.50089-1-vincenzo.frascino@arm.com> <20210122143748.50089-2-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210122143748.50089-2-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_095004_668419_F7232343 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "Paul E . McKenney" , Andrey Konovalov , Naresh Kamboju , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Leon Romanovsky , Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Andrey Ryabinin , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 22, 2021 at 02:37:47PM +0000, Vincenzo Frascino wrote: > Currently, the __is_lm_address() check just masks out the top 12 bits > of the address, but if they are 0, it still yields a true result. > This has as a side effect that virt_addr_valid() returns true even for > invalid virtual addresses (e.g. 0x0). > > Improve the detection checking that it's actually a kernel address > starting at PAGE_OFFSET. > > Cc: Catalin Marinas > Cc: Will Deacon > Suggested-by: Catalin Marinas > Signed-off-by: Vincenzo Frascino Reviewed-by: Catalin Marinas The question is whether we leave this for 5.12 or we merge it earlier. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel