From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kory Maincent Date: Fri, 22 Jan 2021 16:23:49 +0100 Subject: [PATCH] gpio-uclass: fix gpio flags save condition Message-ID: <20210122152349.26295-1-kory.maincent@bootlin.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character. This breaks the condition we expect to save the flags. Signed-off-by: Kory Maincent --- drivers/gpio/gpio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c index 0c01413b58..39db89c004 100644 --- a/drivers/gpio/gpio-uclass.c +++ b/drivers/gpio/gpio-uclass.c @@ -650,7 +650,7 @@ static int _dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags) } /* save the flags also in descriptor */ - if (!ret) + if (ret) desc->flags = flags; return ret; -- 2.17.1