All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikos Tsironis <ntsironis@arrikto.com>
To: snitzer@redhat.com, agk@redhat.com, dm-devel@redhat.com
Cc: ejt@redhat.com, ntsironis@arrikto.com
Subject: [dm-devel] [PATCH 3/4] dm era: Use correct value size in equality function of writeset tree
Date: Fri, 22 Jan 2021 17:25:55 +0200	[thread overview]
Message-ID: <20210122152556.24822-4-ntsironis@arrikto.com> (raw)
In-Reply-To: <20210122152556.24822-1-ntsironis@arrikto.com>

Fix the writeset tree equality test function to use the right value size
when comparing two btree values.

Fixes: eec40579d84873 ("dm: add era target")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Nikos Tsironis <ntsironis@arrikto.com>
---
 drivers/md/dm-era-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c
index ffbbd8740253..104fb110cd4e 100644
--- a/drivers/md/dm-era-target.c
+++ b/drivers/md/dm-era-target.c
@@ -389,7 +389,7 @@ static void ws_dec(void *context, const void *value)
 
 static int ws_eq(void *context, const void *value1, const void *value2)
 {
-	return !memcmp(value1, value2, sizeof(struct writeset_metadata));
+	return !memcmp(value1, value2, sizeof(struct writeset_disk));
 }
 
 /*----------------------------------------------------------------*/
-- 
2.11.0

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


  parent reply	other threads:[~2021-01-22 15:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:25 [dm-devel] [PATCH 0/4] dm era: Various minor fixes Nikos Tsironis
2021-01-22 15:25 ` [dm-devel] [PATCH 1/4] dm era: Verify the data block size hasn't changed Nikos Tsironis
2021-01-22 15:25 ` [dm-devel] [PATCH 2/4] dm era: Fix bitset memory leaks Nikos Tsironis
2021-01-22 15:25 ` Nikos Tsironis [this message]
2021-01-22 15:25 ` [dm-devel] [PATCH 4/4] dm era: Remove unreachable resize operation in pre-resume function Nikos Tsironis
2021-02-10 18:12   ` Mike Snitzer
2021-02-10 18:48     ` Mike Snitzer
2021-02-11 14:19       ` Nikos Tsironis
2021-02-10 17:56 ` [dm-devel] [PATCH 0/4] dm era: Various minor fixes Ming Hung Tsai
2021-02-10 18:34   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122152556.24822-4-ntsironis@arrikto.com \
    --to=ntsironis@arrikto.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=ejt@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.