From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA7C7C433E6 for ; Fri, 22 Jan 2021 15:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 656F2206A4 for ; Fri, 22 Jan 2021 15:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728695AbhAVPed (ORCPT ); Fri, 22 Jan 2021 10:34:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728769AbhAVPcc (ORCPT ); Fri, 22 Jan 2021 10:32:32 -0500 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49284C06174A; Fri, 22 Jan 2021 07:31:52 -0800 (PST) Received: by mail-oi1-x22b.google.com with SMTP id g69so5579880oib.12; Fri, 22 Jan 2021 07:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=WAI9EmxO3OdflrUnEgXpGM4CRb9QLdpplJPoTa7R+cY=; b=pGjPfkb55wKYX9mvuZTQi7AZBGV2QCOZFoXy9RzWdf2gyj/GW2FFSyQKljP4zXID50 v2uASSUdUkQ3mHimoXvFdWvpPvuufAaZoepwM90faKAf2dX6xAvmXcXhVTCyCBJEsL7n fV0HG3Oh5ostJFIr3RXkQtWzI8E5nAVY4IxpP3iM1RVH2hg5/O6Gpjtfmw2cPorbuGFN E7h/wA8FOlWPXOCrTxGwhOOuPJahWYyOJGEuoP8kp0Fn9T5pvoSnASh4NCCiStEONF/z +5M4sOmAEAlWE+9fEctq2pN8XoyuwM0nCvGXpPyi4oWe7qWOpyEyJatW2PPcWsPbc+VQ cmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=WAI9EmxO3OdflrUnEgXpGM4CRb9QLdpplJPoTa7R+cY=; b=GasVHfsa4Yo8zXAk/k09NKRgk9I+7HAm8eeXMckJgnZpHPqsPIRT9/r3R21+e21zVq nGmQe2GoxyE2qdRGkQjyu0s4cuiv51MQxv/eOVCFvbHqUzzta6Oei9vSBhBATOl8QdXb 3QGyOxwVRc0+shu5M2fDDg7mbtrFMag0CFPVDPuQBWz5NSIL96SKGseJz4VnTkW8Nf7O zgwWEyQK7Lv+ZAi54u3tAEARvBapFPcQOjMAhhXzdC9Ka+tQvoZSNjkDScU3GiGVtB7M obiBvyHGSS2dBvaRlGSUFQeRwsScalYErpWVkDCqvKv1YRM6y80bYhDuER3ovbHHK1Pe h3JQ== X-Gm-Message-State: AOAM5320MU7L5y0a5CgudKTcK0Mnld/RDzFzXEKJumiXYh3l73uV/S3M skw50X/hnmftkC9FuxUjUw== X-Google-Smtp-Source: ABdhPJz+ggRZGBXu3zz8mjszaqMjK+cra/M1UXcQnQ4rQ57Dsba4pFrBTo5xSMzW1dzsOTjtZu39OQ== X-Received: by 2002:aca:d417:: with SMTP id l23mr3595479oig.145.1611329511568; Fri, 22 Jan 2021 07:31:51 -0800 (PST) Received: from serve.minyard.net ([47.184.170.156]) by smtp.gmail.com with ESMTPSA id n82sm1014044oih.39.2021.01.22.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 07:31:50 -0800 (PST) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:ecb8:97e0:27ff:a134]) by serve.minyard.net (Postfix) with ESMTPSA id A45C7180042; Fri, 22 Jan 2021 15:31:49 +0000 (UTC) Date: Fri, 22 Jan 2021 09:31:48 -0600 From: Corey Minyard To: ChiaWei Wang Cc: Andrew Jeffery , Rob Herring , Lee Jones , Joel Stanley , Linus Walleij , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "openbmc@lists.ozlabs.org" , BMC-SW , Haiyue Wang , Cyril Bur , Robert Lippert Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout Message-ID: <20210122153148.GB1157510@minyard.net> Reply-To: minyard@acm.org References: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> <20210114131622.8951-4-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 09:55:56AM +0000, ChiaWei Wang wrote: > Hi Corey, > > Could you help to review this patch to kcs_bmc_aspeed.c? > It mainly fixes the register layout/offsets of Aspeed LPC controller. I am not really qualified to review this. It looks ok from a structural and style point of view, but that's all I can tell. So I'm ok with it. Acked-by: Corey Minyard > > Thanks, > Chiawei > > > -----Original Message----- > > From: Andrew Jeffery > > Sent: Wednesday, January 20, 2021 1:03 PM > > Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout > > > > > > > > On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > > > Add check against LPC device v2 compatible string to ensure that the > > > fixed device tree layout is adopted. > > > The LPC register offsets are also fixed accordingly. > > > > > > Signed-off-by: Chia-Wei, Wang > > > Acked-by: Haiyue Wang > > > > Reviewed-by: Andrew Jeffery > > Thanks for the review. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C53DC433DB for ; Fri, 22 Jan 2021 15:33:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7525F206A4 for ; Fri, 22 Jan 2021 15:33:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7525F206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DMjwF0bVZzDsQ6 for ; Sat, 23 Jan 2021 02:33:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::22b; helo=mail-oi1-x22b.google.com; envelope-from=tcminyard@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=pGjPfkb5; dkim-atps=neutral Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DMjt82MBjzDqHm; Sat, 23 Jan 2021 02:31:55 +1100 (AEDT) Received: by mail-oi1-x22b.google.com with SMTP id r189so6359513oih.4; Fri, 22 Jan 2021 07:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=WAI9EmxO3OdflrUnEgXpGM4CRb9QLdpplJPoTa7R+cY=; b=pGjPfkb55wKYX9mvuZTQi7AZBGV2QCOZFoXy9RzWdf2gyj/GW2FFSyQKljP4zXID50 v2uASSUdUkQ3mHimoXvFdWvpPvuufAaZoepwM90faKAf2dX6xAvmXcXhVTCyCBJEsL7n fV0HG3Oh5ostJFIr3RXkQtWzI8E5nAVY4IxpP3iM1RVH2hg5/O6Gpjtfmw2cPorbuGFN E7h/wA8FOlWPXOCrTxGwhOOuPJahWYyOJGEuoP8kp0Fn9T5pvoSnASh4NCCiStEONF/z +5M4sOmAEAlWE+9fEctq2pN8XoyuwM0nCvGXpPyi4oWe7qWOpyEyJatW2PPcWsPbc+VQ cmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=WAI9EmxO3OdflrUnEgXpGM4CRb9QLdpplJPoTa7R+cY=; b=gaUoXvAT7Qa0lul9s2ypv7TfGpxrzHZf9NA7N6/tBG+ac4EItp/sNh5/fecAFCA/Tc VZ+BfhjNUD9u03y1BPBVL9hpu+Rr8d897atIhZ+xoEeu5mNYwmfT0SpdNMX9W5IAiTAc q/AEKBE6524Zd9BOPazxIbqQNF5pOcbE/cItEynKyJI0V2n07fd1YsvASrIQlzbDo8gc te7ON/g8PpSiOAfTR0oeIr9cjAvtX8IeKde9yb5DM63Zc07LB06ElZTmF+6F+FTvVNmI 0iGgLt+Ct0KaOggkgVYq/zDu7LuDKUYvYYhWhBIj18+ZfrgMpv8z5X4U7BmxN7C7hcwl SmkQ== X-Gm-Message-State: AOAM533XwmcMszf9koob53ur3TV7vgtT+Ho1GNT++5MoYbvgJQeUQGVk I2eNrL2vzYZDgyFgT2ttog== X-Google-Smtp-Source: ABdhPJz+ggRZGBXu3zz8mjszaqMjK+cra/M1UXcQnQ4rQ57Dsba4pFrBTo5xSMzW1dzsOTjtZu39OQ== X-Received: by 2002:aca:d417:: with SMTP id l23mr3595479oig.145.1611329511568; Fri, 22 Jan 2021 07:31:51 -0800 (PST) Received: from serve.minyard.net ([47.184.170.156]) by smtp.gmail.com with ESMTPSA id n82sm1014044oih.39.2021.01.22.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 07:31:50 -0800 (PST) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:ecb8:97e0:27ff:a134]) by serve.minyard.net (Postfix) with ESMTPSA id A45C7180042; Fri, 22 Jan 2021 15:31:49 +0000 (UTC) Date: Fri, 22 Jan 2021 09:31:48 -0600 From: Corey Minyard To: ChiaWei Wang Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout Message-ID: <20210122153148.GB1157510@minyard.net> References: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> <20210114131622.8951-4-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: "devicetree@vger.kernel.org" , Haiyue Wang , "linux-aspeed@lists.ozlabs.org" , BMC-SW , Andrew Jeffery , Linus Walleij , "linux-kernel@vger.kernel.org" , Cyril Bur , Rob Herring , Lee Jones , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, Jan 22, 2021 at 09:55:56AM +0000, ChiaWei Wang wrote: > Hi Corey, > > Could you help to review this patch to kcs_bmc_aspeed.c? > It mainly fixes the register layout/offsets of Aspeed LPC controller. I am not really qualified to review this. It looks ok from a structural and style point of view, but that's all I can tell. So I'm ok with it. Acked-by: Corey Minyard > > Thanks, > Chiawei > > > -----Original Message----- > > From: Andrew Jeffery > > Sent: Wednesday, January 20, 2021 1:03 PM > > Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout > > > > > > > > On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > > > Add check against LPC device v2 compatible string to ensure that the > > > fixed device tree layout is adopted. > > > The LPC register offsets are also fixed accordingly. > > > > > > Signed-off-by: Chia-Wei, Wang > > > Acked-by: Haiyue Wang > > > > Reviewed-by: Andrew Jeffery > > Thanks for the review. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55653C433E0 for ; Fri, 22 Jan 2021 15:33:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFAD4206A4 for ; Fri, 22 Jan 2021 15:33:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFAD4206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/yhNoL+JPKgnNEgfSbGoHveIgmhdGce1+B/DwMjKtG0=; b=J+7l3rxH1OTY2X0jmnKjNgmxCu frCFNOh13+ASZbuVdbkPRDaETSO2BlnjcwzBuWR2KQbNoX1tmHTEaLfLVfHtRNgonvaLg78AGEX/h P08P7cu1S4AxyuMqTLCAsxDjKPSK9QG+V/VJ2RtPJ7JSoD9UZRjWxG2gc10qcx1MkuyglR2ei+J19 sTHcDjyMmPXQWE5+kQVYXnu1M6NgsnldhW5Bv7xl2KqQ4H0Tk3sWr7rNNaMqD7GYFYsY2E6xjEnKb zWN5Bvg8RANn6YUA/huwlfGtdrpmmVPDYbAKJrYL/PRmkG6kYAfmUQspFhErjmePGsNPAySWywpmy uNSXGTOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2yPo-0003ZY-Jt; Fri, 22 Jan 2021 15:32:00 +0000 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2yPj-0003Wz-I8 for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 15:31:56 +0000 Received: by mail-oi1-x230.google.com with SMTP id 15so6349202oix.8 for ; Fri, 22 Jan 2021 07:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=WAI9EmxO3OdflrUnEgXpGM4CRb9QLdpplJPoTa7R+cY=; b=pGjPfkb55wKYX9mvuZTQi7AZBGV2QCOZFoXy9RzWdf2gyj/GW2FFSyQKljP4zXID50 v2uASSUdUkQ3mHimoXvFdWvpPvuufAaZoepwM90faKAf2dX6xAvmXcXhVTCyCBJEsL7n fV0HG3Oh5ostJFIr3RXkQtWzI8E5nAVY4IxpP3iM1RVH2hg5/O6Gpjtfmw2cPorbuGFN E7h/wA8FOlWPXOCrTxGwhOOuPJahWYyOJGEuoP8kp0Fn9T5pvoSnASh4NCCiStEONF/z +5M4sOmAEAlWE+9fEctq2pN8XoyuwM0nCvGXpPyi4oWe7qWOpyEyJatW2PPcWsPbc+VQ cmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=WAI9EmxO3OdflrUnEgXpGM4CRb9QLdpplJPoTa7R+cY=; b=qaU26R6my7PEZ6qEhLjsbiPln6dV02qoNuWd52pB8uuhwCq2hHs8RTJ3VdeFAGjsoi GSWLmqiK6/mfA80E07VGdXQinth6tWEDNKVqnzbYR+9MUcje180FtsCkCXhHWpIW7/QV p04BHXmagPm0vjU5y51OmMuGc0kycE7pGxO8f/4g2Cv+AbN/xbAuiEnYPEfUbGd1jNeK NFlQ6wZ4/pMwbyKJvSso4BtvHt5SU8wqAZ18k+wofIKKo03oEzMRFNZpIiz4s1DaFMV0 zrnYFXBSd9N0IEK+FZVl6USdorG7LpTOxc2BOE1LdqdQGndQ2mFXmX9mwQeiZ7HWAliS x3ZQ== X-Gm-Message-State: AOAM53184FlzHVtG6A8dMgmI9YPDk60xdTeTos0/MfUsOnk61SWzw9/I xsG67XXD3Kh2nKZQWM0omQ== X-Google-Smtp-Source: ABdhPJz+ggRZGBXu3zz8mjszaqMjK+cra/M1UXcQnQ4rQ57Dsba4pFrBTo5xSMzW1dzsOTjtZu39OQ== X-Received: by 2002:aca:d417:: with SMTP id l23mr3595479oig.145.1611329511568; Fri, 22 Jan 2021 07:31:51 -0800 (PST) Received: from serve.minyard.net ([47.184.170.156]) by smtp.gmail.com with ESMTPSA id n82sm1014044oih.39.2021.01.22.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 07:31:50 -0800 (PST) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:ecb8:97e0:27ff:a134]) by serve.minyard.net (Postfix) with ESMTPSA id A45C7180042; Fri, 22 Jan 2021 15:31:49 +0000 (UTC) Date: Fri, 22 Jan 2021 09:31:48 -0600 From: Corey Minyard To: ChiaWei Wang Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout Message-ID: <20210122153148.GB1157510@minyard.net> References: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> <20210114131622.8951-4-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_103155_607214_F77FE9D8 X-CRM114-Status: GOOD ( 17.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: "devicetree@vger.kernel.org" , Haiyue Wang , "linux-aspeed@lists.ozlabs.org" , BMC-SW , Andrew Jeffery , Linus Walleij , "linux-kernel@vger.kernel.org" , Cyril Bur , Robert Lippert , Rob Herring , Joel Stanley , Lee Jones , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 22, 2021 at 09:55:56AM +0000, ChiaWei Wang wrote: > Hi Corey, > > Could you help to review this patch to kcs_bmc_aspeed.c? > It mainly fixes the register layout/offsets of Aspeed LPC controller. I am not really qualified to review this. It looks ok from a structural and style point of view, but that's all I can tell. So I'm ok with it. Acked-by: Corey Minyard > > Thanks, > Chiawei > > > -----Original Message----- > > From: Andrew Jeffery > > Sent: Wednesday, January 20, 2021 1:03 PM > > Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout > > > > > > > > On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > > > Add check against LPC device v2 compatible string to ensure that the > > > fixed device tree layout is adopted. > > > The LPC register offsets are also fixed accordingly. > > > > > > Signed-off-by: Chia-Wei, Wang > > > Acked-by: Haiyue Wang > > > > Reviewed-by: Andrew Jeffery > > Thanks for the review. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel