From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D269C433DB for ; Fri, 22 Jan 2021 15:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 286C823AA1 for ; Fri, 22 Jan 2021 15:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728994AbhAVPfT (ORCPT ); Fri, 22 Jan 2021 10:35:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729188AbhAVPdR (ORCPT ); Fri, 22 Jan 2021 10:33:17 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5BA3C061788 for ; Fri, 22 Jan 2021 07:32:36 -0800 (PST) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2yQK-0006rl-F9; Fri, 22 Jan 2021 16:32:32 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1l2yQJ-00007J-9C; Fri, 22 Jan 2021 16:32:31 +0100 Date: Fri, 22 Jan 2021 16:32:31 +0100 From: Marco Felsch To: Alistair Francis Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, alistair23@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] arch/arm: reMarkable2: Enable wacom_i2c Message-ID: <20210122153231.qqiuwltvzzg52phg@pengutronix.de> References: <20210121065643.342-1-alistair@alistair23.me> <20210121065643.342-7-alistair@alistair23.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121065643.342-7-alistair@alistair23.me> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 16:15:16 up 51 days, 5:21, 28 users, load average: 0.33, 0.24, 0.11 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, thanks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Enable the wacom_i2c touchscreen for the reMarkable2. > > Signed-off-by: Alistair Francis > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 41 +++++++++++++++++++++++++ > arch/arm/configs/imx_v6_v7_defconfig | 1 + Those two changes should be splitted and the dts patch should be named: "ARM: dts: imx7d: remarkable2: add wacom digitizer device". > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index fba55a0e028a..8052d884a5e5 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -150,6 +150,30 @@ &dma_apbh { > status = "disabled"; > }; > > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_i2c1>; > + pinctrl-1 = <&pinctrl_i2c1>; No need to specify the sleep state if both are using the same pinctrl config. > + status = "okay"; > + > + digitizer: wacom-i2c@9 { this should be: wacom_digitizer: digitizer@9 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_wacom>; > + pinctrl-1 = <&pinctrl_wacom>; Same here, sleep and default refer to the same state. > + compatible = "wacom,wacom-i2c"; > + reg = <0x09>; compatible and reg are always the first to properties. > + interrupt-parent = <&gpio1>; > + interrupts = <1 2>; Please use defines. > + flip-tilt-x; > + flip-tilt-y; > + flip-pos-x; > + flip-pos-y; > + flip-distance; > + vdd-supply = <®_digitizer>; Where is this regulator added? > + }; > +}; > + > &sdma { > status = "okay"; > }; > @@ -221,6 +245,16 @@ &wdog1 { > }; > > &iomuxc_lpsr { > + pinctrl_wacom: wacomgrp { > + fsl,pins = < > + /*MX7D_PAD_LPSR_GPIO1_IO00__GPIO1_IO0 0x00000074 /* WACOM RESET */ > + MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x00000034 /* WACOM INT */ > + MX7D_PAD_LPSR_GPIO1_IO04__GPIO1_IO4 0x00000074 /* PDCTB */ > + /*MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x00000014 /* FWE */ > + /*MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x00000014 /* WACOM PWR ENABLE */ > + >; > + }; Pls, sort this alphabetical. > + > pinctrl_digitizer_reg: digitizerreggrp { > fsl,pins = < > /* DIGITIZER_PWR_EN */ > @@ -236,6 +270,13 @@ MX7D_PAD_SAI1_RX_SYNC__GPIO6_IO16 0x59 > >; > }; > > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > + MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index fa9229616106..2fc8dc6a8b0a 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -167,6 +167,7 @@ CONFIG_TOUCHSCREEN_DA9052=y > CONFIG_TOUCHSCREEN_EGALAX=y > CONFIG_TOUCHSCREEN_GOODIX=y > CONFIG_TOUCHSCREEN_ILI210X=y > +CONFIG_TOUCHSCREEN_WACOM_I2C=y > CONFIG_TOUCHSCREEN_MAX11801=y > CONFIG_TOUCHSCREEN_IMX6UL_TSC=y > CONFIG_TOUCHSCREEN_EDT_FT5X06=y > -- > 2.29.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |