From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2AF2C433DB for ; Fri, 22 Jan 2021 19:55:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 828C523AF8 for ; Fri, 22 Jan 2021 19:55:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 828C523AF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=lmichel.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l32Wm-0007Nd-JO for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 14:55:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l32U6-000670-Dj; Fri, 22 Jan 2021 14:52:42 -0500 Received: from pharaoh.lmichel.fr ([149.202.28.74]:49658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l32Ty-0005T9-4Y; Fri, 22 Jan 2021 14:52:42 -0500 Received: from localhost (sekoia-pc.home.lmichel.fr [192.168.61.100]) by pharaoh.lmichel.fr (Postfix) with ESMTPSA id 1D6BDC602E6; Fri, 22 Jan 2021 20:52:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lmichel.fr; s=pharaoh; t=1611345151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XOypW6orXQcKL1DdZ6guwBXdmIKbtJmsHqcnKk03GLg=; b=LfPQBSc8HLx2/MQSAQa3BWMJn9Ye9goxsabsRmI44zDh2dvj3ZExzqREfxSxTsCKyYaezY atf5P5ZHwTDSn7o8iaO+RQNeroJEJMQqwILFY/mLTC40q2W6VsjIY30eh+TEbyLMTR3pSc 08d1tTsx6gC7F9lamT8W59boLs1xN4A7q1R2t3h2PaRY+6sF8nHs94p5Q3P3A0fXPLmZsB y7h0mQek8ZeUmf8nulVv2iC4REEDQ/91InAk3ZDDRgmVLuTv+TEscJFhN22xlygYEmtRrY YkgHGeWtNmG++XC4BSgOlDqp5/KU6+LmeVP0pufdXiVB9JQWOj8zk9ux6Gx6VQ== Date: Fri, 22 Jan 2021 20:52:52 +0100 From: Luc Michel To: Peter Maydell Subject: Re: [PATCH 14/25] hw/arm/mps2-tz: Create and connect ARMSSE Clocks Message-ID: <20210122195252.vq6jmtdqkqgv53jt@sekoia-pc.home.lmichel.fr> References: <20210121190622.22000-1-peter.maydell@linaro.org> <20210121190622.22000-15-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121190622.22000-15-peter.maydell@linaro.org> Received-SPF: pass client-ip=149.202.28.74; envelope-from=luc@lmichel.fr; helo=pharaoh.lmichel.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 19:06 Thu 21 Jan , Peter Maydell wrote: > Create and connect the two clocks needed by the ARMSSE. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/arm/mps2-tz.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c > index 6a9eed9022a..7acdf490f28 100644 > --- a/hw/arm/mps2-tz.c > +++ b/hw/arm/mps2-tz.c > @@ -62,6 +62,7 @@ > #include "hw/net/lan9118.h" > #include "net/net.h" > #include "hw/core/split-irq.h" > +#include "hw/qdev-clock.h" > #include "qom/object.h" > > #define MPS2TZ_NUMIRQ 92 > @@ -100,6 +101,8 @@ struct MPS2TZMachineState { > qemu_or_irq uart_irq_orgate; > DeviceState *lan9118; > SplitIRQ cpu_irq_splitter[MPS2TZ_NUMIRQ]; > + Clock *sysclk; > + Clock *s32kclk; > }; > > #define TYPE_MPS2TZ_MACHINE "mps2tz" > @@ -110,6 +113,8 @@ OBJECT_DECLARE_TYPE(MPS2TZMachineState, MPS2TZMachineClass, MPS2TZ_MACHINE) > > /* Main SYSCLK frequency in Hz */ > #define SYSCLK_FRQ 20000000 > +/* Slow 32Khz S32KCLK frequency in Hz */ > +#define S32KCLK_FRQ (32 * 1000) > > /* Create an alias of an entire original MemoryRegion @orig > * located at @base in the memory map. > @@ -396,6 +401,12 @@ static void mps2tz_common_init(MachineState *machine) > exit(EXIT_FAILURE); > } > > + /* These clocks don't need migration because they are fixed-frequency */ > + mms->sysclk = clock_new(OBJECT(machine), "SYSCLK"); > + clock_set_hz(mms->sysclk, SYSCLK_FRQ); > + mms->s32kclk = clock_new(OBJECT(machine), "S32KCLK"); > + clock_set_hz(mms->s32kclk, S32KCLK_FRQ); > + > object_initialize_child(OBJECT(machine), TYPE_IOTKIT, &mms->iotkit, > mmc->armsse_type); > iotkitdev = DEVICE(&mms->iotkit); > @@ -403,6 +414,8 @@ static void mps2tz_common_init(MachineState *machine) > OBJECT(system_memory), &error_abort); > qdev_prop_set_uint32(iotkitdev, "EXP_NUMIRQ", MPS2TZ_NUMIRQ); > qdev_prop_set_uint32(iotkitdev, "MAINCLK_FRQ", SYSCLK_FRQ); > + qdev_connect_clock_in(iotkitdev, "MAINCLK", mms->sysclk); > + qdev_connect_clock_in(iotkitdev, "S32KCLK", mms->s32kclk); > sysbus_realize(SYS_BUS_DEVICE(&mms->iotkit), &error_fatal); > > /* > -- > 2.20.1 > --