From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F70C433E0 for ; Sat, 23 Jan 2021 09:38:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69C14233FA for ; Sat, 23 Jan 2021 09:38:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69C14233FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E8A66EA9C; Sat, 23 Jan 2021 09:38:19 +0000 (UTC) Received: from xanadu.blop.info (xanadu.blop.info [178.79.145.134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70F7D6E064 for ; Sat, 23 Jan 2021 08:06:07 +0000 (UTC) Received: from [127.0.0.1] (helo=xanadu.blop.info) by xanadu.blop.info with smtp (Exim 4.89) (envelope-from ) id 1l3Dvn-0005xT-T6; Sat, 23 Jan 2021 09:06:03 +0100 Received: (nullmailer pid 5746 invoked by uid 1000); Sat, 23 Jan 2021 08:05:48 -0000 Date: Sat, 23 Jan 2021 09:05:48 +0100 From: Lucas Nussbaum To: Maxime Ripard Subject: Re: [PATCH 2/2] drm/vc4: Correct POS1_SCL for hvs5 Message-ID: <20210123080548.GA5452@xanadu.blop.info> References: <20210121105759.1262699-1-maxime@cerno.tech> <20210121105759.1262699-2-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: <20210121105759.1262699-2-maxime@cerno.tech> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Sat, 23 Jan 2021 09:38:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Ryutaroh Matsumoto , dri-devel@lists.freedesktop.org, Dave Stevenson Content-Type: multipart/mixed; boundary="===============1079239411==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1079239411== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21/01/21 at 11:57 +0100, Maxime Ripard wrote: > From: Dom Cobley >=20 > Fixes failure with 4096x1080 resolutions >=20 > [ 284.315379] WARNING: CPU: 1 PID: 901 at drivers/gpu/drm/vc4/vc4_plane.= c:981 vc4_plane_mode_set+0x1374/0x13c4 > [ 284.315385] Modules linked in: ir_rc5_decoder rpivid_hevc(C) bcm2835_c= odec(C) bcm2835_isp(C) bcm2835_mmal_vchiq(C) bcm2835_gpiomem v4l2_mem2mem v= ideobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common videod= ev mc cdc_acm xpad ir_rc6_decoder rc_rc6_mce gpio_ir_recv fuse > [ 284.315509] CPU: 1 PID: 901 Comm: kodi.bin Tainted: G C = 5.10.7 #1 > [ 284.315514] Hardware name: BCM2711 > [ 284.315518] Backtrace: > [ 284.315533] [] (dump_backtrace) from [] (show_stac= k+0x20/0x24) > [ 284.315540] r7:ffffffff r6:00000000 r5:68000013 r4:c18ecf1c > [ 284.315549] [] (show_stack) from [] (dump_stack+0x= c4/0xf0) > [ 284.315558] [] (dump_stack) from [] (__warn+0xfc/0= x158) > [ 284.315564] r9:00000000 r8:00000009 r7:000003d5 r6:00000009 r5:c08cc7= dc r4:c0fd09b8 > [ 284.315572] [] (__warn) from [] (warn_slowpath_fmt= +0x74/0xe4) > [ 284.315577] r7:c08cc7dc r6:000003d5 r5:c0fd09b8 r4:00000000 > [ 284.315584] [] (warn_slowpath_fmt) from [] (vc4_pl= ane_mode_set+0x1374/0x13c4) > [ 284.315589] r8:00000000 r7:00000000 r6:00001000 r5:c404c600 r4:c2e346= 00 > [ 284.315596] [] (vc4_plane_mode_set) from [] (vc4_p= lane_atomic_check+0x40/0x1c0) > [ 284.315601] r10:00000001 r9:c2e34600 r8:c0e67068 r7:c0fc44e0 r6:c2ce3= 640 r5:c3d636c0 > [ 284.315605] r4:c2e34600 > [ 284.315614] [] (vc4_plane_atomic_check) from [] (d= rm_atomic_helper_check_planes+0xec/0x1ec) > [ 284.315620] r9:c2e34600 r8:c0e67068 r7:c0fc44e0 r6:c2ce3640 r5:c3d636= c0 r4:00000006 > [ 284.315627] [] (drm_atomic_helper_check_planes) from [] (drm_atomic_helper_check+0x54/0x9c) > [ 284.315633] r9:c2e35400 r8:00000006 r7:00000000 r6:c2ba7800 r5:c3d636= c0 r4:00000000 > [ 284.315641] [] (drm_atomic_helper_check) from [] (= vc4_atomic_check+0x25c/0x454) > [ 284.315645] r7:00000000 r6:c2ba7800 r5:00000001 r4:c3d636c0 > [ 284.315652] [] (vc4_atomic_check) from [] (drm_ato= mic_check_only+0x5cc/0x7e0) > [ 284.315658] r10:c404c6c8 r9:ffffffff r8:c472c480 r7:00000003 r6:c3d63= 6c0 r5:00000000 > [ 284.315662] r4:0000003c r3:c08b7a4c > [ 284.315670] [] (drm_atomic_check_only) from [] (dr= m_mode_atomic_ioctl+0x758/0xa7c) > [ 284.315675] r10:c3d46000 r9:c3d636c0 r8:c2ce8a70 r7:027e3a54 r6:00000= 043 r5:c1fbb800 > [ 284.315679] r4:0281a858 > [ 284.315688] [] (drm_mode_atomic_ioctl) from [] (dr= m_ioctl_kernel+0xc4/0x108) > [ 284.315693] r10:c03864bc r9:c1fbb800 r8:c3d47e64 r7:c089b308 r6:00000= 002 r5:c2ba7800 > [ 284.315697] r4:00000000 > [ 284.315705] [] (drm_ioctl_kernel) from [] (drm_ioc= tl+0x1e8/0x3a0) > [ 284.315711] r9:c1fbb800 r8:000000bc r7:c3d47e64 r6:00000038 r5:c0e595= 70 r4:00000038 > [ 284.315719] [] (drm_ioctl) from [] (sys_ioctl+0x35= c/0x914) > [ 284.315724] r10:c2d08200 r9:00000000 r8:c36fa300 r7:befdd870 r6:c0386= 4bc r5:c36fa301 > [ 284.315728] r4:c03864bc > [ 284.315735] [] (sys_ioctl) from [] (ret_fast_sysca= ll+0x0/0x28) > [ 284.315739] Exception stack(0xc3d47fa8 to 0xc3d47ff0) > [ 284.315745] 7fa0: 027eb750 befdd870 00000000 c03864b= c befdd870 00000000 > [ 284.315750] 7fc0: 027eb750 befdd870 c03864bc 00000036 027e3948 0281a64= 0 0281a850 027e3a50 > [ 284.315756] 7fe0: b4b64100 befdd844 b4b5ba2c b49c994c > [ 284.315762] r10:00000036 r9:c3d46000 r8:c0200204 r7:00000036 r6:c0386= 4bc r5:befdd870 > [ 284.315765] r4:027eb750 >=20 > Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5") > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard Tested-By: Lucas Nussbaum - Lucas --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE/t7ByzN7z1CfQ8IkORS1MvTfvpkFAmAL2NwACgkQORS1MvTf vpmlJQ//YSw0b8K3qpaz1eYxSuOyjlywod1riJvEMKQRnUe5gsxonIAqb7K9m5uu 8g2shurHKhF1rbo25/FHtDCBL0fpx1HvPNcW2Q3m/TT6q44j2R84bbiTTC2Hnvvf aAwQ8v6fyzITKmkn3ccvaHQP21aFksdvkUGkfyMbS7Z96wPDdd0ceBAtsAnsSuhM GC3KoRq3vIE2y31mjTy1NDiyqFzz50JfPuaca4bkpLdD628pvQ1vDLRez/DyYjSk 91yto4uFBsxGp7uKE0fmjqe+uGBw0syc14Sbz+fQ+EqV42AG/T3ewrI8v0IYbtnd TrKmLdOWt4xH4DpWlWHuURpys6H7T0l0rwjQjHeOOWYZoslTNwfzM1lOZ5rTKztP s5iZZacNT6ZGQMrzphNcJM2JX95YtV/LTlrJPcSuiO23UrTQc+FblzpT9DaSvmjD aDPwuKFV0qVxoWDiG/cbIfwhx4tJRhiQbg7qIGqM2+4h61p8Sjb9rQ72r6EGXWh0 IB5N0Jd7vNUGvhare7V93nAsXPlEn3BApQRYmzaqgTyBS50JHihlDNhssuYZxd41 pe1CbhyITc1i/cMS4tfnzQZE0JERCffMt+Rrnj59bgA3KR4s5OaZ90JTe+wbkbEh 3OOVESnxClFjhnmM2qm/UmMoh4DUj/4VZq9NqNumyZrPjkSL0xY= =mvNS -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6-- --===============1079239411== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1079239411==--