[PATCH net 0/4] Remove unneeded PHY time stamping option.

[PATCH net 0/4] Remove unneeded PHY time stamping option.

[Richard Cochran]

The NETWORK_PHY_TIMESTAMPING configuration option adds additional
checks into the networking hot path, and it is only needed by two
rather esoteric devices, namely the TI DP83640 PHYTER and the ZHAW
InES 1588 IP core.  Very few end users have these devices, and those
that do have them are building specialized embedded systems.

Unfortunately two unrelated drivers depend on this option, and two
defconfigs enable it.  It is probably my fault for not paying enough
attention in reviews.

This series corrects the gratuitous use of NETWORK_PHY_TIMESTAMPING.


Richard Cochran (4):
  net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.
  net: mvpp2: Remove unneeded Kconfig dependency.
  ARM: socfpga_defconfig: Disable PHY time stamping by default.
  ARM: axm55xx_defconfig: Disable PHY time stamping by default.

 arch/arm/configs/axm55xx_defconfig   | 1 -
 arch/arm/configs/socfpga_defconfig   | 6 +-----
 drivers/net/dsa/mv88e6xxx/Kconfig    | 1 -
 drivers/net/ethernet/marvell/Kconfig | 1 -
 4 files changed, 1 insertion(+), 8 deletions(-)

-- 
2.20.1

[PATCH net 0/4] Remove unneeded PHY time stamping option.

[Richard Cochran]

The NETWORK_PHY_TIMESTAMPING configuration option adds additional
checks into the networking hot path, and it is only needed by two
rather esoteric devices, namely the TI DP83640 PHYTER and the ZHAW
InES 1588 IP core.  Very few end users have these devices, and those
that do have them are building specialized embedded systems.

Unfortunately two unrelated drivers depend on this option, and two
defconfigs enable it.  It is probably my fault for not paying enough
attention in reviews.

This series corrects the gratuitous use of NETWORK_PHY_TIMESTAMPING.


Richard Cochran (4):
  net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.
  net: mvpp2: Remove unneeded Kconfig dependency.
  ARM: socfpga_defconfig: Disable PHY time stamping by default.
  ARM: axm55xx_defconfig: Disable PHY time stamping by default.

 arch/arm/configs/axm55xx_defconfig   | 1 -
 arch/arm/configs/socfpga_defconfig   | 6 +-----
 drivers/net/dsa/mv88e6xxx/Kconfig    | 1 -
 drivers/net/ethernet/marvell/Kconfig | 1 -
 4 files changed, 1 insertion(+), 8 deletions(-)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.

[Richard Cochran]

The mv88e6xxx is a DSA driver, and it implements DSA style time
stamping of PTP frames.  It has no need of the expensive option to
enable PHY time stamping.  Remove the bogus dependency.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
---
 drivers/net/dsa/mv88e6xxx/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/Kconfig b/drivers/net/dsa/mv88e6xxx/Kconfig
index 51185e4d7d15..b17540926c11 100644
--- a/drivers/net/dsa/mv88e6xxx/Kconfig
+++ b/drivers/net/dsa/mv88e6xxx/Kconfig
@@ -25,7 +25,6 @@ config NET_DSA_MV88E6XXX_PTP
 	default n
 	depends on NET_DSA_MV88E6XXX_GLOBAL2
 	depends on PTP_1588_CLOCK
-	imply NETWORK_PHY_TIMESTAMPING
 	help
 	  Say Y to enable PTP hardware timestamping on Marvell 88E6xxx switch
 	  chips that support it.
-- 
2.20.1

[PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.

[Richard Cochran]

The mv88e6xxx is a DSA driver, and it implements DSA style time
stamping of PTP frames.  It has no need of the expensive option to
enable PHY time stamping.  Remove the bogus dependency.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
---
 drivers/net/dsa/mv88e6xxx/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/Kconfig b/drivers/net/dsa/mv88e6xxx/Kconfig
index 51185e4d7d15..b17540926c11 100644
--- a/drivers/net/dsa/mv88e6xxx/Kconfig
+++ b/drivers/net/dsa/mv88e6xxx/Kconfig
@@ -25,7 +25,6 @@ config NET_DSA_MV88E6XXX_PTP
 	default n
 	depends on NET_DSA_MV88E6XXX_GLOBAL2
 	depends on PTP_1588_CLOCK
-	imply NETWORK_PHY_TIMESTAMPING
 	help
 	  Say Y to enable PTP hardware timestamping on Marvell 88E6xxx switch
 	  chips that support it.
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

The mvpp2 is an Ethernet driver, and it implements MAC style time
stamping of PTP frames.  It has no need of the expensive option to
enable PHY time stamping.  Remove the incorrect dependency.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
---
 drivers/net/ethernet/marvell/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
index 41815b609569..7fe15a3286f4 100644
--- a/drivers/net/ethernet/marvell/Kconfig
+++ b/drivers/net/ethernet/marvell/Kconfig
@@ -94,7 +94,6 @@ config MVPP2
 
 config MVPP2_PTP
 	bool "Marvell Armada 8K Enable PTP support"
-	depends on NETWORK_PHY_TIMESTAMPING
 	depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
 		   (PTP_1588_CLOCK && MVPP2 = m)
 
-- 
2.20.1

[PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

The mvpp2 is an Ethernet driver, and it implements MAC style time
stamping of PTP frames.  It has no need of the expensive option to
enable PHY time stamping.  Remove the incorrect dependency.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
---
 drivers/net/ethernet/marvell/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
index 41815b609569..7fe15a3286f4 100644
--- a/drivers/net/ethernet/marvell/Kconfig
+++ b/drivers/net/ethernet/marvell/Kconfig
@@ -94,7 +94,6 @@ config MVPP2
 
 config MVPP2_PTP
 	bool "Marvell Armada 8K Enable PTP support"
-	depends on NETWORK_PHY_TIMESTAMPING
 	depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
 		   (PTP_1588_CLOCK && MVPP2 = m)
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH net 3/4] ARM: socfpga_defconfig: Disable PHY time stamping by default.

[Richard Cochran]

The NETWORK_PHY_TIMESTAMPING configuration option adds overhead into
the networking stack.  When enabled, all transmitted and received
frames are subjected to extra tests to determine whether they just
might be PTP frames to be presented to esoteric PHY time stamping
drivers.

However, no System on Chip, least ways not the socfpga SoC, includes
such a PHY time stamping device.  Disable the unneeded option by
default.

The diff includes a bit of extra churn caused by "make savedefconfig",
but the generated defconfig is now in the canonical form.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
 arch/arm/configs/socfpga_defconfig | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index e73c97b0f5b0..5bd433028285 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -14,8 +14,6 @@ CONFIG_ARM_THUMBEE=y
 CONFIG_SMP=y
 CONFIG_NR_CPUS=2
 CONFIG_HIGHMEM=y
-CONFIG_ZBOOT_ROM_TEXT=0x0
-CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_VFP=y
 CONFIG_NEON=y
 CONFIG_OPROFILE=y
@@ -33,7 +31,6 @@ CONFIG_IP_PNP=y
 CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
 CONFIG_IP_PNP_RARP=y
-CONFIG_NETWORK_PHY_TIMESTAMPING=y
 CONFIG_VLAN_8021Q=y
 CONFIG_VLAN_8021Q_GVRP=y
 CONFIG_CAN=y
@@ -48,12 +45,10 @@ CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_MTD=y
 CONFIG_MTD_BLOCK=y
-CONFIG_MTD_M25P80=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_MTD_NAND_DENALI_DT=y
 CONFIG_MTD_SPI_NOR=y
 # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
-CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_OF_OVERLAY=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
@@ -89,6 +84,7 @@ CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_SPI=y
+CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_SPI_DESIGNWARE=y
 CONFIG_SPI_DW_MMIO=y
 CONFIG_SPI_SPIDEV=y
-- 
2.20.1

[PATCH net 3/4] ARM: socfpga_defconfig: Disable PHY time stamping by default.

[Richard Cochran]

The NETWORK_PHY_TIMESTAMPING configuration option adds overhead into
the networking stack.  When enabled, all transmitted and received
frames are subjected to extra tests to determine whether they just
might be PTP frames to be presented to esoteric PHY time stamping
drivers.

However, no System on Chip, least ways not the socfpga SoC, includes
such a PHY time stamping device.  Disable the unneeded option by
default.

The diff includes a bit of extra churn caused by "make savedefconfig",
but the generated defconfig is now in the canonical form.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
 arch/arm/configs/socfpga_defconfig | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index e73c97b0f5b0..5bd433028285 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -14,8 +14,6 @@ CONFIG_ARM_THUMBEE=y
 CONFIG_SMP=y
 CONFIG_NR_CPUS=2
 CONFIG_HIGHMEM=y
-CONFIG_ZBOOT_ROM_TEXT=0x0
-CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_VFP=y
 CONFIG_NEON=y
 CONFIG_OPROFILE=y
@@ -33,7 +31,6 @@ CONFIG_IP_PNP=y
 CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
 CONFIG_IP_PNP_RARP=y
-CONFIG_NETWORK_PHY_TIMESTAMPING=y
 CONFIG_VLAN_8021Q=y
 CONFIG_VLAN_8021Q_GVRP=y
 CONFIG_CAN=y
@@ -48,12 +45,10 @@ CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_MTD=y
 CONFIG_MTD_BLOCK=y
-CONFIG_MTD_M25P80=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_MTD_NAND_DENALI_DT=y
 CONFIG_MTD_SPI_NOR=y
 # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
-CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_OF_OVERLAY=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
@@ -89,6 +84,7 @@ CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_SPI=y
+CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_SPI_DESIGNWARE=y
 CONFIG_SPI_DW_MMIO=y
 CONFIG_SPI_SPIDEV=y
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH net 4/4] ARM: axm55xx_defconfig: Disable PHY time stamping by default.

[Richard Cochran]

The NETWORK_PHY_TIMESTAMPING configuration option adds overhead into
the networking stack.  When enabled, all transmitted and received
frames are subjected to extra tests to determine whether they just
might be PTP frames to be presented to esoteric PHY time stamping
drivers.

However, no System on Chip, least ways not the axm55xx SoC, includes
such a PHY time stamping device.  Disable the unneeded option by
default.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
 arch/arm/configs/axm55xx_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/axm55xx_defconfig b/arch/arm/configs/axm55xx_defconfig
index 46075216ee6d..2d1a45066649 100644
--- a/arch/arm/configs/axm55xx_defconfig
+++ b/arch/arm/configs/axm55xx_defconfig
@@ -73,7 +73,6 @@ CONFIG_INET_AH=y
 CONFIG_INET_ESP=y
 CONFIG_INET_IPCOMP=y
 # CONFIG_IPV6 is not set
-CONFIG_NETWORK_PHY_TIMESTAMPING=y
 CONFIG_BRIDGE=y
 # CONFIG_WIRELESS is not set
 CONFIG_DEVTMPFS=y
-- 
2.20.1

[PATCH net 4/4] ARM: axm55xx_defconfig: Disable PHY time stamping by default.

[Richard Cochran]

The NETWORK_PHY_TIMESTAMPING configuration option adds overhead into
the networking stack.  When enabled, all transmitted and received
frames are subjected to extra tests to determine whether they just
might be PTP frames to be presented to esoteric PHY time stamping
drivers.

However, no System on Chip, least ways not the axm55xx SoC, includes
such a PHY time stamping device.  Disable the unneeded option by
default.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
 arch/arm/configs/axm55xx_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/axm55xx_defconfig b/arch/arm/configs/axm55xx_defconfig
index 46075216ee6d..2d1a45066649 100644
--- a/arch/arm/configs/axm55xx_defconfig
+++ b/arch/arm/configs/axm55xx_defconfig
@@ -73,7 +73,6 @@ CONFIG_INET_AH=y
 CONFIG_INET_ESP=y
 CONFIG_INET_IPCOMP=y
 # CONFIG_IPV6 is not set
-CONFIG_NETWORK_PHY_TIMESTAMPING=y
 CONFIG_BRIDGE=y
 # CONFIG_WIRELESS is not set
 CONFIG_DEVTMPFS=y
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Russell King - ARM Linux admin]

On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> The mvpp2 is an Ethernet driver, and it implements MAC style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the incorrect dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")

NAK.

> ---
>  drivers/net/ethernet/marvell/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index 41815b609569..7fe15a3286f4 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -94,7 +94,6 @@ config MVPP2
>  
>  config MVPP2_PTP
>  	bool "Marvell Armada 8K Enable PTP support"
> -	depends on NETWORK_PHY_TIMESTAMPING
>  	depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
>  		   (PTP_1588_CLOCK && MVPP2 = m)
>  
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Russell King - ARM Linux admin]

On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> The mvpp2 is an Ethernet driver, and it implements MAC style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the incorrect dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")

NAK.

> ---
>  drivers/net/ethernet/marvell/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index 41815b609569..7fe15a3286f4 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -94,7 +94,6 @@ config MVPP2
>  
>  config MVPP2_PTP
>  	bool "Marvell Armada 8K Enable PTP support"
> -	depends on NETWORK_PHY_TIMESTAMPING
>  	depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
>  		   (PTP_1588_CLOCK && MVPP2 = m)
>  
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > stamping of PTP frames.  It has no need of the expensive option to
> > enable PHY time stamping.  Remove the incorrect dependency.
> > 
> > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
> 
> NAK.

Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?

Thanks,
Richard

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > stamping of PTP frames.  It has no need of the expensive option to
> > enable PHY time stamping.  Remove the incorrect dependency.
> > 
> > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
> 
> NAK.

Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?

Thanks,
Richard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 0/4] Remove unneeded PHY time stamping option.

[Richard Cochran]

On Wed, Jan 20, 2021 at 08:05:59PM -0800, Richard Cochran wrote:
> The NETWORK_PHY_TIMESTAMPING configuration option adds additional
> checks into the networking hot path, and it is only needed by two
> rather esoteric devices,

Correction: there are three legitimate users of PHY time stamping...

> namely the TI DP83640 PHYTER and the ZHAW
> InES 1588 IP core.

There is also net/phy/mscc.

Thanks,
Richard

Re: [PATCH net 0/4] Remove unneeded PHY time stamping option.

[Richard Cochran]

On Wed, Jan 20, 2021 at 08:05:59PM -0800, Richard Cochran wrote:
> The NETWORK_PHY_TIMESTAMPING configuration option adds additional
> checks into the networking hot path, and it is only needed by two
> rather esoteric devices,

Correction: there are three legitimate users of PHY time stamping...

> namely the TI DP83640 PHYTER and the ZHAW
> InES 1588 IP core.

There is also net/phy/mscc.

Thanks,
Richard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.

[Brandon Streiff]

On 1/20/2021 10:06 PM, Richard Cochran wrote:
> The mv88e6xxx is a DSA driver, and it implements DSA style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the bogus dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
Ah, I must have thought I needed skb_defer_rx_timestamp in mv88e6xxx,
but instead DSA gained its own timestamp path so mv88e6xxx turned out
to not need that at all, and I never went back and dropped the Kconfig
dependency. Whoops. Yup, I don't think we don't need it here.

Acked-by: Brandon Streiff <brandon.streiff@ni.com>

Re: [PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.

[Brandon Streiff]

On 1/20/2021 10:06 PM, Richard Cochran wrote:
> The mv88e6xxx is a DSA driver, and it implements DSA style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the bogus dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
Ah, I must have thought I needed skb_defer_rx_timestamp in mv88e6xxx,
but instead DSA gained its own timestamp path so mv88e6xxx turned out
to not need that at all, and I never went back and dropped the Kconfig
dependency. Whoops. Yup, I don't think we don't need it here.

Acked-by: Brandon Streiff <brandon.streiff@ni.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Jakub Kicinski]

On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote:
> On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:  
> > > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > > stamping of PTP frames.  It has no need of the expensive option to
> > > enable PHY time stamping.  Remove the incorrect dependency.
> > > 
> > > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")  
> > 
> > NAK.  
> 
> Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?

Russell, I think we all agree now this is not the solution to the
problem of which entity should provide the timestamp, but the series
doesn't seem objectionable in itself.

Please LMK if you think otherwise.

(I would put it in net-next tho, given the above this at most a space
optimization.)

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Jakub Kicinski]

On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote:
> On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:  
> > > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > > stamping of PTP frames.  It has no need of the expensive option to
> > > enable PHY time stamping.  Remove the incorrect dependency.
> > > 
> > > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")  
> > 
> > NAK.  
> 
> Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?

Russell, I think we all agree now this is not the solution to the
problem of which entity should provide the timestamp, but the series
doesn't seem objectionable in itself.

Please LMK if you think otherwise.

(I would put it in net-next tho, given the above this at most a space
optimization.)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Russell King - ARM Linux admin]

On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:
> On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote:
> > On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> > > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:  
> > > > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > > > stamping of PTP frames.  It has no need of the expensive option to
> > > > enable PHY time stamping.  Remove the incorrect dependency.
> > > > 
> > > > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > > > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")  
> > > 
> > > NAK.  
> > 
> > Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?
> 
> Russell, I think we all agree now this is not the solution to the
> problem of which entity should provide the timestamp, but the series
> doesn't seem objectionable in itself.
> 
> Please LMK if you think otherwise.
> 
> (I would put it in net-next tho, given the above this at most a space
> optimization.)

Correct - my NAK is on the basis that this series was put forward
as solving the issue I had raised, but in reality it does little
to achieve that.

It is, as you say, just a space optimisation, and I have no issue
with it being merged on that basis.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Russell King - ARM Linux admin]

On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:
> On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote:
> > On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
> > > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:  
> > > > The mvpp2 is an Ethernet driver, and it implements MAC style time
> > > > stamping of PTP frames.  It has no need of the expensive option to
> > > > enable PHY time stamping.  Remove the incorrect dependency.
> > > > 
> > > > Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> > > > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")  
> > > 
> > > NAK.  
> > 
> > Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?
> 
> Russell, I think we all agree now this is not the solution to the
> problem of which entity should provide the timestamp, but the series
> doesn't seem objectionable in itself.
> 
> Please LMK if you think otherwise.
> 
> (I would put it in net-next tho, given the above this at most a space
> optimization.)

Correct - my NAK is on the basis that this series was put forward
as solving the issue I had raised, but in reality it does little
to achieve that.

It is, as you say, just a space optimisation, and I have no issue
with it being merged on that basis.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:

> (I would put it in net-next tho, given the above this at most a space
> optimization.)

It isn't just about space but also time.  The reason why I targeted
net and not net-next was that NETWORK_PHY_TIMESTAMPING activates a
function call to skb_clone_tx_timestamp() for every transmitted frame.

	static inline void skb_tx_timestamp(struct sk_buff *skb)
	{
		skb_clone_tx_timestamp(skb);
		if (skb_shinfo(skb)->tx_flags & SKBTX_SW_TSTAMP)
			skb_tstamp_tx(skb, NULL);
	}

In the abscence of a PHY time stamping device, the check for its
presence inside of skb_clone_tx_timestamp() will of course fail, but
this still incurs the cost of the call on every transmitted skb.

Similarly netif_receive_skb() futilely calls skb_defer_rx_timestamp()
on every received skb.

I would argue that most users don't want this option activated by
accident.

(And yes, we could avoid the functions call by moving the check
outside of the global functions and inline to the call sites.  I'll be
sure to have that in the shiny new improved scheme under discussion.)

Thanks,
Richard

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:

> (I would put it in net-next tho, given the above this at most a space
> optimization.)

It isn't just about space but also time.  The reason why I targeted
net and not net-next was that NETWORK_PHY_TIMESTAMPING activates a
function call to skb_clone_tx_timestamp() for every transmitted frame.

	static inline void skb_tx_timestamp(struct sk_buff *skb)
	{
		skb_clone_tx_timestamp(skb);
		if (skb_shinfo(skb)->tx_flags & SKBTX_SW_TSTAMP)
			skb_tstamp_tx(skb, NULL);
	}

In the abscence of a PHY time stamping device, the check for its
presence inside of skb_clone_tx_timestamp() will of course fail, but
this still incurs the cost of the call on every transmitted skb.

Similarly netif_receive_skb() futilely calls skb_defer_rx_timestamp()
on every received skb.

I would argue that most users don't want this option activated by
accident.

(And yes, we could avoid the functions call by moving the check
outside of the global functions and inline to the call sites.  I'll be
sure to have that in the shiny new improved scheme under discussion.)

Thanks,
Richard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Jakub Kicinski]

On Sat, 23 Jan 2021 05:26:26 -0800 Richard Cochran wrote:
> On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:
> 
> > (I would put it in net-next tho, given the above this at most a space
> > optimization.)  
> 
> It isn't just about space but also time.  The reason why I targeted
> net and not net-next was that NETWORK_PHY_TIMESTAMPING activates a
> function call to skb_clone_tx_timestamp() for every transmitted frame.
> 
> 	static inline void skb_tx_timestamp(struct sk_buff *skb)
> 	{
> 		skb_clone_tx_timestamp(skb);
> 		if (skb_shinfo(skb)->tx_flags & SKBTX_SW_TSTAMP)
> 			skb_tstamp_tx(skb, NULL);
> 	}
> 
> In the abscence of a PHY time stamping device, the check for its
> presence inside of skb_clone_tx_timestamp() will of course fail, but
> this still incurs the cost of the call on every transmitted skb.
> 
> Similarly netif_receive_skb() futilely calls skb_defer_rx_timestamp()
> on every received skb.
> 
> I would argue that most users don't want this option activated by
> accident.

I see. The only thing I'm worried about then is the churn in patch 3.
This would land in Linus's tree shortly before rc6, kinda late to be
taking chances in the name of minor optimizations :S
 
> (And yes, we could avoid the functions call by moving the check
> outside of the global functions and inline to the call sites.  I'll be
> sure to have that in the shiny new improved scheme under discussion.)

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Jakub Kicinski]

On Sat, 23 Jan 2021 05:26:26 -0800 Richard Cochran wrote:
> On Fri, Jan 22, 2021 at 06:14:44PM -0800, Jakub Kicinski wrote:
> 
> > (I would put it in net-next tho, given the above this at most a space
> > optimization.)  
> 
> It isn't just about space but also time.  The reason why I targeted
> net and not net-next was that NETWORK_PHY_TIMESTAMPING activates a
> function call to skb_clone_tx_timestamp() for every transmitted frame.
> 
> 	static inline void skb_tx_timestamp(struct sk_buff *skb)
> 	{
> 		skb_clone_tx_timestamp(skb);
> 		if (skb_shinfo(skb)->tx_flags & SKBTX_SW_TSTAMP)
> 			skb_tstamp_tx(skb, NULL);
> 	}
> 
> In the abscence of a PHY time stamping device, the check for its
> presence inside of skb_clone_tx_timestamp() will of course fail, but
> this still incurs the cost of the call on every transmitted skb.
> 
> Similarly netif_receive_skb() futilely calls skb_defer_rx_timestamp()
> on every received skb.
> 
> I would argue that most users don't want this option activated by
> accident.

I see. The only thing I'm worried about then is the churn in patch 3.
This would land in Linus's tree shortly before rc6, kinda late to be
taking chances in the name of minor optimizations :S
 
> (And yes, we could avoid the functions call by moving the check
> outside of the global functions and inline to the call sites.  I'll be
> sure to have that in the shiny new improved scheme under discussion.)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

On Sat, Jan 23, 2021 at 12:12:27PM -0800, Jakub Kicinski wrote:
> I see. The only thing I'm worried about then is the churn in patch 3.
> This would land in Linus's tree shortly before rc6, kinda late to be
> taking chances in the name of minor optimizations :S

;^)

Yeah, by all means, avoid ARM churn... I remember Bad Things there...

Maybe you could take #1 and #2 for net-next?

I should probably submit 3-4 throught the SoC tree anyhow.

Thanks,
Richard

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Richard Cochran]

On Sat, Jan 23, 2021 at 12:12:27PM -0800, Jakub Kicinski wrote:
> I see. The only thing I'm worried about then is the churn in patch 3.
> This would land in Linus's tree shortly before rc6, kinda late to be
> taking chances in the name of minor optimizations :S

;^)

Yeah, by all means, avoid ARM churn... I remember Bad Things there...

Maybe you could take #1 and #2 for net-next?

I should probably submit 3-4 throught the SoC tree anyhow.

Thanks,
Richard


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Jakub Kicinski]

On Sat, 23 Jan 2021 13:14:00 -0800 Richard Cochran wrote:
> On Sat, Jan 23, 2021 at 12:12:27PM -0800, Jakub Kicinski wrote:
> > I see. The only thing I'm worried about then is the churn in patch 3.
> > This would land in Linus's tree shortly before rc6, kinda late to be
> > taking chances in the name of minor optimizations :S  
> 
> ;^)
> 
> Yeah, by all means, avoid ARM churn... I remember Bad Things there...
> 
> Maybe you could take #1 and #2 for net-next?

Done, thanks!

> I should probably submit 3-4 throught the SoC tree anyhow.

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

[Jakub Kicinski]

On Sat, 23 Jan 2021 13:14:00 -0800 Richard Cochran wrote:
> On Sat, Jan 23, 2021 at 12:12:27PM -0800, Jakub Kicinski wrote:
> > I see. The only thing I'm worried about then is the churn in patch 3.
> > This would land in Linus's tree shortly before rc6, kinda late to be
> > taking chances in the name of minor optimizations :S  
> 
> ;^)
> 
> Yeah, by all means, avoid ARM churn... I remember Bad Things there...
> 
> Maybe you could take #1 and #2 for net-next?

Done, thanks!

> I should probably submit 3-4 throught the SoC tree anyhow.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel