All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libpcap: fix build failure without wchar
@ 2021-01-22 22:52 Fabrice Fontaine
  2021-01-23 17:06 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-01-22 22:52 UTC (permalink / raw)
  To: buildroot

libpcap requires c99 since version 1.10.0 and
https://github.com/the-tcpdump-group/libpcap/commit/68e5ca3f4cbb66d687582ae9563009c87bf3d184

However, this test will fail without wchar on:

configure:3609: /home/buildroot/autobuild/run/instance-2/output-1/host/bin/arm-linux-gcc -std=gnu99 -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5
conftest.c:52:9: error: unknown type name 'wchar_t'
   const wchar_t *name;
         ^~~~~~~

So hardcode ac_cv_prog_cc_c99 as already done in numerous package such
as apparmor, wireshark, xz, etc.

Fixes:
 - http://autobuild.buildroot.org/results/6e87c25a0dccccf5e7ad03742597a0613f554506

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libpcap/libpcap.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/libpcap/libpcap.mk b/package/libpcap/libpcap.mk
index 69247d316d..502570b24d 100644
--- a/package/libpcap/libpcap.mk
+++ b/package/libpcap/libpcap.mk
@@ -13,8 +13,11 @@ LIBPCAP_INSTALL_STAGING = YES
 LIBPCAP_DEPENDENCIES = host-flex host-bison host-pkgconf
 HOST_LIBPCAP_DEPENDENCIES = host-flex host-bison host-pkgconf
 
+# ac_cv_prog_cc_c99 is required for BR2_USE_WCHAR=n because the C99 test
+# provided by autoconf relies on wchar_t.
 LIBPCAP_CONF_ENV = \
 	ac_cv_header_linux_wireless_h=yes \
+	ac_cv_prog_cc_c99=-std=gnu99 \
 	CFLAGS="$(LIBPCAP_CFLAGS)"
 LIBPCAP_CFLAGS = $(TARGET_CFLAGS)
 LIBPCAP_CONF_OPTS = --disable-yydebug --with-pcap=linux --without-dag \
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/libpcap: fix build failure without wchar
  2021-01-22 22:52 [Buildroot] [PATCH 1/1] package/libpcap: fix build failure without wchar Fabrice Fontaine
@ 2021-01-23 17:06 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-01-23 17:06 UTC (permalink / raw)
  To: buildroot

On Fri, 22 Jan 2021 23:52:21 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libpcap requires c99 since version 1.10.0 and
> https://github.com/the-tcpdump-group/libpcap/commit/68e5ca3f4cbb66d687582ae9563009c87bf3d184
> 
> However, this test will fail without wchar on:
> 
> configure:3609: /home/buildroot/autobuild/run/instance-2/output-1/host/bin/arm-linux-gcc -std=gnu99 -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5
> conftest.c:52:9: error: unknown type name 'wchar_t'
>    const wchar_t *name;
>          ^~~~~~~
> 
> So hardcode ac_cv_prog_cc_c99 as already done in numerous package such
> as apparmor, wireshark, xz, etc.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/6e87c25a0dccccf5e7ad03742597a0613f554506
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libpcap/libpcap.mk | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-23 17:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 22:52 [Buildroot] [PATCH 1/1] package/libpcap: fix build failure without wchar Fabrice Fontaine
2021-01-23 17:06 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.