From: Dario Binacchi <dariobin@libero.it>
To: u-boot@lists.denx.de
Subject: [PATCH 05/11] pinctrl: single: check "register-width" DT property
Date: Sat, 23 Jan 2021 19:27:05 +0100 [thread overview]
Message-ID: <20210123182711.7177-6-dariobin@libero.it> (raw)
In-Reply-To: <20210123182711.7177-1-dariobin@libero.it>
In more recent versions of the Linux kernel the driver's probe function
returns an error if the "pinctrl-single,register-width" DT property is
missing. The lack of this information, in fact, does not allow to know
whether to access the registers of the controller at 8, 16 or 32 bits.
Signed-off-by: Dario Binacchi <dariobin@libero.it>
---
drivers/pinctrl/pinctrl-single.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index c80a42a193..8fd3bf66de 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -22,7 +22,7 @@ struct single_pdata {
fdt_addr_t base;
int offset;
u32 mask;
- int width;
+ u32 width;
bool bits_per_mux;
};
@@ -184,9 +184,13 @@ static int single_of_to_plat(struct udevice *dev)
fdt_addr_t addr;
fdt_size_t size;
struct single_pdata *pdata = dev_get_plat(dev);
+ int ret;
- pdata->width =
- dev_read_u32_default(dev, "pinctrl-single,register-width", 0);
+ ret = dev_read_u32(dev, "pinctrl-single,register-width", &pdata->width);
+ if (ret) {
+ dev_err(dev, "missing register width\n");
+ return ret;
+ }
dev_read_addr_size(dev, "reg", &size);
pdata->offset = size - pdata->width / BITS_PER_BYTE;
--
2.17.1
next prev parent reply other threads:[~2021-01-23 18:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 18:27 [PATCH 00/11] Add support for pinmux status command on beaglebone Dario Binacchi
2021-01-23 18:27 ` [PATCH 01/11] pinctrl: single: fix format of structure documentation Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-23 18:27 ` [PATCH 02/11] pinctrl: single: fix the loop counter variable type Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-25 16:53 ` Pratyush Yadav
2021-01-23 18:27 ` [PATCH 03/11] pinctrl: single: fix debug messages formatting Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-25 17:09 ` Pratyush Yadav
2021-01-26 11:20 ` Dario Binacchi
2021-01-27 9:29 ` Pratyush Yadav
2021-01-23 18:27 ` [PATCH 04/11] pinctrl: single: get register area size by device API Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-23 18:27 ` Dario Binacchi [this message]
2021-01-24 2:03 ` [PATCH 05/11] pinctrl: single: check "register-width" DT property Simon Glass
2021-01-23 18:27 ` [PATCH 06/11] pinctrl: single: change function mask default value Dario Binacchi
2021-01-23 18:27 ` [PATCH 07/11] pinctrl: single: use function pointer for register access Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-24 16:50 ` Dario Binacchi
2021-01-24 18:00 ` Simon Glass
2021-01-23 18:27 ` [PATCH 08/11] pinctrl: single: add get_pins_count operation Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-23 18:27 ` [PATCH 09/11] pinctrl: single: add get_pin_name operation Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-23 18:27 ` [PATCH 10/11] pinctrl: single: add get_pin_muxing operation Dario Binacchi
2021-01-24 2:03 ` Simon Glass
2021-01-26 11:28 ` Dario Binacchi
2021-02-01 20:38 ` Simon Glass
2021-01-23 18:27 ` [PATCH 11/11] test: pinmux: add test for 'pinctrl-single' driver Dario Binacchi
2021-01-24 2:03 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123182711.7177-6-dariobin@libero.it \
--to=dariobin@libero.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.