From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C084C433E0 for ; Sat, 23 Jan 2021 20:35:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8478022C7B for ; Sat, 23 Jan 2021 20:35:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8478022C7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=lmichel.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3PdG-0008A0-Je for qemu-devel@archiver.kernel.org; Sat, 23 Jan 2021 15:35:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PbC-0006i4-4B; Sat, 23 Jan 2021 15:33:34 -0500 Received: from pharaoh.lmichel.fr ([149.202.28.74]:58896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PbA-0004Xs-DN; Sat, 23 Jan 2021 15:33:33 -0500 Received: from localhost (sekoia-pc.home.lmichel.fr [192.168.61.100]) by pharaoh.lmichel.fr (Postfix) with ESMTPSA id B9F75C602E6; Sat, 23 Jan 2021 21:33:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lmichel.fr; s=pharaoh; t=1611434009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6e+z3MckAZFaGT703sf2KecvlXuBkoiUJcmnxnowGZU=; b=SChU8k6SM9NnCFHEQHpuh0aNi1kxogPietfj30yXmO0XnEFPP/nAyDoK475RrRewytZ7+y nWyV8HKaCaKMqzx7S5UsXGYJPfnZ6vcRZKwu+rLBMHUenkWk1fV6ZsVtW7x1Xj3jQ9c4zM wkKbw0mN0yStHF95UYpeNLIdVHukHvmvnCIkiMAhoEPX5WkzevpoVgRPMIdobCC2dfZsIy lo+e7wTrjh+k4FowAbV/MPObi8G1bdUFIySDZkY31pkpj9irQUlnzdITzcn6YvAedMIe6r hdBO3tRH7JBBWVSzUY+vmulu6ABrFV3OlTQy3QLvTa7wDh/zkCe9WMpwzVSO+A== Date: Sat, 23 Jan 2021 21:33:51 +0100 From: Luc Michel To: Peter Maydell Subject: Re: [PATCH 25/25] hw/arm/stellaris: Remove board-creation reset of STELLARIS_SYS Message-ID: <20210123203351.453pcpozshxiwlxg@sekoia-pc.home.lmichel.fr> References: <20210121190622.22000-1-peter.maydell@linaro.org> <20210121190622.22000-26-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121190622.22000-26-peter.maydell@linaro.org> Received-SPF: pass client-ip=149.202.28.74; envelope-from=luc@lmichel.fr; helo=pharaoh.lmichel.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 19:06 Thu 21 Jan , Peter Maydell wrote: > Now that the watchdog device uses its Clock input rather than being > passed the value of system_clock_scale at creation time, we can > remove the hack where we reset the STELLARIS_SYS at board creation > time to force it to set system_clock_scale. Instead it will be reset > at the usual point in startup and will inform the watchdog of the > clock frequency at that point. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/arm/stellaris.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c > index 5acb043a07e..ad72c0959f1 100644 > --- a/hw/arm/stellaris.c > +++ b/hw/arm/stellaris.c > @@ -780,16 +780,6 @@ static DeviceState *stellaris_sys_init(uint32_t base, qemu_irq irq, > sysbus_mmio_map(sbd, 0, base); > sysbus_connect_irq(sbd, 0, irq); > > - /* > - * Normally we should not be resetting devices like this during > - * board creation. For the moment we need to do so, because > - * system_clock_scale will only get set when the STELLARIS_SYS > - * device is reset, and we need its initial value to pass to > - * the watchdog device. This hack can be removed once the > - * watchdog has been converted to use a Clock input instead. > - */ > - device_cold_reset(dev); > - > return dev; > } > > -- > 2.20.1 > --