From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D7FC433DB for ; Sun, 24 Jan 2021 07:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A224122CB9 for ; Sun, 24 Jan 2021 07:35:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726398AbhAXHfL (ORCPT ); Sun, 24 Jan 2021 02:35:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:44028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbhAXHfI (ORCPT ); Sun, 24 Jan 2021 02:35:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E537422CB9; Sun, 24 Jan 2021 07:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611473668; bh=l26cadTrzC6oT1xvBvVwDxUyuOKNwCRzA4NrTS5KmJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FxP/GSt6Nu/NaO08sLfRDvYXj8tVW5hBVmYO/tm7FebCncZoAwX4ExNTcimu1j35Z ns/okx4cRyvfmGdn1cYdNaAbZ5OWQgsU6xsnB2531nlb4fFNQqSawN4qZEm7k0ic4p XJbuKgUSwELlk1mqU/+R+3wtPN7/fVSYndf742xaE23TKnVgMkWyLTLppSY34WJLOK AWHImsMpxblrvI+l3JRYUR4nlZYmDWUF4vfUmZSpTEnUhlmBDUzvvfuhunjFc7qWto Uvhnp0vNuR7k2s8NX89kr7bv++Gz16fMI1fDltsqexgEzoeSu+KMsTWoIASbvhbPyg eniG0w7KGjlBA== Date: Sun, 24 Jan 2021 09:34:21 +0200 From: Mike Rapoport To: Andrew Morton Cc: Thiago Jung Bauermann , guro@fb.com, iamjoonsoo.kim@lge.com, Ram Pai , Konrad Rzeszutek Wilk , Satheesh Rajendran , kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mhocko@kernel.org, riel@surriel.com Subject: Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end Message-ID: <20210124073421.GG6332@kernel.org> References: <20201220064959.GB392325@kernel.org> <20210122043714.266075-1-bauerman@linux.ibm.com> <20210123180911.aafa8404a3a7a30779713456@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210123180911.aafa8404a3a7a30779713456@linux-foundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2021 at 06:09:11PM -0800, Andrew Morton wrote: > On Fri, 22 Jan 2021 01:37:14 -0300 Thiago Jung Bauermann wrote: > > > Mike Rapoport writes: > > > > > > Signed-off-by: Roman Gushchin > > > > > > Reviewed-by: Mike Rapoport > > > > I've seen a couple of spurious triggers of the WARN_ONCE() removed by this > > patch. This happens on some ppc64le bare metal (powernv) server machines with > > CONFIG_SWIOTLB=y and crashkernel=4G, as described in a candidate patch I posted > > to solve this issue in a different way: > > > > https://lore.kernel.org/linuxppc-dev/20201218062103.76102-1-bauerman@linux.ibm.com/ > > > > Since this patch solves that problem, is it possible to include it in the next > > feasible v5.11-rcX, with the following tag? > > We could do this, if we're confident that this patch doesn't depend on > [1/2] "mm: cma: allocate cma areas bottom-up"? I think it is... A think it does not depend on cma bottom-up allocation, it's rather the other way around: without this CMA bottom-up allocation could fail with KASLR enabled. Still, this patch may need updates to the way x86 does early reservations: https://lore.kernel.org/lkml/20210115083255.12744-1-rppt@kernel.org > > Fixes: 8fabc623238e ("powerpc: Ensure that swiotlb buffer is allocated from low memory") > > I added that. > > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDDEC433DB for ; Sun, 24 Jan 2021 07:36:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECE3322CB9 for ; Sun, 24 Jan 2021 07:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECE3322CB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DNlD53b1QzDqnB for ; Sun, 24 Jan 2021 18:36:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=rppt@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FxP/GSt6; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DNlBH2yPLzDqRK for ; Sun, 24 Jan 2021 18:34:31 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id E537422CB9; Sun, 24 Jan 2021 07:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611473668; bh=l26cadTrzC6oT1xvBvVwDxUyuOKNwCRzA4NrTS5KmJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FxP/GSt6Nu/NaO08sLfRDvYXj8tVW5hBVmYO/tm7FebCncZoAwX4ExNTcimu1j35Z ns/okx4cRyvfmGdn1cYdNaAbZ5OWQgsU6xsnB2531nlb4fFNQqSawN4qZEm7k0ic4p XJbuKgUSwELlk1mqU/+R+3wtPN7/fVSYndf742xaE23TKnVgMkWyLTLppSY34WJLOK AWHImsMpxblrvI+l3JRYUR4nlZYmDWUF4vfUmZSpTEnUhlmBDUzvvfuhunjFc7qWto Uvhnp0vNuR7k2s8NX89kr7bv++Gz16fMI1fDltsqexgEzoeSu+KMsTWoIASbvhbPyg eniG0w7KGjlBA== Date: Sun, 24 Jan 2021 09:34:21 +0200 From: Mike Rapoport To: Andrew Morton Subject: Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end Message-ID: <20210124073421.GG6332@kernel.org> References: <20201220064959.GB392325@kernel.org> <20210122043714.266075-1-bauerman@linux.ibm.com> <20210123180911.aafa8404a3a7a30779713456@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210123180911.aafa8404a3a7a30779713456@linux-foundation.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: riel@surriel.com, kernel-team@fb.com, Ram Pai , linux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, Satheesh Rajendran , Konrad Rzeszutek Wilk , iamjoonsoo.kim@lge.com, linuxppc-dev@lists.ozlabs.org, guro@fb.com, Thiago Jung Bauermann Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Jan 23, 2021 at 06:09:11PM -0800, Andrew Morton wrote: > On Fri, 22 Jan 2021 01:37:14 -0300 Thiago Jung Bauermann wrote: > > > Mike Rapoport writes: > > > > > > Signed-off-by: Roman Gushchin > > > > > > Reviewed-by: Mike Rapoport > > > > I've seen a couple of spurious triggers of the WARN_ONCE() removed by this > > patch. This happens on some ppc64le bare metal (powernv) server machines with > > CONFIG_SWIOTLB=y and crashkernel=4G, as described in a candidate patch I posted > > to solve this issue in a different way: > > > > https://lore.kernel.org/linuxppc-dev/20201218062103.76102-1-bauerman@linux.ibm.com/ > > > > Since this patch solves that problem, is it possible to include it in the next > > feasible v5.11-rcX, with the following tag? > > We could do this, if we're confident that this patch doesn't depend on > [1/2] "mm: cma: allocate cma areas bottom-up"? I think it is... A think it does not depend on cma bottom-up allocation, it's rather the other way around: without this CMA bottom-up allocation could fail with KASLR enabled. Still, this patch may need updates to the way x86 does early reservations: https://lore.kernel.org/lkml/20210115083255.12744-1-rppt@kernel.org > > Fixes: 8fabc623238e ("powerpc: Ensure that swiotlb buffer is allocated from low memory") > > I added that. > > -- Sincerely yours, Mike.