All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ssdp-responder: new package
Date: Sun, 24 Jan 2021 10:51:08 +0100	[thread overview]
Message-ID: <20210124095108.GL926565@scaer> (raw)
In-Reply-To: <20210123231559.3036505-1-troglobit@gmail.com>

Joachim, All,

On 2021-01-24 00:15 +0100, Joachim Wiberg spake thusly:
> Small (35k), and stand-alone, SSDP responder with built-in web server
> (on port 1901) for serving description.xml when Windows scans for any
> network devices on the LAN.  Also includes ssdp-scan (31k), similar to
> the mdns-scan tool, to probe for SSDP capable devices.

This package uses pkg-config, so it should have:

    SSDP_RESPONDER_DEPENDENCIES = host-pkgconf

It also has an optional dependency on systemd, so maybe it needs:

    ifeq ($(BR2_PACKAGE_SYSTEMD),y)
    SSDP_RESPONDER_DEPENDENCIES += systemd
    SSDP_RESPONDER_CONF_OPTS += --with-systemd
    else
    SSDP_RESPONDER_CONF_OPTS += --without-systemd
    endif

And since it comes with its systemd service unit, it would be nice to
install it with SSDP_RESPONDER_INSTALL_INIT_SYSTEMD.

[--SNIP--]
> diff --git a/package/ssdp-responder/Config.in b/package/ssdp-responder/Config.in
> new file mode 100644
> index 0000000000..d6d374256e
> --- /dev/null
> +++ b/package/ssdp-responder/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_SSDP_RESPONDER
> +        bool "ssdp-responder"
> +        depends on BR2_USE_MMU # fork()
> +        help
> +          Simple Service Discovery Protocol daemon (SSDP) for networked
> +          Linux and UNIX devices. Useful in any setup, big or small, but
> +          targeted more at embedded systems that need to announce
> +          themselves to Windows systems.

    $ make check-package
    package/ssdp-responder/Config.in:2: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
    package/ssdp-responder/Config.in:3: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
    package/ssdp-responder/Config.in:4: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
    package/ssdp-responder/Config.in:5: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/ssdp-responder/Config.in:6: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/ssdp-responder/Config.in:7: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/ssdp-responder/Config.in:8: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Care to fixup and respin, please?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-01-24  9:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 23:15 [Buildroot] [PATCH 1/1] package/ssdp-responder: new package Joachim Wiberg
2021-01-24  9:51 ` Yann E. MORIN [this message]
2021-01-24 15:36   ` Joachim Wiberg
2021-01-24 19:49   ` [Buildroot] [PATCH v2 0/1] " Joachim Wiberg
2021-01-24 19:49     ` [Buildroot] [PATCH v2 1/1] " Joachim Wiberg
2021-01-24 22:33       ` Yann E. MORIN
2021-01-24 23:36         ` Joachim Wiberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210124095108.GL926565@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.