From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5F9C433E6 for ; Sun, 24 Jan 2021 10:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B4A922ADF for ; Sun, 24 Jan 2021 10:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbhAXKKD (ORCPT ); Sun, 24 Jan 2021 05:10:03 -0500 Received: from verein.lst.de ([213.95.11.211]:41681 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726860AbhAXKIK (ORCPT ); Sun, 24 Jan 2021 05:08:10 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D94556736F; Sun, 24 Jan 2021 11:07:24 +0100 (CET) Date: Sun, 24 Jan 2021 11:07:24 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: Christoph Hellwig , "linux-block@vger.kernel.org" , Jens Axboe , Chaitanya Kulkarni , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "linux-nvme@lists.infradead.org" , Keith Busch Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit Message-ID: <20210124100724.GA27580@lst.de> References: <20210122080014.174391-1-damien.lemoal@wdc.com> <20210122080014.174391-2-damien.lemoal@wdc.com> <20210122084209.GA15710@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Jan 22, 2021 at 08:56:58AM +0000, Damien Le Moal wrote: > > This looks a little strange. If we special case zoned vs not zoned > > here anyway, why not set the zone_write_granularity to the logical > > block size here by default. > > The convention is zone_write_granularity == 0 for the BLK_ZONED_NONE case. Hence > the reset here if we force the zoned model to none for HA drives. This way, this > does not create a special case for HA drives used as regular disks. Just inititialize it for all cases if you initialize it for some here. That way everyone but sd already gets a right default and life becomes simpler. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3199BC433E0 for ; Sun, 24 Jan 2021 10:07:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B771C225A9 for ; Sun, 24 Jan 2021 10:07:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B771C225A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3yw5r31oGZkhuGmfA0GMGbQlRDsLf/cpJ5F7n96Aocg=; b=Yxp8z+OUUu01KRBQDrqyAOuYy 2ZqQGVavSuabjXRccXdKePo5aCu6YPKo3FY2NDtRLd3JdblNbD54V99fLPtA+wL4mjTJB8zPBeyMz wnrwVRMgEsE5KAf/3fToxow2K/cAPmPQYb6KTqGepEBY6JIUij0CTAKgpR/rxb01PlLvNfnQBxSz8 v5wcRPidggPBT9Y4LMl5Mitr0sHQkArutVdttFKvQu01cKQ4Vf1O2irF/n4Pj5MCJ3GmXWddZpoEM XitL5yPNHRG8hkD9b27qvDin3717v/oN4MeY9jHawtYjtl9uHtzGehSN367SfzO77QomX3pZ9sAIW 3phnyY3xw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3cJ0-0007Gk-47; Sun, 24 Jan 2021 10:07:38 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3cIu-0007FX-JJ for linux-nvme@lists.infradead.org; Sun, 24 Jan 2021 10:07:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id D94556736F; Sun, 24 Jan 2021 11:07:24 +0100 (CET) Date: Sun, 24 Jan 2021 11:07:24 +0100 From: Christoph Hellwig To: Damien Le Moal Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit Message-ID: <20210124100724.GA27580@lst.de> References: <20210122080014.174391-1-damien.lemoal@wdc.com> <20210122080014.174391-2-damien.lemoal@wdc.com> <20210122084209.GA15710@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210124_050732_741864_E3662665 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Keith Busch , Chaitanya Kulkarni , "Martin K . Petersen" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Jan 22, 2021 at 08:56:58AM +0000, Damien Le Moal wrote: > > This looks a little strange. If we special case zoned vs not zoned > > here anyway, why not set the zone_write_granularity to the logical > > block size here by default. > > The convention is zone_write_granularity == 0 for the BLK_ZONED_NONE case. Hence > the reset here if we force the zoned model to none for HA drives. This way, this > does not create a special case for HA drives used as regular disks. Just inititialize it for all cases if you initialize it for some here. That way everyone but sd already gets a right default and life becomes simpler. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme