From: Jonathan Cameron <jic23@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Robin van der Gracht <robin@protonic.nl>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: counter: add gpio-pulse-counter binding
Date: Sun, 24 Jan 2021 14:34:04 +0000 [thread overview]
Message-ID: <20210124143404.4a029d62@archlinux> (raw)
In-Reply-To: <20210122112434.27886-2-o.rempel@pengutronix.de>
On Fri, 22 Jan 2021 12:24:33 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Add binding for GPIO based pulse counter node
>
This does make me wonder a bit on whether we are going to soon need
a provider / consumer interface for the counter subsystem.
Afterall, this pulse is coming from something and I doubt it will
be long before we want to describe that 'something' plus it may
have additional controls etc.
Anyhow, that's a question for another day. A few minor things inline.
Jonathan
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> .../bindings/counter/gpio-pulse-counter.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/counter/gpio-pulse-counter.yaml
>
> diff --git a/Documentation/devicetree/bindings/counter/gpio-pulse-counter.yaml b/Documentation/devicetree/bindings/counter/gpio-pulse-counter.yaml
> new file mode 100644
> index 000000000000..dfa93956f15c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/counter/gpio-pulse-counter.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/counter/gpio-pulse-counter.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO base pulse counter
Whilst it's moderately obvious I think a short description here
would be useful.
> +
> +maintainers:
> + - Oleksij Rempel <o.rempel@pengutronix.de>
> +
> +properties:
> + compatible:
> + const: virtual,gpio-pulse-counter
> +
> + gpios:
> + maxItems: 1
> +
> +required:
> + - gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
> + #include <dt-bindings/gpio/gpio.h>
> +
> + counter-0 {
> + compatible = "virtual,gpio-pulse-counter";
> + gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
> + };
> +
> + counter-1 {
> + compatible = "virtual,gpio-pulse-counter";
> + gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
> + };
The second example doesn't tell us anything new, so I'd drop
it and just have counter-0
> +
> +...
next prev parent reply other threads:[~2021-01-24 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 11:24 [PATCH v2 0/2] add support for GPIO based counter Oleksij Rempel
2021-01-22 11:24 ` [PATCH v3 1/2] dt-bindings: counter: add gpio-pulse-counter binding Oleksij Rempel
2021-01-24 14:34 ` Jonathan Cameron [this message]
2021-01-22 11:24 ` [PATCH v3 2/2] counter: add GPIO based pulse counters Oleksij Rempel
2021-01-22 11:50 ` Ahmad Fatoum
2021-01-24 14:47 ` Jonathan Cameron
2021-01-26 8:07 ` Oleksij Rempel
2021-01-31 12:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124143404.4a029d62@archlinux \
--to=jic23@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.