From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE57C433DB for ; Sun, 24 Jan 2021 23:10:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5421622581 for ; Sun, 24 Jan 2021 23:10:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5421622581 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M/lpLYQgPjPiyqbndAN+0W7zEYhfpZ9PKLnXBD/ER60=; b=AqdNxv95pjMWfP78AWsSxCTi7 Kdsz47P/viwsfaYPEIuJ1SdLdljuBtoHMp7wFXGHqLyJFovHZer1iKQH44N1rBHJHShU3oNpYepYP fPRWrd3LcPgOxjHYUZxyTD3xljApH8g+0YBaNu9BT0stPqvju46F1OjTl2GsLNPhk5RCC7pJqNzSV /Qldn80YoJ6UrJLA7WyjR9wK8XcLI/Vbaz/vFRf+Wa7ONG/Ry/ORBZD6rlWqx/7U2i4zHkPpdz7oR s2DYrQWB3CqKSk5Bw4Ny0D42w9qeoRPcxeFamhf5d4EtcpbAzXFpMwOf4jQ3roLZTIYsg4s0rXUdc a9zKU0Q/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3oVE-0006Bl-77; Sun, 24 Jan 2021 23:09:04 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3oVB-0006BQ-3E for linux-arm-kernel@lists.infradead.org; Sun, 24 Jan 2021 23:09:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GqxuVNSCoyNxdMRpwr05hb2sD/RMkygUP+FhBxHIXhc=; b=nbwuqvTQV04RheSmJjc0g3Qv4 hOrdWGd6AqxROy/MvFatvgbJNg8kbMAGnvfXZXNym6Jy9MWbDQdhgIoiSKHgsFh78fK6VLYBuWfWN ZCqk7FZAEsejpDVaUe5/zxzJAjAf2jf8hOpNKR8UGL3/21g9IS4C378vm6UDTb9Eh3qJ9R3EYtdxA GvMT/tLDm2FArIuc62Hql/Sy6XobFsLaAfjCwCwYyr94IId8kesvPgq17kdk7pFK6f2C+frbb4eB1 WZERA8IQHSPegRVanilCvt1WcfBrIern59XBrqtfBIXhhFVV9kK/jFewnwFO82G6+lDRuAo+yrWZP G5ciQiqxw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52298) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3oV7-0002eT-Dl; Sun, 24 Jan 2021 23:08:57 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l3oV7-00026z-3o; Sun, 24 Jan 2021 23:08:57 +0000 Date: Sun, 24 Jan 2021 23:08:57 +0000 From: Russell King - ARM Linux admin To: Ard Biesheuvel Subject: Re: [PATCH] ARM: decompressor: cover BSS in cache clean and reorder with MMU disable on v7 Message-ID: <20210124230856.GC1551@shell.armlinux.org.uk> References: <20210122152012.30075-1-ardb@kernel.org> <20210122161312.GS1551@shell.armlinux.org.uk> <20210124152127.GA1551@shell.armlinux.org.uk> <20210124161831.GB1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210124161831.GB1551@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210124_180901_175727_9EA84AFE X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 24, 2021 at 04:18:31PM +0000, Russell King - ARM Linux admin wrote: > On Sun, Jan 24, 2021 at 04:45:14PM +0100, Ard Biesheuvel wrote: > > So on the basis that this patch adds back a full cache > > clean+invalidate that was inadvertently removed by my previous patch, > > I think we should apply this patch. GIven that this change can be > > traced back to commit 401b368caaecdce1cf8f05bab448172752230cb0, we > > should probably include > > > > Fixes: 401b368caaec ("ARM: decompressor: switch to by-VA cache > > maintenance for v7 cores") > > > > Are you on board with that? > > Yes, I think that's definitely the commit which introduced this bug. BTW, there's no need to submit your patch to the patch system, I obviously already have it in my tree. I'll move it over to the usual "fixes" branch in due course. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel