From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA37C433E0 for ; Sun, 24 Jan 2021 20:52:37 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0EA2522C9F for ; Sun, 24 Jan 2021 20:52:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EA2522C9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 104AE140DB4; Sun, 24 Jan 2021 21:52:18 +0100 (CET) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 09747140DA2 for ; Sun, 24 Jan 2021 21:52:17 +0100 (CET) Received: by mail-lf1-f48.google.com with SMTP id v67so14903284lfa.0 for ; Sun, 24 Jan 2021 12:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ko2dVkjAvZqMFi3/uywms0H3P2KQxZ7D0P8cB9uJ9os=; b=XfzWIk0NhVQuT71mxv5hl41PGcIle3rSbb3JTKOUu4MVED4385S5YVmT8+yMcHgil+ cj8Ni5XeBFbH+3/R6ezrnKm7wlGGqsUTy4JKUSoWImE4Xwc/bERpCpN/MOHjc/mbr1gm no34+WlIdw0mjW9vCamC2kp+gKTgXzVqjfq7HLwvo4wrpEsyN3SDr8ZemBZl8OZWdXRH 7mezRG+cE/uI8AXdVGJWtIW8LR8fQ6pTaPydaaqbif7+tHTeM+GGY9+UVhAFcROIIL4L MBqapmo/qSoevoQ40c+cdfYe326//G7WoFixQ9Aedf14njLt86/hOPTV5bq+8bP5mnxD xaZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ko2dVkjAvZqMFi3/uywms0H3P2KQxZ7D0P8cB9uJ9os=; b=juxoEvA7J/XdJwWqXs9cRXAgtgDPjatPFYCKOe19gOVEKYGjJxTO2afUVgpZm2trLo VMsaiJ3EdyWMuId68WwMUl/RdLJmtvPwT9hxrOGomzjTnp/c9k6idnyeowTfwhrHJE01 U+fQ099herQXTvc+zSuGrPjmimrebgvyBlEcBc/WrVhSdxY+Bm82HAt2eA+PTGsX1X+d xZaJi5+piANpM7N8EFtrIwfcnCclqeiHCISHJGUXKLs71gUlXPGkxyn9V4IdUYY5z3am DgjJayKr5blSRSzNF/H7opFnW1h8K9ZHeQtRlHVf42JZmjH0R4lJNfbcOjtlM9UNiILo EPTA== X-Gm-Message-State: AOAM5328GK1knllPaA/fTxtZqt42eM6lrtrOVRl/pRiV4DslaLwCQmpz 5ZD0QIBgS/YCSuWTWlFiGfU= X-Google-Smtp-Source: ABdhPJzyDly+2rdKSIH+TyoDwE2F8pQjlOJWCU7UQI7G3Ze1LMk0JN3YYdn811/UNXdBc8w9/Cikfw== X-Received: by 2002:a19:f016:: with SMTP id p22mr705319lfc.402.1611521536693; Sun, 24 Jan 2021 12:52:16 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id 195sm1565757lfk.109.2021.01.24.12.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jan 2021 12:52:16 -0800 (PST) Date: Sun, 24 Jan 2021 23:52:15 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com, ray.kinsella@intel.com, mdr@ashroe.eu Message-ID: <20210124235215.73e44a39@sovereign> In-Reply-To: <14261305.cmbqrkYmuW@thomas> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <5444857.Q0qPc8oPp2@thomas> <20210123012403.1bdb35d0@sovereign> <14261305.cmbqrkYmuW@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 23 Jan 2021 12:38:45 +0100, Thomas Monjalon wrote: > 22/01/2021 23:24, Dmitry Kozlyuk: > > On Fri, 22 Jan 2021 21:57:15 +0100, Thomas Monjalon wrote: > > > 22/01/2021 21:31, Dmitry Kozlyuk: > > > > On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > > > > > 20/01/2021 08:23, Dmitry Kozlyuk: > > > > > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > > > > > This is now the right timeframe to introduce this change > > > > > > > with the new Python module dependency. > > > > > > > Unfortunately, the ABI check is returning an issue: > > > > > > > > > > > > > > 'const char mlx5_common_pci_pmd_info[62]' was changed > > > > > > > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c > > > > > > > > > > > > Will investigate and fix ASAP. > > > > > > > > Now that I think of it: strings like this change every time new PCI IDs are > > > > added to a PMD, but AFAIK adding PCI IDs is not considered an ABI breakage, > > > > is it? One example is 28c9a7d7b48e ("net/mlx5: add ConnectX-6 Lx device ID") > > > > added 2020-07-08, i.e. clearly outside of ABI change window. > > > > > > You're right. > > > > > > > "xxx_pmd_info" changes are due to JSON formatting (new is more canonical), > > > > which can be worked around easily, if the above is wrong. > > > > > > If the new format is better, please keep it. > > > What we need is an exception for the pmdinfo symbols > > > in the file devtools/libabigail.abignore. > > > You can probably use a regex for these symbols. > > > > This would allow real breakages to pass ABI check, abidiff doesn't analyze > > variable content and it's not easy to compare. Maybe later a script can be > > added that checks lines with RTE_DEVICE_IN in patches. There are at most 32 of > > 5494 relevant commits between 19.11 and 20.11, though. > > > > To verify there are no meaningful changes I ensured empty diff between > > results of the following command for "main" and the branch: > > > > find build/drivers -name '*.so' -exec usertools/dpdk-pmdinfo.py > > For now we cannot do such check as part of the ABI checker. > And we cannot merge this patch if the ABI check fails. > I think the only solution is to allow any change in the pmdinfo variables. Send v10 with suppression. Such check, however, *can* be implemented: at ABI check stage we have two install directories that dpdk-pmdinfo.py can inspect. Then a script can check that diff contains only additions, i.e. no device support being removed.