All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: kfence: fix header inclusion
@ 2021-01-25 12:50 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-25 12:50 UTC (permalink / raw)
  To: Alexander Potapenko, Marco Elver, Catalin Marinas, Will Deacon,
	Stephen Rothwell, Mike Rapoport, David Hildenbrand, Mark Rutland,
	Andrew Morton, Dmitry Vyukov, Jann Horn
  Cc: Arnd Bergmann, kasan-dev, linux-arm-kernel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Randconfig builds started warning about a missing function declaration
after set_memory_valid() is moved to a new file:

In file included from mm/kfence/core.c:26:
arch/arm64/include/asm/kfence.h:17:2: error: implicit declaration of function 'set_memory_valid' [-Werror,-Wimplicit-function-declaration]

Include the correct header again.

Fixes: 9e18ec3cfabd ("set_memory: allow querying whether set_direct_map_*() is actually enabled")
Fixes: 204555ff8bd6 ("arm64, kfence: enable KFENCE for ARM64")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm64/include/asm/kfence.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/kfence.h b/arch/arm64/include/asm/kfence.h
index d061176d57ea..aa855c6a0ae6 100644
--- a/arch/arm64/include/asm/kfence.h
+++ b/arch/arm64/include/asm/kfence.h
@@ -8,7 +8,7 @@
 #ifndef __ASM_KFENCE_H
 #define __ASM_KFENCE_H
 
-#include <asm/cacheflush.h>
+#include <asm/set_memory.h>
 
 static inline bool arch_kfence_init_pool(void) { return true; }
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] arm64: kfence: fix header inclusion
@ 2021-01-25 12:50 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-25 12:50 UTC (permalink / raw)
  To: Alexander Potapenko, Marco Elver, Catalin Marinas, Will Deacon,
	Stephen Rothwell, Mike Rapoport, David Hildenbrand, Mark Rutland,
	Andrew Morton, Dmitry Vyukov, Jann Horn
  Cc: linux-arm-kernel, kasan-dev, Arnd Bergmann, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Randconfig builds started warning about a missing function declaration
after set_memory_valid() is moved to a new file:

In file included from mm/kfence/core.c:26:
arch/arm64/include/asm/kfence.h:17:2: error: implicit declaration of function 'set_memory_valid' [-Werror,-Wimplicit-function-declaration]

Include the correct header again.

Fixes: 9e18ec3cfabd ("set_memory: allow querying whether set_direct_map_*() is actually enabled")
Fixes: 204555ff8bd6 ("arm64, kfence: enable KFENCE for ARM64")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm64/include/asm/kfence.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/kfence.h b/arch/arm64/include/asm/kfence.h
index d061176d57ea..aa855c6a0ae6 100644
--- a/arch/arm64/include/asm/kfence.h
+++ b/arch/arm64/include/asm/kfence.h
@@ -8,7 +8,7 @@
 #ifndef __ASM_KFENCE_H
 #define __ASM_KFENCE_H
 
-#include <asm/cacheflush.h>
+#include <asm/set_memory.h>
 
 static inline bool arch_kfence_init_pool(void) { return true; }
 
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: kfence: fix header inclusion
  2021-01-25 12:50 ` Arnd Bergmann
@ 2021-01-25 18:46   ` Catalin Marinas
  -1 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-01-25 18:46 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Alexander Potapenko, Marco Elver, Will Deacon, Stephen Rothwell,
	Mike Rapoport, David Hildenbrand, Mark Rutland, Andrew Morton,
	Dmitry Vyukov, Jann Horn, Arnd Bergmann, kasan-dev,
	linux-arm-kernel, linux-kernel

On Mon, Jan 25, 2021 at 01:50:20PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Randconfig builds started warning about a missing function declaration
> after set_memory_valid() is moved to a new file:
> 
> In file included from mm/kfence/core.c:26:
> arch/arm64/include/asm/kfence.h:17:2: error: implicit declaration of function 'set_memory_valid' [-Werror,-Wimplicit-function-declaration]
> 
> Include the correct header again.
> 
> Fixes: 9e18ec3cfabd ("set_memory: allow querying whether set_direct_map_*() is actually enabled")
> Fixes: 204555ff8bd6 ("arm64, kfence: enable KFENCE for ARM64")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

(it should go via the mm tree with the other kfence patches)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: kfence: fix header inclusion
@ 2021-01-25 18:46   ` Catalin Marinas
  0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2021-01-25 18:46 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mark Rutland, Stephen Rothwell, Marco Elver, Arnd Bergmann,
	David Hildenbrand, Jann Horn, linux-kernel, kasan-dev,
	Alexander Potapenko, Dmitry Vyukov, Andrew Morton, Will Deacon,
	Mike Rapoport, linux-arm-kernel

On Mon, Jan 25, 2021 at 01:50:20PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Randconfig builds started warning about a missing function declaration
> after set_memory_valid() is moved to a new file:
> 
> In file included from mm/kfence/core.c:26:
> arch/arm64/include/asm/kfence.h:17:2: error: implicit declaration of function 'set_memory_valid' [-Werror,-Wimplicit-function-declaration]
> 
> Include the correct header again.
> 
> Fixes: 9e18ec3cfabd ("set_memory: allow querying whether set_direct_map_*() is actually enabled")
> Fixes: 204555ff8bd6 ("arm64, kfence: enable KFENCE for ARM64")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

(it should go via the mm tree with the other kfence patches)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-26  9:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 12:50 [PATCH] arm64: kfence: fix header inclusion Arnd Bergmann
2021-01-25 12:50 ` Arnd Bergmann
2021-01-25 18:46 ` Catalin Marinas
2021-01-25 18:46   ` Catalin Marinas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.