All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Jonas <mark.jonas@de.bosch.com>
To: Support Opensource <support.opensource@diasemi.com>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<Adam.Thomson.Opensource@diasemi.com>,
	<stwiss.opensource@diasemi.com>, <marek.vasut@gmail.com>,
	<tingquan.ruan@cn.bosch.com>, <hubert.streidl@de.bosch.com>,
	Mark Jonas <mark.jonas@de.bosch.com>
Subject: [PATCH 0/1] mfd: da9063: Support SMBus and I2C mode
Date: Mon, 25 Jan 2021 13:54:57 +0100	[thread overview]
Message-ID: <20210125125458.1302525-1-mark.jonas@de.bosch.com> (raw)

On an NXP i.MX6 Solo processor we are running an application which makes
use of real-time threads (SCHED_RR). In combination with a DA9063 we
experienced (rare) random shut-downs and reboots. We found that the
issue was caused by a combination of the (default) DA9063 SMBus mode
and non-atomic I2C transactions of the i.MX6 I2C driver. Because a
transaction could be idle for longer than the SMBus clock time-out due
to a real-time thread the DA9063 would time-out and receive the second
half of the transaction as an unintended message.

The solution we are giving to review in this patch is to allow using the
I2C mode of the DA9063. We kindly ask for feedback and eventually hope
for an integration to the mainline.

Because we are on a vendor kernel we were not able to test this patch
on the current mainline kernel. Though, we tested a (very similar) patch
on our (close to mainline) Linux 4.14 and 5.4 vendor kernels.

Hubert Streidl (1):
  mfd: da9063: Support SMBus and I2C mode

 Documentation/devicetree/bindings/mfd/da9063.txt |  7 +++++++
 drivers/mfd/da9063-core.c                        |  9 +++++++++
 drivers/mfd/da9063-i2c.c                         | 13 +++++++++++++
 include/linux/mfd/da9063/core.h                  |  1 +
 include/linux/mfd/da9063/registers.h             |  3 +++
 5 files changed, 33 insertions(+)

-- 
2.25.1


             reply	other threads:[~2021-01-26  6:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 12:54 Mark Jonas [this message]
2021-01-25 12:54 ` [PATCH 1/1] mfd: da9063: Support SMBus and I2C mode Mark Jonas
2021-01-25 18:49   ` Jonas Mark (BT-FIR/ENG1-Grb)
2021-01-25 18:58   ` Mark Jonas
2021-01-26  8:23     ` Lee Jones
2021-01-28 14:50   ` Adam Thomson
2021-01-28 16:09     ` AW: " Jonas Mark (BT-FIR/ENG1-Grb)
2021-01-28 20:53       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125125458.1302525-1-mark.jonas@de.bosch.com \
    --to=mark.jonas@de.bosch.com \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hubert.streidl@de.bosch.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=stwiss.opensource@diasemi.com \
    --cc=support.opensource@diasemi.com \
    --cc=tingquan.ruan@cn.bosch.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.