All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	kernel@collabora.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Jacopo Mondi <jacopo@jmondi.org>,
	niklas.soderlund+renesas@ragnatech.se,
	Helen Koike <helen.koike@collabora.com>,
	Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Hugues Fruchet <hugues.fruchet@st.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Yong Zhi <yong.zhi@intel.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Maxime Ripard <mripard@kernel.org>,
	Robert Foss <robert.foss@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v3 11/14] media: v4l2-async: Fix incorrect comment
Date: Mon, 25 Jan 2021 15:22:27 +0200	[thread overview]
Message-ID: <20210125132230.6600-26-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20210125132230.6600-1-sakari.ailus@linux.intel.com>

From: Ezequiel Garcia <ezequiel@collabora.com>

The v4l2_async_notifier_cleanup() documentation mentions
v4l2_fwnode_reference_parse_sensor_common, which was actually
introduced as v4l2_async_notifier_parse_fwnode_sensor_common(),
in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for
parsing common external refs").

The function drivers do use is
v4l2_async_register_subdev_sensor_common().

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 include/media/v4l2-async.h | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
index 0ddc06e36c08..f2cac0931372 100644
--- a/include/media/v4l2-async.h
+++ b/include/media/v4l2-async.h
@@ -174,9 +174,11 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier,
  *
  * @notif: pointer to &struct v4l2_async_notifier
  * @endpoint: local endpoint pointing to the remote sub-device to be matched
- * @asd: Async sub-device struct allocated by the caller. The &struct
- *	 v4l2_async_subdev shall be the first member of the driver's async
- *	 sub-device struct, i.e. both begin at the same memory address.
+ * @asd_struct_size: size of the driver's async sub-device struct, including
+ *		     sizeof(struct v4l2_async_subdev). The &struct
+ *		     v4l2_async_subdev shall be the first member of
+ *		     the driver's async sub-device struct, i.e. both
+ *		     begin at the same memory address.
  *
  * Gets the remote endpoint of a given local endpoint, set it up for fwnode
  * matching and adds the async sub-device to the notifier's @asd_list. The
@@ -184,13 +186,12 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier,
  * notifier cleanup time.
  *
  * This is just like @v4l2_async_notifier_add_fwnode_subdev, but with the
- * exception that the fwnode refers to a local endpoint, not the remote one, and
- * the function relies on the caller to allocate the async sub-device struct.
+ * exception that the fwnode refers to a local endpoint, not the remote one.
  */
-int
+struct v4l2_async_subdev *
 v4l2_async_notifier_add_fwnode_remote_subdev(struct v4l2_async_notifier *notif,
 					     struct fwnode_handle *endpoint,
-					     struct v4l2_async_subdev *asd);
+					     unsigned int asd_struct_size);
 
 /**
  * v4l2_async_notifier_add_i2c_subdev - Allocate and add an i2c async
@@ -249,7 +250,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier);
  * notifier after calling
  * @v4l2_async_notifier_add_subdev,
  * @v4l2_async_notifier_parse_fwnode_endpoints or
- * @v4l2_fwnode_reference_parse_sensor_common.
+ * @v4l2_async_register_subdev_sensor_common.
  *
  * There is no harm from calling v4l2_async_notifier_cleanup in other
  * cases as long as its memory has been zeroed after it has been
-- 
2.29.2


  parent reply	other threads:[~2021-01-26 19:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 13:22 [PATCH 01/14] media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdev Sakari Ailus
2021-01-25 13:22 ` [PATCH 02/14] media: atmel: Use v4l2_async_notifier_add_fwnode_remote_subdev Sakari Ailus
2021-01-25 13:22 ` [PATCH 03/14] media: stm32: " Sakari Ailus
2021-01-25 13:22 ` [PATCH 04/14] media: exynos4-is: " Sakari Ailus
2021-01-25 13:22 ` [PATCH 05/14] media: st-mipid02: " Sakari Ailus
2021-01-25 13:22 ` [PATCH 06/14] media: cadence: " Sakari Ailus
2021-01-25 13:22 ` [PATCH 07/14] media: marvell-ccic: Use v4l2_async_notifier_add_*_subdev Sakari Ailus
2021-01-25 13:59   ` Sakari Ailus
2021-01-25 13:22 ` [PATCH 08/14] media: renesas-ceu: " Sakari Ailus
2021-01-25 13:22 ` [PATCH 09/14] media: pxa-camera: " Sakari Ailus
2021-01-25 13:22 ` [PATCH 10/14] media: davinci: vpif_display: Remove unused v4l2-async code Sakari Ailus
2021-01-25 13:22 ` [PATCH 11/14] media: v4l2-async: Fix incorrect comment Sakari Ailus
2021-01-25 13:22 ` [PATCH 12/14] media: Clarify v4l2-async subdevice addition API Sakari Ailus
2021-01-25 13:22 ` [PATCH 13/14] media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdev Sakari Ailus
2021-01-25 13:22 ` [PATCH 14/14] media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 00/14] V4L2 Async notifier API cleanup Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 01/14] media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdev Sakari Ailus
2021-01-25 15:27   ` Helen Koike
2021-01-25 16:16     ` Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 02/14] media: atmel: Use v4l2_async_notifier_add_fwnode_remote_subdev Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 03/14] media: stm32: " Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 04/14] media: exynos4-is: " Sakari Ailus
2021-01-25 17:22   ` Helen Koike
2021-01-25 13:22 ` [PATCH v3 05/14] media: st-mipid02: " Sakari Ailus
2021-01-25 17:22   ` Helen Koike
2021-01-25 13:22 ` [PATCH v3 06/14] media: cadence: " Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 07/14] media: marvell-ccic: Use v4l2_async_notifier_add_*_subdev Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 08/14] media: renesas-ceu: " Sakari Ailus
2021-01-25 16:50   ` Helen Koike
2021-01-25 20:43     ` Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 09/14] media: pxa-camera: " Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 10/14] media: davinci: vpif_display: Remove unused v4l2-async code Sakari Ailus
2021-01-25 13:22 ` Sakari Ailus [this message]
2021-01-25 16:50   ` [PATCH v3 11/14] media: v4l2-async: Fix incorrect comment Helen Koike
2021-01-25 20:43     ` Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 12/14] media: Clarify v4l2-async subdevice addition API Sakari Ailus
2021-01-25 17:22   ` Helen Koike
2021-01-25 20:42     ` Sakari Ailus
2021-01-25 13:22 ` [PATCH v3 13/14] media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdev Sakari Ailus
2021-01-25 17:22   ` Helen Koike
2021-01-25 13:22 ` [PATCH v3 14/14] media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125132230.6600-26-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=helen.koike@collabora.com \
    --cc=hugues.fruchet@st.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=kernel@collabora.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=robert.foss@linaro.org \
    --cc=s.nawrocki@samsung.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.