All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Cc: netdev@vger.kernel.org, jiri@nvidia.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action
Date: Mon, 25 Jan 2021 13:23:17 -0800	[thread overview]
Message-ID: <20210125132317.418a4e35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210125123856.1746-1-oleksandr.mazur@plvision.eu>

On Mon, 25 Jan 2021 14:38:56 +0200 Oleksandr Mazur wrote:
> +	if (trap_item->action == DEVLINK_TRAP_ACTION_DROP &&
> +	    devlink->ops->trap_drop_counter_get) {
> +		err = devlink->ops->trap_drop_counter_get(devlink,
> +							  trap_item->trap,
> +							  &drops);
> +		if (err)
> +			return err;
> +	}

Why only report this counter when action is set to drop?

Thinking about it again - if the action can be changed wouldn't it 
be best for the user to actually get a "HW condition hit" counter,
which would increment regardless of SW config (incl. policers)?

Otherwise if admin logs onto the box and temporarily enables a trap 
for debug this count would disappear.

  reply	other threads:[~2021-01-25 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 12:38 [RFC v3 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action Oleksandr Mazur
2021-01-25 21:23 ` Jakub Kicinski [this message]
2021-01-26 10:10   ` Oleksandr Mazur
     [not found]   ` <AM0P190MB0738FC4657CCB0E435C40B24E4B99@AM0P190MB0738.EURP190.PROD.OUTLOOK.COM>
2021-01-29 19:19     ` Jakub Kicinski
2021-02-01 14:54       ` Oleksandr Mazur
2021-02-01 19:08 ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125132317.418a4e35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jiri@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr.mazur@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.