All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Marco Elver <elver@google.com>
Cc: Anders Roxell <anders.roxell@linaro.org>,
	glider@google.com, dvyukov@google.com, catalin.marinas@arm.com,
	will@kernel.org, kasan-dev@googlegroups.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, rppt@kernel.org, david@redhat.com
Subject: Re: [PATCH] kfence: fix implicit function declaration
Date: Mon, 25 Jan 2021 14:45:36 -0800	[thread overview]
Message-ID: <20210125144536.4544d9fca3b4cda8a6e42517@linux-foundation.org> (raw)
In-Reply-To: <X8otwahnmGQGLpge@elver.google.com>

On Fri, 4 Dec 2020 13:38:25 +0100 Marco Elver <elver@google.com> wrote:

> On Fri, Dec 04, 2020 at 01:18PM +0100, Anders Roxell wrote:
> > When building kfence the following error shows up:
> > 
> > In file included from mm/kfence/report.c:13:
> > arch/arm64/include/asm/kfence.h: In function ‘kfence_protect_page’:
> > arch/arm64/include/asm/kfence.h:12:2: error: implicit declaration of function ‘set_memory_valid’ [-Werror=implicit-function-declaration]
> >    12 |  set_memory_valid(addr, 1, !protect);
> >       |  ^~~~~~~~~~~~~~~~
> > 
> > Use the correct include both
> > f2b7c491916d ("set_memory: allow querying whether set_direct_map_*() is actually enabled")
> > and 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64") went in the
> 
> Note that -mm does not have stable commit hashes.
> 
> > same day via different trees.
> > 
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> 
> Ack, we need this patch somewhere but we should probably fix the patch
> that does the move, otherwise we'll have a build-broken kernel still.
> 
> > I got this build error in todays next-20201204.
> > Andrew, since both patches are in your -mm tree, I think this can be
> > folded into 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64")
> 
> I don't think that's the right way around. This would result in a
> build-broken commit point as well.
> 
> Looking at current -next, I see that "set_memory: allow querying whether
> set_direct_map_*() is actually enabled" is after "arm64, kfence: enable
> KFENCE for ARM64".
> 
> I think the patch that introduces set_memory.h for arm64 simply needs to
> squash in this patch (assuming the order is retained as-is in -mm).
> 

OK, I requeued this patch as
set_memory-allow-querying-whether-set_direct_map_-is-actually-enabled-fix.patch, part of Mike's secretmem patch series.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Marco Elver <elver@google.com>
Cc: Anders Roxell <anders.roxell@linaro.org>,
	david@redhat.com, catalin.marinas@arm.com,
	linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	glider@google.com, linux-arm-kernel@lists.infradead.org,
	rppt@kernel.org, will@kernel.org, dvyukov@google.com
Subject: Re: [PATCH] kfence: fix implicit function declaration
Date: Mon, 25 Jan 2021 14:45:36 -0800	[thread overview]
Message-ID: <20210125144536.4544d9fca3b4cda8a6e42517@linux-foundation.org> (raw)
In-Reply-To: <X8otwahnmGQGLpge@elver.google.com>

On Fri, 4 Dec 2020 13:38:25 +0100 Marco Elver <elver@google.com> wrote:

> On Fri, Dec 04, 2020 at 01:18PM +0100, Anders Roxell wrote:
> > When building kfence the following error shows up:
> > 
> > In file included from mm/kfence/report.c:13:
> > arch/arm64/include/asm/kfence.h: In function ‘kfence_protect_page’:
> > arch/arm64/include/asm/kfence.h:12:2: error: implicit declaration of function ‘set_memory_valid’ [-Werror=implicit-function-declaration]
> >    12 |  set_memory_valid(addr, 1, !protect);
> >       |  ^~~~~~~~~~~~~~~~
> > 
> > Use the correct include both
> > f2b7c491916d ("set_memory: allow querying whether set_direct_map_*() is actually enabled")
> > and 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64") went in the
> 
> Note that -mm does not have stable commit hashes.
> 
> > same day via different trees.
> > 
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> 
> Ack, we need this patch somewhere but we should probably fix the patch
> that does the move, otherwise we'll have a build-broken kernel still.
> 
> > I got this build error in todays next-20201204.
> > Andrew, since both patches are in your -mm tree, I think this can be
> > folded into 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64")
> 
> I don't think that's the right way around. This would result in a
> build-broken commit point as well.
> 
> Looking at current -next, I see that "set_memory: allow querying whether
> set_direct_map_*() is actually enabled" is after "arm64, kfence: enable
> KFENCE for ARM64".
> 
> I think the patch that introduces set_memory.h for arm64 simply needs to
> squash in this patch (assuming the order is retained as-is in -mm).
> 

OK, I requeued this patch as
set_memory-allow-querying-whether-set_direct_map_-is-actually-enabled-fix.patch, part of Mike's secretmem patch series.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-25 22:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 12:18 [PATCH] kfence: fix implicit function declaration Anders Roxell
2020-12-04 12:18 ` Anders Roxell
2020-12-04 12:29 ` Alexander Potapenko
2020-12-04 12:29   ` Alexander Potapenko
2020-12-04 12:38 ` Marco Elver
2020-12-04 12:38   ` Marco Elver
2021-01-25 22:45   ` Andrew Morton [this message]
2021-01-25 22:45     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125144536.4544d9fca3b4cda8a6e42517@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=anders.roxell@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.