From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pratyush Yadav Date: Mon, 25 Jan 2021 22:23:47 +0530 Subject: [PATCH 02/11] pinctrl: single: fix the loop counter variable type In-Reply-To: <20210123182711.7177-3-dariobin@libero.it> References: <20210123182711.7177-1-dariobin@libero.it> <20210123182711.7177-3-dariobin@libero.it> Message-ID: <20210125165345.dfmjijfmiukdn4i4@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dario, On 23/01/21 07:27PM, Dario Binacchi wrote: > The patch changes the variable 'n' type from phys_addr_t to int. This information can very easily be obtained by reading the diff. The commit message should also explain _why_ the change is made. For example here it would be a good idea to add something like: n is used as a loop counter, not as a physical address, and is used in a comparison with an int. So it makes sense to set its type to int. Other than that, Reviewed-by: Pratyush Yadav > Signed-off-by: Dario Binacchi > --- > > drivers/pinctrl/pinctrl-single.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index c9a6c272bf..49ed15211d 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -75,8 +75,8 @@ static int single_configure_pins(struct udevice *dev, > int size) > { > struct single_pdata *pdata = dev_get_plat(dev); > - int count = size / sizeof(struct single_fdt_pin_cfg); > - phys_addr_t n, reg; > + int n, count = size / sizeof(struct single_fdt_pin_cfg); > + phys_addr_t reg; > u32 val; > > for (n = 0; n < count; n++, pins++) { > @@ -109,8 +109,8 @@ static int single_configure_bits(struct udevice *dev, > int size) > { > struct single_pdata *pdata = dev_get_plat(dev); > - int count = size / sizeof(struct single_fdt_bits_cfg); > - phys_addr_t n, reg; > + int n, count = size / sizeof(struct single_fdt_bits_cfg); > + phys_addr_t reg; > u32 val, mask; > > for (n = 0; n < count; n++, pins++) { > -- > 2.17.1 > -- Regards, Pratyush Yadav Texas Instruments India