From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736F0C433E0 for ; Tue, 26 Jan 2021 08:19:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 249CB20717 for ; Tue, 26 Jan 2021 08:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729114AbhAZITG (ORCPT ); Tue, 26 Jan 2021 03:19:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbhAYSlg (ORCPT ); Mon, 25 Jan 2021 13:41:36 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F0EC0613ED for ; Mon, 25 Jan 2021 10:40:00 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id i63so8902216pfg.7 for ; Mon, 25 Jan 2021 10:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=810IMXBV1/7mh3IkPVy/heX6P4WxI70MgM5s4wu77lk=; b=u4B/C7BEtW7GmGqfQghiovSJn8gO99Pb5HExxzSjMZqc8cbA0s/22qK3vj85LwJ0wg PHxgfkU6fg1Y0GKPRujmkXWB00lGaqM0mn34g8DjKHj/NhbH76rs2qvDBbU1w4nZuRpU +3YX+gC7rUamoxyK8ByJtLqNZutVJkMyfUJpXdUsw7ujcfDCpPJsagf5gq3UJQX/Z375 heG7MTIvnaQvLNtg50+1k1agjJD56f8bDYxVVLhUxpCQdK5MxVMCHpLeilveMyn5YRVV 9OkRrDjn5Vtg9ucs65M7Vk56qf5RJsbAa5n45ocKZuGFsrX+PbA3cVDupA10Rm6ECXdk crcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=810IMXBV1/7mh3IkPVy/heX6P4WxI70MgM5s4wu77lk=; b=RX88WUcpywilaWSxmlVYzHtdGnkuFojs0cml7yyt9chjg6cl1ZPqM5BAnDTI0T1DTX SydqmEBJqxxcmYCtmMwoZAJ3CO8frrOWBjE/AQ//MuYc/o7TtuzDX7tV9RLuQ1v0BF9Z QVJZPv218//1d7Zhhiw3rDpfn7FeH1P2o28wdMKDAlJSUdYyM+PHx1pcooXUW3tRRleX xk7LD4h0kNejTEQ0IDEYhZA/nGHKQCNTnS8Z5ZwQRtyFpSJNQkcQcLsTWrEqIZWLCQ// pegydpn8FGUukYuEBSVBZyXiM+j/4LksT4I2V3zfyZlbeibGhMsyngfwdWphqr0bHxlA d6fQ== X-Gm-Message-State: AOAM533Y7N1hitv7dw6iS4nph1NVx6CLLNxdT1pOmcGdi+4O4nAiWERi WE0WLZgg5+a/MhPpH7x+9b4PeQ== X-Google-Smtp-Source: ABdhPJxajfRLmXuLMz8O2NxSLlOGCAw1FB3G6FN+5k8IuapA0+LLhqa+zHE51dDR6HVowNwr4seRrw== X-Received: by 2002:a63:dc06:: with SMTP id s6mr1873867pgg.358.1611599999924; Mon, 25 Jan 2021 10:39:59 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id h23sm5023016pgh.64.2021.01.25.10.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 10:39:59 -0800 (PST) Date: Mon, 25 Jan 2021 11:39:57 -0700 From: Mathieu Poirier To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, anshuman.khandual@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org, jonathan.zhouwen@huawei.com, catalin.marinas@arm.com, Sai Prakash Ranjan , Tingwei Zhang Subject: Re: [PATCH v7 02/28] coresight: etm4x: Skip accessing TRCPDCR in save/restore Message-ID: <20210125183957.GA894394@xps15> References: <20210110224850.1880240-1-suzuki.poulose@arm.com> <20210110224850.1880240-3-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210110224850.1880240-3-suzuki.poulose@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2021 at 10:48:24PM +0000, Suzuki K Poulose wrote: > When the ETM is affected by Qualcomm errata, modifying the > TRCPDCR could cause the system hang. Even though this is > taken care of during enable/disable ETM, the ETM state > save/restore could still access the TRCPDCR. Make sure > we skip the access during the save/restore. > > Found by code inspection. > > Fixes: 02510a5aa78df45 ("coresight: etm4x: Add support to skip trace unit power up") The SHA1 should be 12 character long, something I commented on in V4. I fixed it. > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Sai Prakash Ranjan > Cc: Tingwei Zhang > Reviewed-by: Sai Prakash Ranjan > Tested-by: Sai Prakash Ranjan > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index 76526679b998..cce65fc0c9aa 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -1373,7 +1373,8 @@ static int etm4_cpu_save(struct etmv4_drvdata *drvdata) > > state->trcclaimset = readl(drvdata->base + TRCCLAIMCLR); > > - state->trcpdcr = readl(drvdata->base + TRCPDCR); > + if (!drvdata->skip_power_up) > + state->trcpdcr = readl(drvdata->base + TRCPDCR); > > /* wait for TRCSTATR.IDLE to go up */ > if (coresight_timeout(drvdata->base, TRCSTATR, TRCSTATR_IDLE_BIT, 1)) { > @@ -1391,9 +1392,9 @@ static int etm4_cpu_save(struct etmv4_drvdata *drvdata) > * potentially save power on systems that respect the TRCPDCR_PU > * despite requesting software to save/restore state. > */ > - writel_relaxed((state->trcpdcr & ~TRCPDCR_PU), > - drvdata->base + TRCPDCR); > - > + if (!drvdata->skip_power_up) > + writel_relaxed((state->trcpdcr & ~TRCPDCR_PU), > + drvdata->base + TRCPDCR); > out: > CS_LOCK(drvdata->base); > return ret; > @@ -1488,7 +1489,8 @@ static void etm4_cpu_restore(struct etmv4_drvdata *drvdata) > > writel_relaxed(state->trcclaimset, drvdata->base + TRCCLAIMSET); > > - writel_relaxed(state->trcpdcr, drvdata->base + TRCPDCR); > + if (!drvdata->skip_power_up) > + writel_relaxed(state->trcpdcr, drvdata->base + TRCPDCR); > > drvdata->state_needs_restore = false; > > -- > 2.24.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBEECC433E0 for ; Mon, 25 Jan 2021 18:42:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A06EA207B3 for ; Mon, 25 Jan 2021 18:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A06EA207B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vADATqwgmsQ7NRAPR7ZQE3qAybQ5yKeCn1OiM/qucQ8=; b=iDfo3rKULuOAeIIuHBVtat4rv mfy0g2oPo3plrj4ncEi/b0W5GtjFal8g4NzwY1Kr6PAbHlepmXMgVKpGuKFFkEWHlOKgvJ+2hgXOw vcFV/izFROJ+/wG8QLk7QIjaicLNVjhT2bWTy8WXEux6xvo1pHrOZzeiFbtw1cisliJSmOC4k+ZFu t0R33+LjzW0hNhLUDHKoxl/H7oj0SZYmS2c7ltbJU2lws/RHhCDPYL2fd8aFCczowNl8MORsLl4wi jP/FAYdlraYGgBdZ8Qz7JkDz4JIwzijcnvkUvZ+lAOb7DTDwXh2scyYOIS5uBu+kzLYd+a+fxejSV oC5qY4/eg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l46mW-0007Uq-Vv; Mon, 25 Jan 2021 18:40:09 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l46mS-0007Rc-4u for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 18:40:05 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 30so9518797pgr.6 for ; Mon, 25 Jan 2021 10:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=810IMXBV1/7mh3IkPVy/heX6P4WxI70MgM5s4wu77lk=; b=u4B/C7BEtW7GmGqfQghiovSJn8gO99Pb5HExxzSjMZqc8cbA0s/22qK3vj85LwJ0wg PHxgfkU6fg1Y0GKPRujmkXWB00lGaqM0mn34g8DjKHj/NhbH76rs2qvDBbU1w4nZuRpU +3YX+gC7rUamoxyK8ByJtLqNZutVJkMyfUJpXdUsw7ujcfDCpPJsagf5gq3UJQX/Z375 heG7MTIvnaQvLNtg50+1k1agjJD56f8bDYxVVLhUxpCQdK5MxVMCHpLeilveMyn5YRVV 9OkRrDjn5Vtg9ucs65M7Vk56qf5RJsbAa5n45ocKZuGFsrX+PbA3cVDupA10Rm6ECXdk crcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=810IMXBV1/7mh3IkPVy/heX6P4WxI70MgM5s4wu77lk=; b=kt4NnIDG4C7zYeQZ9ixwfLWMVzqSLzS15DRbeD6WowH9/DZXP62eYHToJqhq3XVFcc ju1JUACVOwMNKiqztVchwZ2kkNIyHUaogAOKsCXT0Qb7r5/0Hb+vfOloukCxv8OgrXyP +cxRPalbyuSxE6QuFV58raLJ8BfD73llyeWjGG8iUdd3mAXFHgjvucesmQyn/TB+B0k5 tchumCAAHX2uOA3KSy6o59xN5VDi53GHPUykf0ExoKr2DQCrGp1KiDXOf0EFAuzVGZMj Cm1cOah8UI+8cVtgPVKAtYneruXZke3GRhRkYtXY1BOi5J+SwlTtIsCrmIFTmOqhU0oP fF2A== X-Gm-Message-State: AOAM531WN2QLx/5eL1Ssmg37REyJfBik5KsYvZ4OaYtT73PGRr4n077t /PNR/Js75CuSlYcbWGuHLYDb7g== X-Google-Smtp-Source: ABdhPJxajfRLmXuLMz8O2NxSLlOGCAw1FB3G6FN+5k8IuapA0+LLhqa+zHE51dDR6HVowNwr4seRrw== X-Received: by 2002:a63:dc06:: with SMTP id s6mr1873867pgg.358.1611599999924; Mon, 25 Jan 2021 10:39:59 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id h23sm5023016pgh.64.2021.01.25.10.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 10:39:59 -0800 (PST) Date: Mon, 25 Jan 2021 11:39:57 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v7 02/28] coresight: etm4x: Skip accessing TRCPDCR in save/restore Message-ID: <20210125183957.GA894394@xps15> References: <20210110224850.1880240-1-suzuki.poulose@arm.com> <20210110224850.1880240-3-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210110224850.1880240-3-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_134004_523761_CD345923 X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Prakash Ranjan , anshuman.khandual@arm.com, catalin.marinas@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, jonathan.zhouwen@huawei.com, Tingwei Zhang , leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 10, 2021 at 10:48:24PM +0000, Suzuki K Poulose wrote: > When the ETM is affected by Qualcomm errata, modifying the > TRCPDCR could cause the system hang. Even though this is > taken care of during enable/disable ETM, the ETM state > save/restore could still access the TRCPDCR. Make sure > we skip the access during the save/restore. > > Found by code inspection. > > Fixes: 02510a5aa78df45 ("coresight: etm4x: Add support to skip trace unit power up") The SHA1 should be 12 character long, something I commented on in V4. I fixed it. > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Sai Prakash Ranjan > Cc: Tingwei Zhang > Reviewed-by: Sai Prakash Ranjan > Tested-by: Sai Prakash Ranjan > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index 76526679b998..cce65fc0c9aa 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -1373,7 +1373,8 @@ static int etm4_cpu_save(struct etmv4_drvdata *drvdata) > > state->trcclaimset = readl(drvdata->base + TRCCLAIMCLR); > > - state->trcpdcr = readl(drvdata->base + TRCPDCR); > + if (!drvdata->skip_power_up) > + state->trcpdcr = readl(drvdata->base + TRCPDCR); > > /* wait for TRCSTATR.IDLE to go up */ > if (coresight_timeout(drvdata->base, TRCSTATR, TRCSTATR_IDLE_BIT, 1)) { > @@ -1391,9 +1392,9 @@ static int etm4_cpu_save(struct etmv4_drvdata *drvdata) > * potentially save power on systems that respect the TRCPDCR_PU > * despite requesting software to save/restore state. > */ > - writel_relaxed((state->trcpdcr & ~TRCPDCR_PU), > - drvdata->base + TRCPDCR); > - > + if (!drvdata->skip_power_up) > + writel_relaxed((state->trcpdcr & ~TRCPDCR_PU), > + drvdata->base + TRCPDCR); > out: > CS_LOCK(drvdata->base); > return ret; > @@ -1488,7 +1489,8 @@ static void etm4_cpu_restore(struct etmv4_drvdata *drvdata) > > writel_relaxed(state->trcclaimset, drvdata->base + TRCCLAIMSET); > > - writel_relaxed(state->trcpdcr, drvdata->base + TRCPDCR); > + if (!drvdata->skip_power_up) > + writel_relaxed(state->trcpdcr, drvdata->base + TRCPDCR); > > drvdata->state_needs_restore = false; > > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel