From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B359C433E0 for ; Mon, 25 Jan 2021 19:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3601822525 for ; Mon, 25 Jan 2021 19:46:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731704AbhAYTpt (ORCPT ); Mon, 25 Jan 2021 14:45:49 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:45955 "EHLO mail-oi1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731797AbhAYTXl (ORCPT ); Mon, 25 Jan 2021 14:23:41 -0500 Received: by mail-oi1-f180.google.com with SMTP id g69so15181527oib.12; Mon, 25 Jan 2021 11:23:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lJBccorxZ78ZbWSXWYq+VpysyyXbwoSq8AT6JmLKs/w=; b=GFELKUEChVrsjtnBz2LirVUz/Ob+11YPypwjNg0g5eB8DxafYEBxa6nExHwsPEtPTs 76VCu/l41kzekz+/6pF2EPpF1a4l8j0LTI+Wo3dJgC6QWPbTpYDn2yJw4Ys1LJpgPNyl GNARdRcyMmboY+/D7T3Yuos2PACGX4+RrgIIYN+h98ZbLto2VfUhS0ihEvqlZemJM6CS f0S8sOR6PT9pSndk+8Iz68zygBwCS39zmspEU0FzQWOgxwiP/BQ/9+efY8fJfOT2VdcG FEM7LEQReSm02THXFSVTM4lD4xgcbmmnac4Zd2ZJAiqaiddzBX4Mj9gXzQGGit2JF/vz lunA== X-Gm-Message-State: AOAM533AvX4mb45rZ5WlyjagPsJQhUEl9P5Ye3xLrfRPZobC9vPp80Eh 3isL0HxC3YY2G2fF+BVlow== X-Google-Smtp-Source: ABdhPJw8oBDePZvFx7h28Zdqx/oSirBM5F51dv0HF/xFXU2wHZkKa9wVzcmO8UDMhbR280BUU3EEBQ== X-Received: by 2002:aca:eb49:: with SMTP id j70mr1063871oih.90.1611602574947; Mon, 25 Jan 2021 11:22:54 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d127sm3363294oob.14.2021.01.25.11.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 11:22:53 -0800 (PST) Received: (nullmailer pid 805318 invoked by uid 1000); Mon, 25 Jan 2021 19:22:53 -0000 Date: Mon, 25 Jan 2021 13:22:53 -0600 From: Rob Herring To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Linu Cherian , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH V2 06/11] dts: bindings: Document device tree bindings for ETE Message-ID: <20210125192253.GA791043@robh.at.kernel.org> References: <1610511498-4058-1-git-send-email-anshuman.khandual@arm.com> <1610511498-4058-7-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610511498-4058-7-git-send-email-anshuman.khandual@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 09:48:13AM +0530, Anshuman Khandual wrote: > From: Suzuki K Poulose > > Document the device tree bindings for Embedded Trace Extensions. > ETE can be connected to legacy coresight components and thus > could optionally contain a connection graph as described by > the CoreSight bindings. > > Cc: devicetree@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Rob Herring > Signed-off-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > --- > Documentation/devicetree/bindings/arm/ete.yaml | 71 ++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ete.yaml > > diff --git a/Documentation/devicetree/bindings/arm/ete.yaml b/Documentation/devicetree/bindings/arm/ete.yaml > new file mode 100644 > index 0000000..00e6a77 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ete.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +# Copyright 2021, Arm Ltd > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/ete.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: ARM Embedded Trace Extensions > + > +maintainers: > + - Suzuki K Poulose > + - Mathieu Poirier > + > +description: | > + Arm Embedded Trace Extension(ETE) is a per CPU trace component that > + allows tracing the CPU execution. It overlaps with the CoreSight ETMv4 > + architecture and has extended support for future architecture changes. > + The trace generated by the ETE could be stored via legacy CoreSight > + components (e.g, TMC-ETR) or other means (e.g, using a per CPU buffer > + Arm Trace Buffer Extension (TRBE)). Since the ETE can be connected to > + legacy CoreSight components, a node must be listed per instance, along > + with any optional connection graph as per the coresight bindings. > + See bindings/arm/coresight.txt. > + > +properties: > + $nodename: > + pattern: "^ete([0-9a-f]+)$" > + compatible: > + items: > + - const: arm,embedded-trace-extension > + > + cpu: We use 'cpus' in a couple of other places, let's do that here for consistency. > + description: | > + Handle to the cpu this ETE is bound to. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + out-ports: > + description: | > + Out put connections from the ETE to legacy CoreSight trace bus. Output > + $ref: /schemas/graph.yaml#/properties/ports You have to define what each 'port' is if there can be more than 1. If there's only ever 1 then you just need 'port' though maybe all the coresight bindings require 'out-ports'. And the port nodes need a $ref to '/schemas/graph.yaml#/properties/port'. > + > +required: > + - compatible > + - cpu > + > +additionalProperties: false > + > +examples: > + > +# An ETE node without legacy CoreSight connections > + - | > + ete0 { > + compatible = "arm,embedded-trace-extension"; > + cpu = <&cpu_0>; > + }; > +# An ETE node with legacy CoreSight connections > + - | > + ete1 { > + compatible = "arm,embedded-trace-extension"; > + cpu = <&cpu_1>; > + > + out-ports { /* legacy coresight connection */ > + port { > + ete1_out_port: endpoint { > + remote-endpoint = <&funnel_in_port0>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E593C433E6 for ; Mon, 25 Jan 2021 19:29:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7FB9224DF for ; Mon, 25 Jan 2021 19:29:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7FB9224DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gqw5Pp6xSXabSw0cQhmumyiThxOnT3QR+IHH2at+qBg=; b=D+ZQ6Oe/xkHcXk8TnBBYO7tKD 0c3uQiyXrSnd/zAYbWZYrKDj1sY8OwYcHEkAKOp5ve412GvIhciyBNDT31GxFm7RIfcO7Vk8XMxSP r1R2r0jXiL4p0N8SgXhF1y70W7yEevVdrlKP0u2CZUbOn7i7oWmaCN5xhjqXb/3n7Hg7Cdufaxg2E qfy+N5vMeqgJJxqjygzGjJWzrL6TE6SnXYcDqgwyi0rKYjG+iXke6EnW14L4bip78zM6vqRotHRTD eJtuHPWCkQcHZgLbFo6TOPVqDNHxJxNMU72vpattBWK7Hd8X96QaBZwyz+Fflrr5v1HYYMSoyK+JA AYUL0rjDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l47WC-00028m-U7; Mon, 25 Jan 2021 19:27:21 +0000 Received: from mail-oi1-f182.google.com ([209.85.167.182]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l47Rx-0008TZ-Jb for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 19:23:00 +0000 Received: by mail-oi1-f182.google.com with SMTP id r189so15969864oih.4 for ; Mon, 25 Jan 2021 11:22:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lJBccorxZ78ZbWSXWYq+VpysyyXbwoSq8AT6JmLKs/w=; b=OA58NVou2YWXK49cHvg0+oIxSYfJZl3nfKoHgjiu8I2v4QeCKMT2mOzQe4McDOXyoc x50bnbTPbNEdj8ZeeNRlqlnEyFiu+YRTT43C3j0ojpQBRMJvBARGzPmp+1FIYmUVoXB+ ETIrte8UqFnXInsCoVsCzBFA/phaaQuthPIkzzCdOlhU7KR22D5LoAe6D/947v5+NrOA wmxMidCJu5IS/9Z/Aod1JzY+oxgyQQjggA64vQya8ikBoXB6ykCUlG93pi2VVsC5YZlj iVWZsBICU2XVrzqP1QAn05Pi8q/mKcm2Pw/gouP3KnpIEyRJU0Nulyc8uTNr39sNppMr pbDA== X-Gm-Message-State: AOAM533KcJE4FAMz+tlqPlXYkS9h/DEVqsO9pcwrluZRHyRY+eH0EiEh 8vezOiUUBMyzbyH0s/xXiQ== X-Google-Smtp-Source: ABdhPJw8oBDePZvFx7h28Zdqx/oSirBM5F51dv0HF/xFXU2wHZkKa9wVzcmO8UDMhbR280BUU3EEBQ== X-Received: by 2002:aca:eb49:: with SMTP id j70mr1063871oih.90.1611602574947; Mon, 25 Jan 2021 11:22:54 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d127sm3363294oob.14.2021.01.25.11.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 11:22:53 -0800 (PST) Received: (nullmailer pid 805318 invoked by uid 1000); Mon, 25 Jan 2021 19:22:53 -0000 Date: Mon, 25 Jan 2021 13:22:53 -0600 From: Rob Herring To: Anshuman Khandual Subject: Re: [PATCH V2 06/11] dts: bindings: Document device tree bindings for ETE Message-ID: <20210125192253.GA791043@robh.at.kernel.org> References: <1610511498-4058-1-git-send-email-anshuman.khandual@arm.com> <1610511498-4058-7-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1610511498-4058-7-git-send-email-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_142257_716672_787DB00D X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linu Cherian , mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 13, 2021 at 09:48:13AM +0530, Anshuman Khandual wrote: > From: Suzuki K Poulose > > Document the device tree bindings for Embedded Trace Extensions. > ETE can be connected to legacy coresight components and thus > could optionally contain a connection graph as described by > the CoreSight bindings. > > Cc: devicetree@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Rob Herring > Signed-off-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > --- > Documentation/devicetree/bindings/arm/ete.yaml | 71 ++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ete.yaml > > diff --git a/Documentation/devicetree/bindings/arm/ete.yaml b/Documentation/devicetree/bindings/arm/ete.yaml > new file mode 100644 > index 0000000..00e6a77 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ete.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +# Copyright 2021, Arm Ltd > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/ete.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: ARM Embedded Trace Extensions > + > +maintainers: > + - Suzuki K Poulose > + - Mathieu Poirier > + > +description: | > + Arm Embedded Trace Extension(ETE) is a per CPU trace component that > + allows tracing the CPU execution. It overlaps with the CoreSight ETMv4 > + architecture and has extended support for future architecture changes. > + The trace generated by the ETE could be stored via legacy CoreSight > + components (e.g, TMC-ETR) or other means (e.g, using a per CPU buffer > + Arm Trace Buffer Extension (TRBE)). Since the ETE can be connected to > + legacy CoreSight components, a node must be listed per instance, along > + with any optional connection graph as per the coresight bindings. > + See bindings/arm/coresight.txt. > + > +properties: > + $nodename: > + pattern: "^ete([0-9a-f]+)$" > + compatible: > + items: > + - const: arm,embedded-trace-extension > + > + cpu: We use 'cpus' in a couple of other places, let's do that here for consistency. > + description: | > + Handle to the cpu this ETE is bound to. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + out-ports: > + description: | > + Out put connections from the ETE to legacy CoreSight trace bus. Output > + $ref: /schemas/graph.yaml#/properties/ports You have to define what each 'port' is if there can be more than 1. If there's only ever 1 then you just need 'port' though maybe all the coresight bindings require 'out-ports'. And the port nodes need a $ref to '/schemas/graph.yaml#/properties/port'. > + > +required: > + - compatible > + - cpu > + > +additionalProperties: false > + > +examples: > + > +# An ETE node without legacy CoreSight connections > + - | > + ete0 { > + compatible = "arm,embedded-trace-extension"; > + cpu = <&cpu_0>; > + }; > +# An ETE node with legacy CoreSight connections > + - | > + ete1 { > + compatible = "arm,embedded-trace-extension"; > + cpu = <&cpu_1>; > + > + out-ports { /* legacy coresight connection */ > + port { > + ete1_out_port: endpoint { > + remote-endpoint = <&funnel_in_port0>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel