All of
 help / color / mirror / Atom feed
* [merged] proc_sysctl-fix-oops-caused-by-incorrect-command-parameters.patch removed from -mm tree
@ 2021-01-25 21:35 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-01-25 21:35 UTC (permalink / raw)
  To: adobriyan, hkallweit1, keescook, mcgrof, mhiramat, mhocko,
	mm-commits, nixiaoming, rdunlap, stable, vbabka, yzaikin

The patch titled
     Subject: proc_sysctl: fix oops caused by incorrect command parameters
has been removed from the -mm tree.  Its filename was

This patch was dropped because it was merged into mainline or a subsystem tree

From: Xiaoming Ni <>
Subject: proc_sysctl: fix oops caused by incorrect command parameters

The process_sysctl_arg() does not check whether val is empty before
invoking strlen(val).  If the command line parameter () is incorrectly
configured and val is empty, oops is triggered.

For example:
  "hung_task_panic=1" is incorrectly written as "hung_task_panic", oops is
  triggered. The call stack is as follows:
    Kernel command line: .... hung_task_panic
    Call trace:

To fix it, check whether "val" is empty when "phram" is a sysctl field.
Error codes are returned in the failure branch, and error logs are
generated by parse_args().

Fixes: 3db978d480e2843 ("kernel/sysctl: support setting sysctl parameters from kernel command line")
Signed-off-by: Xiaoming Ni <>
Acked-by: Vlastimil Babka <>
Cc: Luis Chamberlain <>
Cc: Kees Cook <>
Cc: Iurii Zaikin <>
Cc: Alexey Dobriyan <>
Cc: Michal Hocko <>
Cc: Masami Hiramatsu <>
Cc: Heiner Kallweit <>
Cc: Randy Dunlap <>
Cc: <>	[5.8+]
Signed-off-by: Andrew Morton <>

 fs/proc/proc_sysctl.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--- a/fs/proc/proc_sysctl.c~proc_sysctl-fix-oops-caused-by-incorrect-command-parameters
+++ a/fs/proc/proc_sysctl.c
@@ -1770,6 +1770,12 @@ static int process_sysctl_arg(char *para
 			return 0;
+	if (!val)
+		return -EINVAL;
+	len = strlen(val);
+	if (len == 0)
+		return -EINVAL;
 	 * To set sysctl options, we use a temporary mount of proc, look up the
 	 * respective sys/ file and write to it. To avoid mounting it when no
@@ -1811,7 +1817,6 @@ static int process_sysctl_arg(char *para
 				file, param, val);
 		goto out;
-	len = strlen(val);
 	wret = kernel_write(file, val, len, &pos);
 	if (wret < 0) {
 		err = wret;

Patches currently in -mm which might be from are

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-25 22:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 21:35 [merged] proc_sysctl-fix-oops-caused-by-incorrect-command-parameters.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.