All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error
@ 2021-01-25 14:57 Matt Weber
  2021-01-25 14:57 ` [Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR Matt Weber
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Matt Weber @ 2021-01-25 14:57 UTC (permalink / raw)
  To: buildroot

From: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>

If Target u-boot is not available, the host build of uboot-tools
requires user to provide u-boot environment source file.
This change resolves a missing parentheses and updates the comment
for the same.

Signed-off-by: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
 package/uboot-tools/uboot-tools.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index 1313107e0e..10cbd1cdd9 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -139,11 +139,11 @@ ifeq ($(BR_BUILDING),y)
 ifeq ($(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SIZE)),)
 $(error Please provide U-Boot environment size (BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SIZE setting))
 endif
-# If U-Boot is available, ENVIMAGE_SOURCE is optional because the default can
-# be taken from U-Boot.
+# If U-Boot is not available, ENVIMAGE_SOURCE must be provided by user,
+# otherwise it is optional because the default can be taken from U-Boot
 ifeq ($(BR2_TARGET_UBOOT),)
-ifeq ($(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE),)
-$(error Please provide U-Boot environment file BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE setting))
+ifeq ($(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)),)
+$(error Please provide U-Boot environment file (BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE setting))
 endif
 endif #BR2_TARGET_UBOOT
 endif #BR_BUILDING
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-01-28 18:32 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 14:57 [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Matt Weber
2021-01-25 14:57 ` [Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR Matt Weber
2021-01-25 21:16   ` Thomas Petazzoni
2021-01-25 21:22     ` Matthew Weber
2021-01-25 21:42       ` Yann E. MORIN
2021-01-25 22:22         ` Thomas Petazzoni
2021-01-26 13:09           ` [Buildroot] [External] " Matthew Weber
2021-01-25 21:15 ` [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Thomas Petazzoni
2021-01-25 21:30   ` Matthew Weber
2021-01-25 21:37     ` Thomas Petazzoni
2021-01-28 18:32 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.