From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libssh: drop cmake workaround
Date: Mon, 25 Jan 2021 22:39:30 +0100 [thread overview]
Message-ID: <20210125223930.0066b5e3@windsurf.home> (raw)
In-Reply-To: <20210104171231.1621110-1-fontaine.fabrice@gmail.com>
On Mon, 4 Jan 2021 18:12:31 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Drop workaround for cmake < 3.10 (not needed since commit
> d4773b610a40be1d3ac7d793033abaf4eb2491ed)
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libssh/libssh.mk | 3 ---
> 1 file changed, 3 deletions(-)
Applied to master, thanks.
However, a quick git grep shows:
package/exiv2/exiv2.mk:EXIV2_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/i2pd/i2pd.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/i2pd/i2pd.mk:I2PD_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/librtlsdr/librtlsdr.mk:LIBRTLSDR_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/paho-mqtt-cpp/paho-mqtt-cpp.mk:PAHO_MQTT_CPP_CONF_OPTS = -DTHREADS_PTHREAD_ARG=OFF
package/poppler/poppler.mk:POPPLER_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/rabbitmq-c/rabbitmq-c.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/rabbitmq-c/rabbitmq-c.mk:RABBITMQ_C_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/uvw/uvw.mk:UVW_CONF_OPTS = -DTHREADS_PTHREAD_ARG=OFF
package/xerces/xerces.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/xerces/xerces.mk:XERCES_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/znc/znc.mk:# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
package/znc/znc.mk:ZNC_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
So there's perhaps some more cleaning that is possible ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2021-01-25 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 17:12 [Buildroot] [PATCH 1/1] package/libssh: drop cmake workaround Fabrice Fontaine
2021-01-25 21:39 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125223930.0066b5e3@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.