From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B6FC433DB for ; Tue, 26 Jan 2021 11:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 587922082D for ; Tue, 26 Jan 2021 11:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404967AbhAZLJW (ORCPT ); Tue, 26 Jan 2021 06:09:22 -0500 Received: from verein.lst.de ([213.95.11.211]:46956 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726110AbhAZGju (ORCPT ); Tue, 26 Jan 2021 01:39:50 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D544F68B02; Tue, 26 Jan 2021 07:39:08 +0100 (CET) Date: Tue, 26 Jan 2021 07:39:08 +0100 From: Christoph Hellwig To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 5/5] mm/vmalloc: improve allocation failure error messages Message-ID: <20210126063908.GE26674@lst.de> References: <20210126045404.2492588-1-npiggin@gmail.com> <20210126045404.2492588-6-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126045404.2492588-6-npiggin@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 02:54:04PM +1000, Nicholas Piggin wrote: > There are several reasons why a vmalloc can fail, virtual space > exhausted, page array allocation failure, page allocation failure, > and kernel page table allocation failure. > > Add distinct warning messages for the main causes of failure, with > some added information like page order or allocation size where > applicable. > > Signed-off-by: Nicholas Piggin Looks good, Reviewed-by: Christoph Hellwig