From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B02C433DB for ; Tue, 26 Jan 2021 11:13:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9EF8F23108 for ; Tue, 26 Jan 2021 11:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EF8F23108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 016D26B0010; Tue, 26 Jan 2021 06:13:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F09FE6B0012; Tue, 26 Jan 2021 06:13:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DABB68D00B0; Tue, 26 Jan 2021 06:13:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id C0A3B6B0010 for ; Tue, 26 Jan 2021 06:13:20 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 879891EE6 for ; Tue, 26 Jan 2021 11:13:20 +0000 (UTC) X-FDA: 77747664960.08.coast46_190fac92758d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 640101819E773 for ; Tue, 26 Jan 2021 11:13:20 +0000 (UTC) X-HE-Tag: coast46_190fac92758d X-Filterd-Recvd-Size: 3944 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 11:13:19 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id b26so22177495lff.9 for ; Tue, 26 Jan 2021 03:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xMoSN3ktIssK9ocNslHDiecO7+qlEJsoUm4+zvK4Ffg=; b=Olyf68v37hoKOVyT5lzrS7lNy1Uf5DTTB7bcB9wxvnZspHGlGIEsSEDG+5RP5faz4O doOFRHThnaA/Iogeoc3gu3COFTF4qJ3JWkLGQZzFqMVCDeYz4C4hMQDnDF3320gRC/bz +XYJ+wbwXtqxrAlK4nKZaJL5PlMErJA8woAM+kcCeEg09NtlVZZ/m4YrZ6SGQBJ8SN8J ded4nrJbj+e2TyyC93DVA35ho7QYdM1FPRe2SQy3WPIQWA6QwTKhHRrUzPEIH5XK1hZo mcKoI9mCHsQqHc45FwnSzLEcw+nko3g3kdb9CTPtnViooqrcKszCUA1ZJGb+BjuK6HJ8 vzWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xMoSN3ktIssK9ocNslHDiecO7+qlEJsoUm4+zvK4Ffg=; b=qtexRqyIfjRxEeDIxVlU8N+vag+16BAH9tk0wXV7/EcuEdLA6xw+w0/ZDUam/pC/Rf 57lLe0Rffn1cYNzFFdQnSsySeyNqFRxmHU2EBE33iI9JaXvTjE8N9O9eqdzldvhZcvHN z7mnK9lsxS9rLnGZDj/rYFm38tmluoY1KLmyOJzc2P0T6I7HiUZgTurgXVTvICR/gDlM 72pi2ppuukZLZZXeUi4oSK9msjQcR1iI5HNkL+OM6hepnTPnP79k5NUqSH6XAF9PRvBE ESw/kgvMOvcMgQ/ct1R+jrw9+l0gxhh259MTYxg1ZrdHrlFHbiWD6eHC4kkaeGkmLVWQ ApMg== X-Gm-Message-State: AOAM533nXA6yU+FqLTvjb/29kQoctn8BVuDIkKocJ65UI71iUjX+bpAU 6VnFmd76UyhKBBFc66DUYLA= X-Google-Smtp-Source: ABdhPJyiXE3KAI9RDuYVP9w7XludQqwSUE/cfaJx5I1VIVmBURa3mYuaiBbcB4XFPehgjf1NiWa3Hw== X-Received: by 2002:ac2:4f88:: with SMTP id z8mr2384340lfs.141.1611659598408; Tue, 26 Jan 2021 03:13:18 -0800 (PST) Received: from localhost.localdomain ([146.158.65.238]) by smtp.googlemail.com with ESMTPSA id o4sm1035204lfo.231.2021.01.26.03.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 03:13:17 -0800 (PST) From: Sabyrzhan Tasbolatov To: mhocko@suse.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, penguin-kernel@i-love.sakura.ne.jp, snovitoll@gmail.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2] mm: memdup_user*() should use same gfp flags Date: Tue, 26 Jan 2021 17:13:15 +0600 Message-Id: <20210126111315.858994-1-snovitoll@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210125154455.GO827@dhcp22.suse.cz> References: <20210125154455.GO827@dhcp22.suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Hmm, Sabyrzhan already proposed a patch that adds size check to the c= aller, but it seems > > that that patch missed smk_write_ambient()/smk_write_onlycap()/smk_wr= ite_unconfined() etc. > > Oh, bug-prone approach. Why not handle at memdup_user_nul() side? > I am sorry I do not follow. Tetsuo refers to this smackfs patch [1], where I've added a length check = before memdup_user_nul(). There are currently 39 references to this function, where length > PAGE_S= IZE - 1 or similar sanity check already presents. So I can't comment on handling it without __GFP_NOWARN at memdup_user_nul= () side. > > Hmm, Sabyrzhan already proposed a patch that adds size check to the c= aller, but it seems > > that that patch missed smk_write_ambient()/smk_write_onlycap()/smk_wr= ite_unconfined() etc. Thanks, I will prepare PATCH v2 with a length check for smk_write_* smack= fs functions in [1] patch set. [1] https://lore.kernel.org/linux-security-module/20210124143627.582115-1= -snovitoll@gmail.com/