All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Changheun Lee <nanich.lee@samsung.com>,
	Johannes.Thumshirn@wdc.com, asml.silence@gmail.com,
	axboe@kernel.dk, damien.lemoal@wdc.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	osandov@fb.com, patchwork-bot@kernel.org, tj@kernel.org,
	tom.leiming@gmail.com, jisoo2146.oh@samsung.com,
	junho89.kim@samsung.com, mj0123.lee@samsung.com,
	seunghwan.hyun@samsung.com, sookwan7.kim@samsung.com,
	woosung2.lee@samsung.com, yt0928.kim@samsung.com
Subject: Re: [PATCH v3 1/2] bio: limit bio max size
Date: Tue, 26 Jan 2021 15:05:19 +0000	[thread overview]
Message-ID: <20210126150519.GA1377213@infradead.org> (raw)
In-Reply-To: <20210126035748.GA1071341@T590>

On Tue, Jan 26, 2021 at 11:57:48AM +0800, Ming Lei wrote:
> >  				*same_page = false;
> >  				return false;
> >  			}
> 
> So far we don't need bio->bi_disk or bio->bi_bdev(will be changed in
> Christoph's patch) during adding page to bio, so there is null ptr
> refereance risk.

I've started resurrecting my old plan to always have a valid device
in the bio from allocation time on.  It is pretty invasive, but
probably worth it.  Sending out the first prep series right now, the
actual changes should be ready for an RFC later this week.

  parent reply	other threads:[~2021-01-26 15:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210126014805epcas1p2c4fc40f01c9c89b0a94ff6cac5408347@epcas1p2.samsung.com>
2021-01-26  1:32 ` [PATCH v3 1/2] bio: limit bio max size Changheun Lee
     [not found]   ` <CGME20210126014807epcas1p1a7274e9ba472286df03aac8e627b4633@epcas1p1.samsung.com>
2021-01-26  1:32     ` [PATCH v3 2/2] bio: add limit_bio_size sysfs Changheun Lee
2021-01-26  3:57   ` [PATCH v3 1/2] bio: limit bio max size Ming Lei
2021-01-26  4:06     ` Damien Le Moal
2021-01-26  6:07       ` Ming Lei
2021-01-26  6:26         ` Damien Le Moal
2021-01-26 11:54           ` Ming Lei
     [not found]             ` <CGME20210127005900epcas1p2456b0f3321b404995445b8654468c30e@epcas1p2.samsung.com>
2021-01-27  0:43               ` Changheun Lee
2021-01-26 15:05     ` Christoph Hellwig [this message]
     [not found] <CGME20210126093706epcas1p150e9b57a678f8724fa8ab9eddcec8a42@epcas1p1.samsung.com>
2021-01-26  9:21 ` Changheun Lee
2021-01-26 10:28   ` Damien Le Moal
     [not found]     ` <CGME20210127003642epcas1p4f167d553fc79ef5029a928550adbebea@epcas1p4.samsung.com>
2021-01-27  0:21       ` Changheun Lee
2021-01-27  1:03         ` Damien Le Moal
     [not found]           ` <CGME20210127053827epcas1p1e0cda00cdbfdacd5a3ede69c788d6710@epcas1p1.samsung.com>
2021-01-27  5:22             ` Changheun Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126150519.GA1377213@infradead.org \
    --to=hch@infradead.org \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=jisoo2146.oh@samsung.com \
    --cc=junho89.kim@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mj0123.lee@samsung.com \
    --cc=nanich.lee@samsung.com \
    --cc=osandov@fb.com \
    --cc=patchwork-bot@kernel.org \
    --cc=seunghwan.hyun@samsung.com \
    --cc=sookwan7.kim@samsung.com \
    --cc=tj@kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=woosung2.lee@samsung.com \
    --cc=yt0928.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.