From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A11FC433E0 for ; Tue, 26 Jan 2021 16:50:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9667229C9 for ; Tue, 26 Jan 2021 16:50:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9667229C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.75311.135557 (Exim 4.92) (envelope-from ) id 1l4RXM-0006tv-S9; Tue, 26 Jan 2021 16:49:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 75311.135557; Tue, 26 Jan 2021 16:49:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4RXM-0006to-O4; Tue, 26 Jan 2021 16:49:52 +0000 Received: by outflank-mailman (input) for mailman id 75311; Tue, 26 Jan 2021 16:49:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4RXL-0006ti-9h for xen-devel@lists.xenproject.org; Tue, 26 Jan 2021 16:49:51 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 285a156f-c45d-40c1-9603-cf6446329104; Tue, 26 Jan 2021 16:49:49 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [IPv6:2001:41d0:fe9d:1100:221:70ff:fe0c:9885]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 10QGngxm024498; Tue, 26 Jan 2021 17:49:42 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id F3F9B281D; Tue, 26 Jan 2021 17:49:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 285a156f-c45d-40c1-9603-cf6446329104 Date: Tue, 26 Jan 2021 17:49:41 +0100 From: Manuel Bouyer To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Subject: Re: [PATCH] NetBSD hotplug: handle case where vifname is not present Message-ID: <20210126164941.GB8309@antioche.eu.org> References: <20210112181242.1570-1-bouyer@antioche.eu.org> <20210112181242.1570-5-bouyer@antioche.eu.org> <20210115160659.hux7u7cbwktfog32@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210115160659.hux7u7cbwktfog32@Air-de-Roger> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [IPv6:2001:41d0:fe9d:1100:a00:20ff:fe1c:276e]); Tue, 26 Jan 2021 17:49:42 +0100 (MET) On Fri, Jan 15, 2021 at 05:06:59PM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:25PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Some Xen version didn't set the vifname in xenstore; just build one if > > not present. > > I think the current version (what's going to become 4.15) should write > the vifname in all cases? If not that's likely an error that we should > fix elsewhere IMO. > > Can you check whether the current version has this error present? And > whether it affects PV or HVM guests? Yes, in recent Xen version this doesn't seem to be needed any more. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --