From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/spdlog: support dynamic library
Date: Tue, 26 Jan 2021 19:56:29 +0100 [thread overview]
Message-ID: <20210126185629.GE2325@scaer> (raw)
In-Reply-To: <20210126175456.2181332-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-01-26 18:54 +0100, Fabrice Fontaine spake thusly:
> spdlog can install a shared library since version 1.4.0 and
> https://github.com/gabime/spdlog/commit/45a18a61c633564311e51f5cbed2748e9cb70e2f
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/spdlog/Config.in | 2 +-
> package/spdlog/spdlog.mk | 9 ++++++---
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/package/spdlog/Config.in b/package/spdlog/Config.in
> index 4aee1f7dd1..877c1b6ab7 100644
> --- a/package/spdlog/Config.in
> +++ b/package/spdlog/Config.in
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_SPDLOG
> depends on BR2_USE_WCHAR # fmt
> select BR2_PACKAGE_FMT
> help
> - Very fast, header only, C++ logging library.
> + Very fast, header-only/compiled, C++ logging library.
>
> https://github.com/gabime/spdlog
>
> diff --git a/package/spdlog/spdlog.mk b/package/spdlog/spdlog.mk
> index 3c745f60ad..f5b331526a 100644
> --- a/package/spdlog/spdlog.mk
> +++ b/package/spdlog/spdlog.mk
> @@ -8,6 +8,7 @@ SPDLOG_VERSION = 1.8.1
> SPDLOG_SITE = $(call github,gabime,spdlog,v$(SPDLOG_VERSION))
> SPDLOG_LICENSE = MIT
> SPDLOG_LICENSE_FILES = LICENSE
> +SPDLOG_INSTALL_STAGING = YES
> SPDLOG_DEPENDENCIES = fmt
> SPDLOG_CONF_OPTS += \
> -DSPDLOG_BUILD_TESTS=OFF \
> @@ -15,8 +16,10 @@ SPDLOG_CONF_OPTS += \
> -DSPDLOG_BUILD_BENCH=OFF \
> -DSPDLOG_FMT_EXTERNAL=ON
>
> -# Header-only library
> -SPDLOG_INSTALL_STAGING = YES
> -SPDLOG_INSTALL_TARGET = NO
> +ifeq ($(BR2_STATIC_LIBS),y)
> +SPDLOG_CONF_OPTS += -DSPDLOG_BUILD_SHARED=OFF
> +else
> +SPDLOG_CONF_OPTS += -DSPDLOG_BUILD_SHARED=ON
> +endif
>
> $(eval $(cmake-package))
> --
> 2.29.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-01-26 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:54 [Buildroot] [PATCH 1/1] package/spdlog: support dynamic library Fabrice Fontaine
2021-01-26 18:56 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126185629.GE2325@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.