* [net-next] tipc: remove duplicated code in tipc_msg_create
@ 2021-01-27 2:51 Hoang Huu Le
2021-01-28 3:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Hoang Huu Le @ 2021-01-27 2:51 UTC (permalink / raw)
To: netdev, ying.xue; +Cc: maloy, jmaloy
Remove a duplicate code checking for header size in tipc_msg_create() as
it's already being done in tipc_msg_init().
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au>
---
net/tipc/msg.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/tipc/msg.c b/net/tipc/msg.c
index 2aca86021df5..e9263280a2d4 100644
--- a/net/tipc/msg.c
+++ b/net/tipc/msg.c
@@ -117,10 +117,6 @@ struct sk_buff *tipc_msg_create(uint user, uint type,
msg_set_origport(msg, oport);
msg_set_destport(msg, dport);
msg_set_errcode(msg, errcode);
- if (hdr_sz > SHORT_H_SIZE) {
- msg_set_orignode(msg, onode);
- msg_set_destnode(msg, dnode);
- }
return buf;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next] tipc: remove duplicated code in tipc_msg_create
2021-01-27 2:51 [net-next] tipc: remove duplicated code in tipc_msg_create Hoang Huu Le
@ 2021-01-28 3:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-28 3:00 UTC (permalink / raw)
To: Hoang Huu Le; +Cc: netdev, ying.xue, maloy, jmaloy
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 09:51:23 +0700 you wrote:
> Remove a duplicate code checking for header size in tipc_msg_create() as
> it's already being done in tipc_msg_init().
>
> Acked-by: Jon Maloy <jmaloy@redhat.com>
> Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au>
> ---
> net/tipc/msg.c | 4 ----
> 1 file changed, 4 deletions(-)
Here is the summary with links:
- [net-next] tipc: remove duplicated code in tipc_msg_create
https://git.kernel.org/netdev/net-next/c/2a9063b7ffac
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-28 3:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 2:51 [net-next] tipc: remove duplicated code in tipc_msg_create Hoang Huu Le
2021-01-28 3:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.