From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7732C433E0 for ; Wed, 27 Jan 2021 09:05:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A24F20758 for ; Wed, 27 Jan 2021 09:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234873AbhA0JEy (ORCPT ); Wed, 27 Jan 2021 04:04:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45060 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234570AbhA0JA5 (ORCPT ); Wed, 27 Jan 2021 04:00:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611737970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8F3p75SyEOVyX3ahfiz9umwfm5OOcgRN90TvZg1YzTg=; b=UTd+TkOvOKeKZ4+glrWCNUsQrN0SUTMycA5KT6vViJxw4go594t1Xc9J10/TQRK3M+Txzl UE6Q3jsYI/5qoa2HEWhcVClv0vzeD0D42eX82LtCw7WnSzCAmwmdr/EvyRsePyixBXg6I7 m8+zrh3e1br63kD+S/HLRorTabaQAAw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-512--sIErlMyM8yhRuDbDXfgnA-1; Wed, 27 Jan 2021 03:59:28 -0500 X-MC-Unique: -sIErlMyM8yhRuDbDXfgnA-1 Received: by mail-wr1-f70.google.com with SMTP id x7so594639wrp.9 for ; Wed, 27 Jan 2021 00:59:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8F3p75SyEOVyX3ahfiz9umwfm5OOcgRN90TvZg1YzTg=; b=mYEboXhh14HyM/jhtQqUBXqP7oRCbqlAVOAS6Iu5GRKKF2QJP1yIs4de4FFGkf1e0h cl9RlE+EaJ17NyY1hEbOErOsrhV6UrxcqZFr9UxQhKNU7BxyevfgmhsyGPjWHBRWELKv wzHb2euTq7R3JyiSfmk/hUfHlvri/LDz0mI9cplbKETGmXMR/eQ36hDRhsWxGeSbV/8s 26G7WBuvSRrqu0a7jlaBtM9zI+B+cy5EWPLh2YNBFkx8Aza3xLd9p6nLHPwr/ETuHNmz 9UYd6VvRNHLDROX7pUTDKfhcmPq8n2nKbgywy+OF55GbIWPjK69cIFbgFVPu1tgPesP0 Q+oQ== X-Gm-Message-State: AOAM531g/5qhxnzJF1pve9mYn+Ajh+b+sMsUswruN28C1OO3Oy94AQZc 57pSCg2ekNdSUQ+umVOYw4B2/INOLp4VVxZfaXeBcL+caNg+q3eIMQiKr2j6HxY4o6xuX9vvAaf 8Q7bJmBxRZXokgCwl X-Received: by 2002:a7b:cbd5:: with SMTP id n21mr3389387wmi.5.1611737967363; Wed, 27 Jan 2021 00:59:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJx6IR+GVVU30LyX9/KtKDCb/OF5xsvG/DpsrTzfFCkbaLPd/jhOGfpVe/ATCJ4R5nOCfXI/lQ== X-Received: by 2002:a7b:cbd5:: with SMTP id n21mr3389372wmi.5.1611737967139; Wed, 27 Jan 2021 00:59:27 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id w126sm1817491wma.43.2021.01.27.00.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 00:59:26 -0800 (PST) Date: Wed, 27 Jan 2021 09:59:24 +0100 From: Stefano Garzarella To: Xie Yongji Cc: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com, parav@nvidia.com, bob.liu@oracle.com, hch@infradead.org, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices Message-ID: <20210127085924.ktgmsgn6k3zegd67@steredhat> References: <20210119045920.447-1-xieyongji@bytedance.com> <20210119045920.447-4-xieyongji@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210119045920.447-4-xieyongji@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 19, 2021 at 12:59:12PM +0800, Xie Yongji wrote: >With VDUSE, we should be able to support all kinds of virtio devices. > >Signed-off-by: Xie Yongji >--- > drivers/vhost/vdpa.c | 29 +++-------------------------- > 1 file changed, 3 insertions(+), 26 deletions(-) > >diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >index 29ed4173f04e..448be7875b6d 100644 >--- a/drivers/vhost/vdpa.c >+++ b/drivers/vhost/vdpa.c >@@ -22,6 +22,7 @@ > #include > #include > #include >+#include Is this inclusion necessary? Maybe we can remove virtio_net.h as well. Thanks, Stefano > > #include "vhost.h" > >@@ -185,26 +186,6 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp) > return 0; > } > >-static int vhost_vdpa_config_validate(struct vhost_vdpa *v, >- struct vhost_vdpa_config *c) >-{ >- long size = 0; >- >- switch (v->virtio_id) { >- case VIRTIO_ID_NET: >- size = sizeof(struct virtio_net_config); >- break; >- } >- >- if (c->len == 0) >- return -EINVAL; >- >- if (c->len > size - c->off) >- return -E2BIG; >- >- return 0; >-} >- > static long vhost_vdpa_get_config(struct vhost_vdpa *v, > struct vhost_vdpa_config __user *c) > { >@@ -215,7 +196,7 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, > > if (copy_from_user(&config, c, size)) > return -EFAULT; >- if (vhost_vdpa_config_validate(v, &config)) >+ if (config.len == 0) > return -EINVAL; > buf = kvzalloc(config.len, GFP_KERNEL); > if (!buf) >@@ -243,7 +224,7 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > > if (copy_from_user(&config, c, size)) > return -EFAULT; >- if (vhost_vdpa_config_validate(v, &config)) >+ if (config.len == 0) > return -EINVAL; > buf = kvzalloc(config.len, GFP_KERNEL); > if (!buf) >@@ -1025,10 +1006,6 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa) > int minor; > int r; > >- /* Currently, we only accept the network devices. */ >- if (ops->get_device_id(vdpa) != VIRTIO_ID_NET) >- return -ENOTSUPP; >- > v = kzalloc(sizeof(*v), GFP_KERNEL | __GFP_RETRY_MAYFAIL); > if (!v) > return -ENOMEM; >-- >2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1304C433E6 for ; Wed, 27 Jan 2021 08:59:38 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 528C720757 for ; Wed, 27 Jan 2021 08:59:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 528C720757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C03E084B1C; Wed, 27 Jan 2021 08:59:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DVb4fqzSlq5t; Wed, 27 Jan 2021 08:59:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 38415849F0; Wed, 27 Jan 2021 08:59:37 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 27136C0FA7; Wed, 27 Jan 2021 08:59:37 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8CCFBC013A for ; Wed, 27 Jan 2021 08:59:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 72A6D2078C for ; Wed, 27 Jan 2021 08:59:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xavmQdyoDrTl for ; Wed, 27 Jan 2021 08:59:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by silver.osuosl.org (Postfix) with ESMTPS id 89D1B2049C for ; Wed, 27 Jan 2021 08:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611737972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8F3p75SyEOVyX3ahfiz9umwfm5OOcgRN90TvZg1YzTg=; b=YQ37sOpTPh9Wfptv1+7I4yQwqbvrNyQZwCf7QRK2/HGhOSdR/7nlGuOSkSm+pWRlp2nvuz OY4awsgESh6aMfTtYyhshDYH6weBQ9DtKVjrUPOrPd8z7VyPDsAUl65GgBxct7DePIOZWn dPW61iDhpG5ZiI95mehxbI5zsG8oEcU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-512-hYTQYJ3xPciXuXh4OgfmOA-1; Wed, 27 Jan 2021 03:59:28 -0500 X-MC-Unique: hYTQYJ3xPciXuXh4OgfmOA-1 Received: by mail-wr1-f69.google.com with SMTP id o17so606948wrv.4 for ; Wed, 27 Jan 2021 00:59:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8F3p75SyEOVyX3ahfiz9umwfm5OOcgRN90TvZg1YzTg=; b=jcJ6tdSe04gvqL7klL0kwPmWDcKvDRJkfmMGUufaCwUrcfAudvcx5Uviipl8ttdIqF vuLS5GLUwQMZQxErxFA5LCi98a4QkNp8Qo7+YiRgHvbm5u1iOJ2dthDjUqpIPX95Ifje MqQ7KRUTB2JCefeXPoRP0JDg4XbXFxh9MuqctyAgmUTp4gKSSD3TFvdmcyo6JEyj332s tYk1L64+TDGOpYq+gAOzz8gA90nbSCkROfjn6dWyC8qH4zoLsnIRntPJYvjNLYzpWXFs WxDg6CksyrYc8yQv+727XfeI3PpOxSFknu094PAap4VRSo4JsHh8piPhbglOcJUk/zx6 VL0w== X-Gm-Message-State: AOAM530OB5LkPeOacBxQL3TqM78r4C4okxoeIX6DUDQ209k6F9BzokfN TZzpBtibtAsQi4BoOs5gRUygtxAE6cckuBU9GOQHpN8zVn3tVrLLGpSHYlOKlvrwTsC9HNQ12wv dshVK6h8VLaw3xbqugFrvu78Xi6+5Gb2too9tg9Wy+A== X-Received: by 2002:a7b:cbd5:: with SMTP id n21mr3389396wmi.5.1611737967364; Wed, 27 Jan 2021 00:59:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJx6IR+GVVU30LyX9/KtKDCb/OF5xsvG/DpsrTzfFCkbaLPd/jhOGfpVe/ATCJ4R5nOCfXI/lQ== X-Received: by 2002:a7b:cbd5:: with SMTP id n21mr3389372wmi.5.1611737967139; Wed, 27 Jan 2021 00:59:27 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id w126sm1817491wma.43.2021.01.27.00.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 00:59:26 -0800 (PST) Date: Wed, 27 Jan 2021 09:59:24 +0100 From: Stefano Garzarella To: Xie Yongji Subject: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices Message-ID: <20210127085924.ktgmsgn6k3zegd67@steredhat> References: <20210119045920.447-1-xieyongji@bytedance.com> <20210119045920.447-4-xieyongji@bytedance.com> MIME-Version: 1.0 In-Reply-To: <20210119045920.447-4-xieyongji@bytedance.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: axboe@kernel.dk, corbet@lwn.net, kvm@vger.kernel.org, mst@redhat.com, linux-aio@kvack.org, netdev@vger.kernel.org, rdunlap@infradead.org, willy@infradead.org, virtualization@lists.linux-foundation.org, hch@infradead.org, bob.liu@oracle.com, bcrl@kvack.org, viro@zeniv.linux.org.uk, stefanha@redhat.com, linux-fsdevel@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Jan 19, 2021 at 12:59:12PM +0800, Xie Yongji wrote: >With VDUSE, we should be able to support all kinds of virtio devices. > >Signed-off-by: Xie Yongji >--- > drivers/vhost/vdpa.c | 29 +++-------------------------- > 1 file changed, 3 insertions(+), 26 deletions(-) > >diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >index 29ed4173f04e..448be7875b6d 100644 >--- a/drivers/vhost/vdpa.c >+++ b/drivers/vhost/vdpa.c >@@ -22,6 +22,7 @@ > #include > #include > #include >+#include Is this inclusion necessary? Maybe we can remove virtio_net.h as well. Thanks, Stefano > > #include "vhost.h" > >@@ -185,26 +186,6 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp) > return 0; > } > >-static int vhost_vdpa_config_validate(struct vhost_vdpa *v, >- struct vhost_vdpa_config *c) >-{ >- long size = 0; >- >- switch (v->virtio_id) { >- case VIRTIO_ID_NET: >- size = sizeof(struct virtio_net_config); >- break; >- } >- >- if (c->len == 0) >- return -EINVAL; >- >- if (c->len > size - c->off) >- return -E2BIG; >- >- return 0; >-} >- > static long vhost_vdpa_get_config(struct vhost_vdpa *v, > struct vhost_vdpa_config __user *c) > { >@@ -215,7 +196,7 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, > > if (copy_from_user(&config, c, size)) > return -EFAULT; >- if (vhost_vdpa_config_validate(v, &config)) >+ if (config.len == 0) > return -EINVAL; > buf = kvzalloc(config.len, GFP_KERNEL); > if (!buf) >@@ -243,7 +224,7 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > > if (copy_from_user(&config, c, size)) > return -EFAULT; >- if (vhost_vdpa_config_validate(v, &config)) >+ if (config.len == 0) > return -EINVAL; > buf = kvzalloc(config.len, GFP_KERNEL); > if (!buf) >@@ -1025,10 +1006,6 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa) > int minor; > int r; > >- /* Currently, we only accept the network devices. */ >- if (ops->get_device_id(vdpa) != VIRTIO_ID_NET) >- return -ENOTSUPP; >- > v = kzalloc(sizeof(*v), GFP_KERNEL | __GFP_RETRY_MAYFAIL); > if (!v) > return -ENOMEM; >-- >2.11.0 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization