From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D8BC433E0 for ; Wed, 27 Jan 2021 10:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C32AC2074B for ; Wed, 27 Jan 2021 10:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235696AbhA0KzK (ORCPT ); Wed, 27 Jan 2021 05:55:10 -0500 Received: from foss.arm.com ([217.140.110.172]:38626 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235846AbhA0KwS (ORCPT ); Wed, 27 Jan 2021 05:52:18 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DD491042; Wed, 27 Jan 2021 02:51:32 -0800 (PST) Received: from e123648.arm.com (unknown [10.57.4.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 78B783F66B; Wed, 27 Jan 2021 02:51:28 -0800 (PST) From: Lukasz Luba To: linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, lima@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: yuq825@gmail.com, christianshewitt@gmail.com, lukasz.luba@arm.com Subject: [PATCH] drm/lima: Use delayed timer as default in devfreq profile Date: Wed, 27 Jan 2021 10:51:21 +0000 Message-Id: <20210127105121.20345-1-lukasz.luba@arm.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Devfreq framework supports 2 modes for monitoring devices. Use delayed timer as default instead of deferrable timer in order to monitor the GPU status regardless of CPU idle. Signed-off-by: Lukasz Luba --- Hi all, I've missed the Lima driver while working on Panfrost patch for fixing the issue with default devfreq framework polling mode. More about this and the patch, can be found here [1]. Regards, Lukasz Luba [1] https://lore.kernel.org/lkml/20210105164111.30122-1-lukasz.luba@arm.com/ drivers/gpu/drm/lima/lima_devfreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index 5686ad4aaf7c..f1c9eb3e71bd 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.c +++ b/drivers/gpu/drm/lima/lima_devfreq.c @@ -81,6 +81,7 @@ static int lima_devfreq_get_dev_status(struct device *dev, } static struct devfreq_dev_profile lima_devfreq_profile = { + .timer = DEVFREQ_TIMER_DELAYED, .polling_ms = 50, /* ~3 frames */ .target = lima_devfreq_target, .get_dev_status = lima_devfreq_get_dev_status, -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A20C0C433E6 for ; Thu, 28 Jan 2021 08:17:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D6846146D for ; Thu, 28 Jan 2021 08:17:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D6846146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5725689100; Thu, 28 Jan 2021 08:16:44 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 665C66E3D0; Wed, 27 Jan 2021 10:51:33 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DD491042; Wed, 27 Jan 2021 02:51:32 -0800 (PST) Received: from e123648.arm.com (unknown [10.57.4.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 78B783F66B; Wed, 27 Jan 2021 02:51:28 -0800 (PST) From: Lukasz Luba To: linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, lima@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/lima: Use delayed timer as default in devfreq profile Date: Wed, 27 Jan 2021 10:51:21 +0000 Message-Id: <20210127105121.20345-1-lukasz.luba@arm.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Thu, 28 Jan 2021 08:15:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: christianshewitt@gmail.com, yuq825@gmail.com, lukasz.luba@arm.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Devfreq framework supports 2 modes for monitoring devices. Use delayed timer as default instead of deferrable timer in order to monitor the GPU status regardless of CPU idle. Signed-off-by: Lukasz Luba --- Hi all, I've missed the Lima driver while working on Panfrost patch for fixing the issue with default devfreq framework polling mode. More about this and the patch, can be found here [1]. Regards, Lukasz Luba [1] https://lore.kernel.org/lkml/20210105164111.30122-1-lukasz.luba@arm.com/ drivers/gpu/drm/lima/lima_devfreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index 5686ad4aaf7c..f1c9eb3e71bd 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.c +++ b/drivers/gpu/drm/lima/lima_devfreq.c @@ -81,6 +81,7 @@ static int lima_devfreq_get_dev_status(struct device *dev, } static struct devfreq_dev_profile lima_devfreq_profile = { + .timer = DEVFREQ_TIMER_DELAYED, .polling_ms = 50, /* ~3 frames */ .target = lima_devfreq_target, .get_dev_status = lima_devfreq_get_dev_status, -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel